Uh oh!
There was an error while loading. Please reload this page.
test: fix test failure with shared openssl - #762
Conversation
There was a problem hiding this comment.
kind of very irrelevant, but built-in
There was a problem hiding this comment.
@brendanashworth Do you have a proper word? I think of others such as bundled or included command in iojs or to delete this comment.
jbergstroem
commented
Feb 9, 2015
The openssl binary is now properly called. Minor language nits, but lgtm. |
There was a problem hiding this comment.
Ideally, this only runs when the openssl binary is actually needed. Spawning a child process adds a few milliseconds to each test; multiplied by ~600 tests, that's a couple of extra seconds. Maybe you can turn the .opensslCli property into a lazy getter?
shigeki
commented
Feb 9, 2015
@bnoordhuis Thanks for your review. Indeed, |
There was a problem hiding this comment.
Maybe add a if (opensslCli !== null) return opensslCli; at the top? Avoids multiple invocations of the openssl binary.
EDIT: Never mind, I see you're doing that below. Just curious: is there a reason to split the logic into two functions?
There was a problem hiding this comment.
@bnoordhuis Splitting is just for easy to read and notify this is a getter function. I don't mind to change it into inline.
There was a problem hiding this comment.
Inline is a little easier to comprehend when you read the code top-down.
bnoordhuis
commented
Feb 9, 2015
LGTM with a question. |
When configured with share openssl, use external openssl command and check if it can be executed. Fixes: nodejs#618
shigeki
commented
Feb 9, 2015
@bnoordhuis Changed this into inline and landed c86e383 . Thanks |
shigeki
commented
Feb 9, 2015
@brendanashworth The comment was revised more clearly as c86e383#diff-8736c5cbff21e1dee18b0c86d3d2689dR32 according your review. Thanks. |
When configured with share openssl, use external openssl command and check if it can be executed.
Fixes: #618
Cc: @jbergstroem
Please someone in @iojs/collaborators review this.