Uh oh!
There was an error while loading. Please reload this page.
deps: cherry-pick d721121 from v8 upstream - #7632
Conversation
targos
commented
Jul 9, 2016
LGTM |
Original commit message: Quit creating array literal boilerplates from Crankshaft. It's such a corner case. BUG= Review URL: https://codereview.chromium.org/1865013002 Cr-Commit-Position: refs/heads/master@{nodejs#35346} Fixes: nodejs#7454 PR-URL: nodejs#7632 Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
bnoordhuis
commented
Jul 11, 2016
Green apart from a flaky network test. Landed in 839f3d9, thanks for the review. |
bnoordhuis
commented
Jul 11, 2016
Crap, I forgot to bump the patchlevel. Mea culpa, I'll follow up with a PR later today. |
ofrobots
commented
Jul 11, 2016
We should get confirmation from the V8 team that it is okay for us to be bumping the patch level for the 5.1 branch for our copy given that it is freshly abandoned. If a merge happens upstream, we would get into a very confusing state with the version numbers. /cc @natorion. |
targos
commented
Jul 11, 2016
Is it a new rule that we have to bump the patch level ? |
bnoordhuis
commented
Jul 11, 2016
We should start doing that once we become the de facto upstream, yes. My merge request for 5.1 got rejected earlier today so I think we've reached that point. :-) |
MylesBorins
commented
Jul 11, 2016
@bnoordhuis we are having an LTS meeting Monday morning with stakeholders from V8 to discuss having official LTS release streams so that we can use their official process to backport changes. Would you like to join? |
bnoordhuis
commented
Jul 11, 2016
s/Monday/Wednesday/? It says the date is the 13th. I would but I don't know if I can. |
MylesBorins
commented
Jul 11, 2016
@bnoordhuis it is indeed Wednesday... we were picking between dates and I had too many in my head. If you can't make it please feel free to let me know anything you think should be mentioned and I'll make sure it is brought up |
bnoordhuis
commented
Jul 12, 2016
I'll see if I can join. In case I can't make it:
|
evanlucas
commented
Jul 15, 2016
should this land in v6 or does it need to wait since v6 is still on v8 v5.0.x? |
targos
commented
Jul 15, 2016
This should not land in v6. The v6.x version of this patch is here |
evanlucas
commented
Jul 15, 2016
Ah thanks @targos! |
ofrobots
commented
Jul 15, 2016
My concern was only that we should notify upstream that we have started bumping the patch level. Given that V8 5.1 was so 'fresly abandonded' it is sometimes possible that upstream might change plans and allow a few more merges after one has been rejected (example). My pinging of @natorion above is probably enough notification of upstream. |
Original commit message: Quit creating array literal boilerplates from Crankshaft. It's such a corner case. BUG= Review URL: https://codereview.chromium.org/1865013002 Cr-Commit-Position: refs/heads/master@{nodejs#35346} Fixes: nodejs#7454 PR-URL: nodejs#7632 Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Original commit message:
Fixes: #7454
R=@nodejs/v8
CI: https://ci.nodejs.org/job/node-test-pull-request/3230/
CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/187/