Skip to content

util: inspect boxed symbols like other primitives - #7641

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:util-inspect-symbol
Closed

util: inspect boxed symbols like other primitives#7641
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:util-inspect-symbol

Conversation

@addaleax

@addaleaxaddaleax commented Jul 9, 2016•
edited
Loading

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

util

Description of change

Inspect boxed symbol objects in the same way other boxed primitives are inspected.

Fixes: #7639

CI: https://ci.nodejs.org/job/node-test-commit/4039/

@addaleax
util: inspect boxed symbols like other primitives
8e7ebf3
Inspect boxed symbol objects in the same way other boxed primitives
are inspected.
Fixes: nodejs#7639
@addaleaxaddaleax added the util Issues and PRs related to the built-in util module. label Jul 9, 2016
@addaleaxaddaleax mentioned this pull request Jul 9, 2016
Closed
@targos

targos commented Jul 10, 2016

Copy link
Copy Markdown
Member

LGTM

3 similar comments
@bnoordhuis

bnoordhuis commented Jul 10, 2016

Copy link
Copy Markdown
Member

LGTM

@benjamingr

benjamingr commented Jul 10, 2016

Copy link
Copy Markdown
Member

LGTM

@cjihrig

cjihrig commented Jul 11, 2016

Copy link
Copy Markdown
Contributor

LGTM

thefourtheye
thefourtheye reviewed Jul 13, 2016
View reviewed changes
Comment threadtest/parallel/test-util-inspect.js

// test boxed primitives output the correct values
assert.equal(util.inspect(new String('test')), '[String: \'test\']');
assert.equal(util.inspect(Object(Symbol('test'))), '[Symbol: Symbol(test)]');

@thefourtheyethefourtheyeJul 13, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this look like having redundant information?

@bnoordhuisbnoordhuisJul 13, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, IMO. It conveys that it's a symbol wrapped in an object; i.e., that typeof object === 'object' but that typeof object.valueOf() === 'symbol'.

@addaleaxaddaleaxJul 13, 2016

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thefourtheye I think learning the difference between Symbol(test) and [Symbol: test] might be a bit harder for people new to symbols.

This way might not be perfect, but I think the consistency with how other boxed values are displayed makes it easier to reason about what exactly is being displayed.

@thefourtheyethefourtheyeJul 13, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. LGTM.

@addaleax

addaleax commented Jul 17, 2016

Copy link
Copy Markdown
MemberAuthor

Landed in 35e8c94

@addaleax
addaleax deleted the util-inspect-symbol branch July 17, 2016 16:11
addaleax added a commit that referenced this pull request Jul 17, 2016
@addaleax
util: inspect boxed symbols like other primitives
35e8c94
Inspect boxed symbol objects in the same way other boxed primitives
are inspected.
Fixes: #7639
PR-URL: #7641
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
evanlucas pushed a commit that referenced this pull request Jul 19, 2016
@addaleax@evanlucas
util: inspect boxed symbols like other primitives
60c459c
Inspect boxed symbol objects in the same way other boxed primitives
are inspected.
Fixes: #7639
PR-URL: #7641
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@evanlucasevanlucas mentioned this pull request Jul 19, 2016
Merged
evanlucas pushed a commit that referenced this pull request Jul 20, 2016
@addaleax@evanlucas
util: inspect boxed symbols like other primitives
0858e62
Inspect boxed symbol objects in the same way other boxed primitives
are inspected.
Fixes: #7639
PR-URL: #7641
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
evanlucas added a commit that referenced this pull request Jul 21, 2016
@evanlucas
2016-07-21, Version 6.3.1 (Current)
623bd46
Notable changes:
* **buffer**:
* Improve performance of Buffer.from(str, 'hex') and Buffer#write(str, 'hex'). (Christopher Jeffrey) #7602
* Fix creating from zero-length ArrayBuffer. (Ingvar Stepanyan) #7176
* **deps**: Upgrade to V8 5.0.71.xx. (Ben Noordhuis) #7531
* **repl**: Fix issue with function redeclaration. (Prince J Wesley) #7794
* **util**: Fix inspecting of boxed symbols. (Anna Henningsen) #7641
PR-URL: #7782
evanlucas added a commit that referenced this pull request Jul 21, 2016
@evanlucas
2016-07-21, Version 6.3.1 (Current)
f135a4c
Notable changes:
* **buffer**:
* Improve performance of Buffer.from(str, 'hex') and Buffer#write(str, 'hex'). (Christopher Jeffrey) #7602
* Fix creating from zero-length ArrayBuffer. (Ingvar Stepanyan) #7176
* **deps**:
* Upgrade to V8 5.0.71.xx. (Ben Noordhuis) #7531
* Backport V8 instanceof bugfix (Franziska Hinkelmann) #7638
* **repl**: Fix issue with function redeclaration. (Prince J Wesley) #7794
* **util**: Fix inspecting of boxed symbols. (Anna Henningsen) #7641
PR-URL: #7782
evanlucas added a commit that referenced this pull request Jul 21, 2016
@evanlucas
2016-07-21, Version 6.3.1 (Current)
c21a212
Notable changes:
* **buffer**:
* Improve performance of Buffer.from(str, 'hex') and Buffer#write(str, 'hex'). (Christopher Jeffrey) #7602
* Fix creating from zero-length ArrayBuffer. (Ingvar Stepanyan) #7176
* **deps**:
* Upgrade to V8 5.0.71.xx. (Ben Noordhuis) #7531
* Backport V8 instanceof bugfix (Franziska Hinkelmann) #7638
* **repl**: Fix issue with function redeclaration. (Prince J Wesley) #7794
* **util**: Fix inspecting of boxed symbols. (Anna Henningsen) #7641
PR-URL: #7782
@cjean-frcjean-fr mentioned this pull request Jul 24, 2016
Merged
lukesampson pushed a commit to ScoopInstaller/Scoop that referenced this pull request Jul 24, 2016
@cjean-fr@lukesampson
Upgrade node to 6.3.1 (#966)
0aaa69d
### Notable changes
* **buffer**:
* Improve performance of Buffer.from(str, 'hex') and Buffer#write(str, 'hex'). (Christopher Jeffrey) [#7602](nodejs/node#7602)
* Fix creating from zero-length ArrayBuffer. (Ingvar Stepanyan) [#7176](nodejs/node#7176)
* **deps**:
* Upgrade to V8 5.0.71.xx. (Ben Noordhuis) [#7531](nodejs/node#7531)
* Backport V8 instanceof bugfix (Franziska Hinkelmann) [#7638](nodejs/node#7638)
* **repl**: Fix issue with function redeclaration. (Prince J Wesley) [#7794](nodejs/node#7794)
* **util**: Fix inspecting of boxed symbols. (Anna Henningsen) [#7641](nodejs/node#7641)
MylesBorins pushed a commit that referenced this pull request Aug 30, 2016
@addaleaxMyles Borins
util: inspect boxed symbols like other primitives
7e60292
Inspect boxed symbol objects in the same way other boxed primitives
are inspected.
Fixes: #7639
PR-URL: #7641
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 28, 2016
@addaleaxMyles Borins
util: inspect boxed symbols like other primitives
ee3c955
Inspect boxed symbol objects in the same way other boxed primitives
are inspected.
Fixes: #7639
PR-URL: #7641
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
@addaleax@rvagg
util: inspect boxed symbols like other primitives
e3837e6
Inspect boxed symbol objects in the same way other boxed primitives
are inspected.
Fixes: #7639
PR-URL: #7641
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
@addaleax@MylesBorins
util: inspect boxed symbols like other primitives
f7796f2
Inspect boxed symbol objects in the same way other boxed primitives
are inspected.
Fixes: #7639
PR-URL: #7641
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Oct 26, 2016
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

utilIssues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@addaleax@targos@bnoordhuis@benjamingr@cjihrig@thefourtheye@MylesBorins