Uh oh!
There was an error while loading. Please reload this page.
src: don't use locale-sensitive strcasecmp() (v4.x) - #7660
Closed
bnoordhuis wants to merge 2 commits into
Closed
Conversation
MylesBorins
commented
Jul 11, 2016
Contributor
@bnoordhuis can you rebase against v4.x-staging one more time... had to rebase in a missing commit. Should be close enough a tree that the CI run is still relevant |
strcasecmp() is not used in src/node_http_parser.cc so there is no need to include its header file. PR-URL: nodejs#6582 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
strcasecmp() is affected by the current locale as configured through e.g. the LC_ALL environment variable and the setlocale() libc function. It can result in unpredictable results across systems so replace it with a function that isn't susceptible to that. PR-URL: nodejs#6582 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
bnoordhuisforce-pushed
the
backport-pr6582-v4.x
branch
from
July 11, 2016 22:04
e38bd13 to
aa8c48fComparebnoordhuis
commented
Jul 11, 2016
MemberAuthor
MylesBorins
commented
Jul 12, 2016
Contributor
landed in 583a80d...a881986 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R=@thealphanerd
CI: https://ci.nodejs.org/job/node-test-pull-request/3249/