eslintrc: rename files to an undeprecated format by thefourtheye · Pull Request #7699 · nodejs/node

thefourtheye · 2016-07-13T04:02:38Z

Checklist

make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
commit message follows commit guidelines

Affected core subsystem(s)

eslintrc

Description of change

As per ESLint documentation,
http://eslint.org/docs/user-guide/configuring#configuration-file-formats
the file format .eslintrc is deprecated. This patch renames the files
but retains the contents as the structure is already in yaml format.

cc @silverwind, @Trott

silverwind · 2016-07-13T05:34:42Z

-1 from me, I like the consise .eslintrc more, and dotfiles with extension seem kind of strange. The argument for these extensions was syntax highlighting in editors IIRC, but it's kind of weak I'd say. I'd keep using .eslintrc until ESLint drops support for ich which is probably never :)

Trott · 2016-07-13T05:59:17Z

/cc @ronkorving

Trott · 2016-07-13T06:03:01Z

LGTM (assuming CI lint job runs OK) but I don't feel strongly enough about it to argue in favor of it over @silverwind's objection. I'm interested to know if others have strong opinions one way or the other (and why).

targos · 2016-07-13T06:26:54Z

I am not against the change but I don't have any strong opinion.

ronkorving · 2016-07-13T08:14:59Z

I added YAML support to ESLint a while ago, which I believe was the trigger for the deprecation. For the sake of syntax highlighting, I think it makes sense to make the switch.

ChALkeR · 2016-07-13T10:25:53Z

+0 on this one. It does make sense, but I doubt that hard deprecation or removal of .eslintrc support would happen anytime soon.

cjihrig · 2016-07-13T13:05:51Z

No strong opinion, but I think it makes sense to use a non-deprecated format.

silverwind · 2016-07-13T20:01:30Z

Keep in mind that this change is likely to break some tooling, like for example my favorite Sublime Text plugin.

Also older related issue: #6131

ChALkeR · 2016-07-14T05:19:32Z

@silverwind

Keep in mind that this change is likely to break some tooling, like for example my favorite Sublime Text plugin.

Ow. Btw, does it have a corresponding issue reported?

silverwind · 2016-07-14T15:50:03Z

@ChALkeR: roadhump/SublimeLinter-contrib-eslint_d#12

Still, I'd say my point stands as there's likely more undiscovered tools out there with similar issues.

jasnell · 2016-07-29T16:45:23Z

hmm... perhaps we keep this open for a while then to see if some of the tools we know would break with this can be fixed first?

Like @cjihrig I don't have a strong opinion on this but in general it LGTM as long as we don't break too many people

thefourtheye · 2016-11-06T09:32:30Z

Hmmm, not sure why this needed a rebase, but I anyway did.

jasnell · 2017-01-06T20:04:21Z

Ping ..looks like it's out of sync again. @thefourtheye is this still something you want?

thefourtheye · 2017-01-10T17:09:50Z

@jasnell Rebased.

@not-an-aardvark What do you think?

not-an-aardvark · 2017-01-10T17:52:27Z

+1 because .eslintrc is deprecated, but I don't have a strong opinion on this.

thefourtheye · 2017-01-10T19:40:39Z

@silverwind Provided roadhump/SublimeLinter-contrib-eslint_d#13 hasn't landed yet, do you think we should halt this?

silverwind · 2017-01-10T22:38:27Z

Depends on how strongly we crave that syntax highlighting 🤣. I guess I'm fine with this change if you feel strong about this, but I don't really see a necessity unless ESLint drops support for the old filename.

thefourtheye · 2017-01-10T22:45:26Z

My motivation comes from the fact that, we expect our users to move away from core's deprecated stuff, we also should try to do the same with other products 😄

thefourtheye · 2017-01-18T04:20:35Z

Landed in 16e3cf6. Thanks for the review people :-)

As per ESLint documentation, http://eslint.org/docs/user-guide/configuring#configuration-file-formats the file format .eslintrc is deprecated. This patch just renames the files to .yaml and the structure is already in yaml format. PR-URL: #7699 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Rich Trott <rtrott@gmail.com>

As per ESLint documentation, http://eslint.org/docs/user-guide/configuring#configuration-file-formats the file format .eslintrc is deprecated. This patch just renames the files to .yaml and the structure is already in yaml format. PR-URL: nodejs#7699 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Rich Trott <rtrott@gmail.com>

As per ESLint documentation, http://eslint.org/docs/user-guide/configuring#configuration-file-formats the file format .eslintrc is deprecated. This patch just renames the files to .yaml and the structure is already in yaml format. PR-URL: #7699 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Rich Trott <rtrott@gmail.com>

.eslintrc was renamed in nodejs#7699 to .eslintrc.yaml. PR-URL: nodejs#12116 Refs: nodejs#7699 Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

.eslintrc was renamed in #7699 to .eslintrc.yaml. PR-URL: #12116 Refs: #7699 Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

.eslintrc was renamed in nodejs#7699 to .eslintrc.yaml. PR-URL: nodejs/node#12116 Refs: nodejs/node#7699 Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

mscdex added the tools Issues and PRs related to the tools directory. label Jul 13, 2016

thefourtheye force-pushed the eslint-deprecated-file-format branch from d2a8f99 to 18b905cCompare August 10, 2016 09:04

AdriVanHoudt mentioned this pull request Aug 17, 2016
Move .eslintrc to json or yaml #6131
Closed

Trott force-pushed the master branch from b0df363 to c5ce7f4Compare September 21, 2016 00:09

Trott mentioned this pull request Oct 4, 2016
Replace .eslintrc with something else? #8929
Closed

rvagg force-pushed the master branch 2 times, most recently from c133999 to 83c7a88Compare October 18, 2016 17:02

thefourtheye force-pushed the eslint-deprecated-file-format branch 2 times, most recently from e7dbc8e to 835b0e9Compare November 6, 2016 09:31

jasnell added the stalled Issues and PRs that are stalled. label Jan 6, 2017

thefourtheye force-pushed the eslint-deprecated-file-format branch from 835b0e9 to 72f013dCompare January 10, 2017 17:03

nodejs-github-bot added the dont-land-on-v7.x label Jan 10, 2017

thefourtheye closed this Jan 18, 2017

thefourtheye deleted the eslint-deprecated-file-format branch January 18, 2017 04:20

targos removed dont-land-on-v7.x stalled Issues and PRs that are stalled. labels Jan 28, 2017

italoacasas mentioned this pull request Jan 29, 2017
v7.5.0 proposal #11062
Merged

MylesBorins added land-on-v4.x labels Mar 8, 2017

MylesBorins mentioned this pull request Mar 9, 2017
v6.10.1 proposal #11759
Merged

MylesBorins mentioned this pull request Mar 9, 2017
v4.8.1 proposal #11760
Merged

targos mentioned this pull request Mar 29, 2017
tools: update dotfile whitelist in .gitignore #12116
Merged
1 task

hiroppy mentioned this pull request Feb 13, 2018
lint: rename .eslintrc to .eslintrc.yml expressjs/express#3561
Closed

Uh oh!

Uh oh!

Conversation

thefourtheye commented Jul 13, 2016

Checklist

Affected core subsystem(s)

Description of change

Uh oh!

silverwind commented Jul 13, 2016

Uh oh!

Trott commented Jul 13, 2016

Uh oh!

Trott commented Jul 13, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

targos commented Jul 13, 2016

Uh oh!

ronkorving commented Jul 13, 2016

Uh oh!

ChALkeR commented Jul 13, 2016

Uh oh!

cjihrig commented Jul 13, 2016

Uh oh!

silverwind commented Jul 13, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ChALkeR commented Jul 14, 2016

Uh oh!

silverwind commented Jul 14, 2016

Uh oh!

jasnell commented Jul 29, 2016

Uh oh!

thefourtheye commented Nov 6, 2016

Uh oh!

jasnell commented Jan 6, 2017

Uh oh!

thefourtheye commented Jan 10, 2017

Uh oh!

not-an-aardvark commented Jan 10, 2017

Uh oh!

thefourtheye commented Jan 10, 2017

Uh oh!

silverwind commented Jan 10, 2017

Uh oh!

thefourtheye commented Jan 10, 2017

Uh oh!

thefourtheye commented Jan 18, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants

Trott commented Jul 13, 2016•
edited
Loading

silverwind commented Jul 13, 2016•
edited
Loading