Uh oh!
There was an error while loading. Please reload this page.
doc: fix added: date for NODE_REPL_HISTORY - #7775
Conversation
`NODE_REPL_HISTORY` was introduced in v3.0.0 (see e.g. 6faf17c).
Fishrock123
commented
Jul 17, 2016
phillipj
commented
Jul 17, 2016
@Fishrock123 you're thinking of the cli label here? That's intentional as of nodejs/github-bot#47 |
Looks alright to me. EDIT: referring to the PR labeling |
cjihrig
commented
Jul 18, 2016
LGTM |
LGTM. BTW, are we okay backticks in commit messages? |
addaleax
commented
Jul 19, 2016
I think they are actually encouraged if their content would otherwise be parsed non-trivially by markdown parsers in the changelog (e.g. for words starting/ending with underscores)? |
They might be nice for changelog rendering, but I'd personally avoid them until GitHub decides to render them in the commit log (like they interestingly already do for |
addaleax
commented
Jul 19, 2016
I’d like to keep them, yeah. For me they make it easier to parse, even without markdown rendering. :) |
addaleax
commented
Jul 25, 2016
Landed in c67ec57 |
`NODE_REPL_HISTORY` was introduced in v3.0.0 (see e.g. 6faf17c). PR-URL: nodejs#7775 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
NODE_REPL_HISTORYwas introduced in v3.0.0 (see e.g. 6faf17c).I noticed this while doing the conflict resolution for the backport in #7677, and I think I wanted to PR that against master right then, but ended up correcting the version in the backport – sorry for that.