Uh oh!
There was an error while loading. Please reload this page.
Correcting misspelling - #7797
Closed
vitaly-t wants to merge 1 commit into
Closed
Conversation
Changing `stringp` to `string`.
cjihrig
commented
Jul 19, 2016
Contributor
LGTM |
3 similar comments
silverwind
commented
Jul 19, 2016
Contributor
LGTM |
JungMinu
commented
Jul 20, 2016
Member
LGTM |
thefourtheye
commented
Jul 20, 2016
Contributor
LGTM |
silverwind
commented
Jul 20, 2016
Contributor
Thanks! Landed in 74f0943. |
silverwind pushed a commit
that referenced
this pull request
Jul 20, 2016
Changing `stringp` to `string`. PR-URL: #7797 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
silverwind
commented
Jul 20, 2016
Contributor
The issue was introduced in 1b6a468, which doesn't seem to have landed on LTS yet. |
evanlucas pushed a commit
that referenced
this pull request
Jul 21, 2016
Changing `stringp` to `string`. PR-URL: #7797 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Description of change
Changing
stringptostring.