Uh oh!
There was an error while loading. Please reload this page.
src: remove unused IsInt64() function - #7839
Closed
cjihrig wants to merge 1 commit into
Closed
Conversation
The function IsInt64() in node_file.cc is no longer used, and was creating a warning at compile time. This commit removes the unused function.
cjihrig
commented
Jul 22, 2016
ContributorAuthor
mscdex
commented
Jul 22, 2016
Contributor
LGTM |
cjihrig
commented
Jul 23, 2016
ContributorAuthor
Note: If #7846 lands, then this function becomes used again. |
ChALkeR
commented
Jul 23, 2016
Member
Let's block this until there is a resolution on #7846. |
jasnell
commented
Aug 4, 2016
Member
cjihrig
commented
Aug 4, 2016
ContributorAuthor
I'm fine with leaving it open until there is a proper resolution one way or the other. |
cjihrig
commented
Aug 5, 2016
ContributorAuthor
This function is used again, as of c5a18e7. Closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
src
Description of change
The function
IsInt64()innode_file.ccis no longer used, and was creating a warning at compile time. This commit removes the unused function.