Skip to content

deps: cherry-pick b93c80a from v8 upstream - #7883

Closed
matthewloring wants to merge 4 commits into
nodejs:v4.x-stagingfrom
matthewloring:staging
Closed

deps: cherry-pick b93c80a from v8 upstream#7883
matthewloring wants to merge 4 commits into
nodejs:v4.x-stagingfrom
matthewloring:staging

Conversation

@matthewloring

@matthewloringmatthewloring commented Jul 26, 2016•
edited
Loading

Copy link
Copy Markdown
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

deps

Description of change

Original commit message:

If we can't rehash the backing store for weak sets & maps, do a last
resort GC

BUG=v8:4909
R=hpayer@chromium.org

Committed: https://crrev.com/b93c80a6039c757723e70420ae73375b5d277814
Cr-Commit-Position: refs/heads/master@{#37591}

@nodejs-github-botnodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Jul 26, 2016
@matthewloringmatthewloring mentioned this pull request Jul 26, 2016
Closed
2 tasks
@matthewloring

matthewloring commented Jul 26, 2016•
edited
Loading

Copy link
Copy Markdown
Author

/cc @thealphanerd@bnoordhuis@ofrobots

@mscdexmscdex added the v4.x label Jul 26, 2016
bnoordhuis
bnoordhuis reviewed Jul 27, 2016
View reviewed changes
Comment threaddeps/v8/src/heap/mark-compact.cc Outdated

@bnoordhuisbnoordhuisJul 27, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 25% doesn't seem right. If I read the code right, it's 50%.

(Mild sense of deja vu, maybe I've commented on it before.)

@matthewloringmatthewloringJul 27, 2016

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Original review: #6398 (comment)

@bnoordhuis

bnoordhuis commented Jul 27, 2016

Copy link
Copy Markdown
Member

LGTM with a question. Can you run both the node and the V8 CI?

@matthewloring

matthewloring commented Jul 27, 2016

Copy link
Copy Markdown
Author

CI: https://ci.nodejs.org/job/node-test-pull-request/3434/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/247/

@MylesBorins

MylesBorins commented Jul 27, 2016

Copy link
Copy Markdown
Contributor

is this important enough to roll into v4.5.0 or can it wait for the next patch release?

@matthewloring

matthewloring commented Jul 27, 2016

Copy link
Copy Markdown
Author

Waiting for the next patch release should be fine.

@ofrobotsofrobots mentioned this pull request Aug 1, 2016
Closed
2 tasks
@MylesBorins

MylesBorins commented Sep 4, 2016

Copy link
Copy Markdown
Contributor

@matthewloring would you be able to rebase this? We should be able to get it landed soon!

@MylesBorins

MylesBorins commented Oct 4, 2016

Copy link
Copy Markdown
Contributor

/cc @ofrobots @nodejs/v8 does this still need to be backported?

@bnoordhuis

bnoordhuis commented Oct 4, 2016

Copy link
Copy Markdown
Member

Yes, this should still be back-ported.

@MylesBorins

MylesBorins commented Oct 5, 2016

Copy link
Copy Markdown
Contributor

ping @matthewloring

ofrobotsand others added 4 commits October 5, 2016 14:06
@ofrobotsMatt Loring
deps: backport e093a04, 09db540 from upstream V8
e91f38b
Original commit messages:
v8/v8@e093a04
Rehash and clear deleted entries in weak collections during GC
Otherwise, they'll just keep growing until we run out of memory or hit the FixedArray's maximum capacity.
BUG=v8:4909
R=hpayer@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/1877233005
Cr-Commit-Position: refs/heads/master@{#35514}
v8/v8@09db540
Reland of Rehash and clear deleted entries in weak collections during GC
BUG=v8:4909
R=hpayer@chromium.org,ulan@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/1890123002
Cr-Commit-Position: refs/heads/master@{#35538}
V8-Bug: https://crbug.com/v8/4909Fixes: #6180
@ofrobotsMatt Loring
fixup needed for backport
9277ad6
Matt Loring
deps: cherry-pick b93c80a from v8 upstream
4945f61
Original commit message:
If we can't rehash the backing store for weak sets & maps, do a last
resort GC
BUG=v8:4909
R=hpayer@chromium.org
Committed: https://crrev.com/b93c80a6039c757723e70420ae73375b5d277814
Cr-Commit-Position: refs/heads/master@{#37591}
Fixes: #6180
PR-URL: #7689
Reviewed-By: Matt Loring <mattloring@google.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Matt Loring
deps: backport a76d133 from v8 upstream
132fc1e
Original commit message:
Fix incorrect parameter to HasSufficientCapacity
It takes the number of additional elements, not the total target
capacity.
Also, avoid right-shifting a negative integer as this is undefined in
general
BUG=v8:4909
R=verwaest@chromium.org
Review-Url: https://codereview.chromium.org/2162333002
Cr-Commit-Position: refs/heads/master@{#37901}
Fixes: #6180
PR-URL: #7689
Reviewed-By: Matt Loring <mattloring@google.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@matthewloring

matthewloring commented Oct 5, 2016

Copy link
Copy Markdown
Author

@thealphanerd rebased

@MylesBorins

MylesBorins commented Oct 7, 2016

Copy link
Copy Markdown
Contributor

Ci: https://ci.nodejs.org/job/node-test-pull-request/4422/

@MylesBorins

MylesBorins commented Oct 10, 2016

Copy link
Copy Markdown
Contributor

re running BSD: https://ci.nodejs.org/job/node-test-commit-freebsd/4719/
the windows failures are unrelated

MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
@ofrobotsMyles Borins
deps: backport e093a04, 09db540 from upstream V8
5ab6edd
Original commit messages:
v8/v8@e093a04
Rehash and clear deleted entries in weak collections during GC
Otherwise, they'll just keep growing until we run out of memory or hit the FixedArray's maximum capacity.
BUG=v8:4909
R=hpayer@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/1877233005
Cr-Commit-Position: refs/heads/master@{#35514}
v8/v8@09db540
Reland of Rehash and clear deleted entries in weak collections during GC
BUG=v8:4909
R=hpayer@chromium.org,ulan@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/1890123002
Cr-Commit-Position: refs/heads/master@{#35538}
Ref: https://crbug.com/v8/4909
Ref: #7883Fixes: #6180
PR-URL: #7689
Reviewed-By: Matt Loring <mattloring@google.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
Matt LoringMyles Borins
deps: cherry-pick b93c80a from v8 upstream
d664fbd
Original commit message:
If we can't rehash the backing store for weak sets & maps, do a last
resort GC
BUG=v8:4909
R=hpayer@chromium.org
Committed: https://crrev.com/b93c80a6039c757723e70420ae73375b5d277814
Cr-Commit-Position: refs/heads/master@{#37591}
Fixes: #6180
Ref: #7883
PR-URL: #7689
Reviewed-By: Matt Loring <mattloring@google.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
Matt LoringMyles Borins
deps: backport a76d133 from v8 upstream
32b2fb8
Original commit message:
Fix incorrect parameter to HasSufficientCapacity
It takes the number of additional elements, not the total target
capacity.
Also, avoid right-shifting a negative integer as this is undefined in
general
BUG=v8:4909
R=verwaest@chromium.org
Review-Url: https://codereview.chromium.org/2162333002
Cr-Commit-Position: refs/heads/master@{#37901}
Fixes: #6180
Ref: #7883
PR-URL: #7689
Reviewed-By: Matt Loring <mattloring@google.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@MylesBorins

MylesBorins commented Oct 10, 2016

Copy link
Copy Markdown
Contributor

failures are all unrelated to this PR, landing

d71dfdd...32b2fb8

MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
@ofrobotsMyles Borins
deps: backport e093a04, 09db540 from upstream V8
6b191f3
Original commit messages:
v8/v8@e093a04
Rehash and clear deleted entries in weak collections during GC
Otherwise, they'll just keep growing until we run out of memory or hit the FixedArray's maximum capacity.
BUG=v8:4909
R=hpayer@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/1877233005
Cr-Commit-Position: refs/heads/master@{#35514}
v8/v8@09db540
Reland of Rehash and clear deleted entries in weak collections during GC
BUG=v8:4909
R=hpayer@chromium.org,ulan@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/1890123002
Cr-Commit-Position: refs/heads/master@{#35538}
Ref: https://crbug.com/v8/4909
Ref: #7883Fixes: #6180
PR-URL: #7689
Reviewed-By: Matt Loring <mattloring@google.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
Matt LoringMyles Borins
deps: cherry-pick b93c80a from v8 upstream
2cfec2d
Original commit message:
If we can't rehash the backing store for weak sets & maps, do a last
resort GC
BUG=v8:4909
R=hpayer@chromium.org
Committed: https://crrev.com/b93c80a6039c757723e70420ae73375b5d277814
Cr-Commit-Position: refs/heads/master@{#37591}
Fixes: #6180
Ref: #7883
PR-URL: #7689
Reviewed-By: Matt Loring <mattloring@google.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
Matt LoringMyles Borins
deps: backport a76d133 from v8 upstream
b6692ba
Original commit message:
Fix incorrect parameter to HasSufficientCapacity
It takes the number of additional elements, not the total target
capacity.
Also, avoid right-shifting a negative integer as this is undefined in
general
BUG=v8:4909
R=verwaest@chromium.org
Review-Url: https://codereview.chromium.org/2162333002
Cr-Commit-Position: refs/heads/master@{#37901}
Fixes: #6180
Ref: #7883
PR-URL: #7689
Reviewed-By: Matt Loring <mattloring@google.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
@ofrobots@rvagg
deps: backport e093a04, 09db540 from upstream V8
74d37d0
Original commit messages:
v8/v8@e093a04
Rehash and clear deleted entries in weak collections during GC
Otherwise, they'll just keep growing until we run out of memory or hit the FixedArray's maximum capacity.
BUG=v8:4909
R=hpayer@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/1877233005
Cr-Commit-Position: refs/heads/master@{#35514}
v8/v8@09db540
Reland of Rehash and clear deleted entries in weak collections during GC
BUG=v8:4909
R=hpayer@chromium.org,ulan@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/1890123002
Cr-Commit-Position: refs/heads/master@{#35538}
Ref: https://crbug.com/v8/4909
Ref: #7883Fixes: #6180
PR-URL: #7689
Reviewed-By: Matt Loring <mattloring@google.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
Matt Loring@rvagg
deps: cherry-pick b93c80a from v8 upstream
492baa9
Original commit message:
If we can't rehash the backing store for weak sets & maps, do a last
resort GC
BUG=v8:4909
R=hpayer@chromium.org
Committed: https://crrev.com/b93c80a6039c757723e70420ae73375b5d277814
Cr-Commit-Position: refs/heads/master@{#37591}
Fixes: #6180
Ref: #7883
PR-URL: #7689
Reviewed-By: Matt Loring <mattloring@google.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
Matt Loring@rvagg
deps: backport a76d133 from v8 upstream
93e5381
Original commit message:
Fix incorrect parameter to HasSufficientCapacity
It takes the number of additional elements, not the total target
capacity.
Also, avoid right-shifting a negative integer as this is undefined in
general
BUG=v8:4909
R=verwaest@chromium.org
Review-Url: https://codereview.chromium.org/2162333002
Cr-Commit-Position: refs/heads/master@{#37901}
Fixes: #6180
Ref: #7883
PR-URL: #7689
Reviewed-By: Matt Loring <mattloring@google.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@matthewloring
matthewloring deleted the staging branch October 20, 2016 21:15
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
@ofrobots@MylesBorins
deps: backport e093a04, 09db540 from upstream V8
2d07fd7
Original commit messages:
v8/v8@e093a04
Rehash and clear deleted entries in weak collections during GC
Otherwise, they'll just keep growing until we run out of memory or hit the FixedArray's maximum capacity.
BUG=v8:4909
R=hpayer@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/1877233005
Cr-Commit-Position: refs/heads/master@{#35514}
v8/v8@09db540
Reland of Rehash and clear deleted entries in weak collections during GC
BUG=v8:4909
R=hpayer@chromium.org,ulan@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/1890123002
Cr-Commit-Position: refs/heads/master@{#35538}
Ref: https://crbug.com/v8/4909
Ref: #7883Fixes: #6180
PR-URL: #7689
Reviewed-By: Matt Loring <mattloring@google.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
Matt Loring@MylesBorins
deps: cherry-pick b93c80a from v8 upstream
e1f12fb
Original commit message:
If we can't rehash the backing store for weak sets & maps, do a last
resort GC
BUG=v8:4909
R=hpayer@chromium.org
Committed: https://crrev.com/b93c80a6039c757723e70420ae73375b5d277814
Cr-Commit-Position: refs/heads/master@{#37591}
Fixes: #6180
Ref: #7883
PR-URL: #7689
Reviewed-By: Matt Loring <mattloring@google.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
Matt Loring@MylesBorins
deps: backport a76d133 from v8 upstream
2b01bc8
Original commit message:
Fix incorrect parameter to HasSufficientCapacity
It takes the number of additional elements, not the total target
capacity.
Also, avoid right-shifting a negative integer as this is undefined in
general
BUG=v8:4909
R=verwaest@chromium.org
Review-Url: https://codereview.chromium.org/2162333002
Cr-Commit-Position: refs/heads/master@{#37901}
Fixes: #6180
Ref: #7883
PR-URL: #7689
Reviewed-By: Matt Loring <mattloring@google.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
BethGriggs pushed a commit to ibmruntimes/node that referenced this pull request Nov 9, 2016
@ofrobots@BethGriggs
deps: backport e093a04, 09db540 from upstream V8
b03629e
Original commit messages:
v8/v8@e093a04
Rehash and clear deleted entries in weak collections during GC
Otherwise, they'll just keep growing until we run out of memory or hit the FixedArray's maximum capacity.
BUG=v8:4909
R=hpayer@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/1877233005
Cr-Commit-Position: refs/heads/master@{#35514}
v8/v8@09db540
Reland of Rehash and clear deleted entries in weak collections during GC
BUG=v8:4909
R=hpayer@chromium.org,ulan@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/1890123002
Cr-Commit-Position: refs/heads/master@{#35538}
Ref: https://crbug.com/v8/4909
Ref: nodejs/node#7883Fixes: nodejs/node#6180
PR-URL: nodejs/node#7689
Reviewed-By: Matt Loring <mattloring@google.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
BethGriggs pushed a commit to ibmruntimes/node that referenced this pull request Nov 9, 2016
Matt Loring@BethGriggs
deps: cherry-pick b93c80a from v8 upstream
af2da0f
Original commit message:
If we can't rehash the backing store for weak sets & maps, do a last
resort GC
BUG=v8:4909
R=hpayer@chromium.org
Committed: https://crrev.com/b93c80a6039c757723e70420ae73375b5d277814
Cr-Commit-Position: refs/heads/master@{#37591}
Fixes: nodejs/node#6180
Ref: nodejs/node#7883
PR-URL: nodejs/node#7689
Reviewed-By: Matt Loring <mattloring@google.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
BethGriggs pushed a commit to ibmruntimes/node that referenced this pull request Nov 9, 2016
Matt Loring@BethGriggs
deps: backport a76d133 from v8 upstream
20aef57
Original commit message:
Fix incorrect parameter to HasSufficientCapacity
It takes the number of additional elements, not the total target
capacity.
Also, avoid right-shifting a negative integer as this is undefined in
general
BUG=v8:4909
R=verwaest@chromium.org
Review-Url: https://codereview.chromium.org/2162333002
Cr-Commit-Position: refs/heads/master@{#37901}
Fixes: nodejs/node#6180
Ref: nodejs/node#7883
PR-URL: nodejs/node#7689
Reviewed-By: Matt Loring <mattloring@google.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

v8 engineIssues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@matthewloring@bnoordhuis@MylesBorins@mscdex@nodejs-github-bot@ofrobots