deps: float gyp patch for long filenames - #7963

Closed
addaleax wants to merge 3 commits into
nodejs:masterfrom
addaleax:gyp-filename-float
Closed

deps: float gyp patch for long filenames#7963
addaleax wants to merge 3 commits into
nodejs:masterfrom
addaleax:gyp-filename-float

Conversation

@addaleax

@addaleaxaddaleax commented Aug 3, 2016

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

tools/gyp

Description of change

Pulling in https://codereview.chromium.org/2019133002/ in its current state, as gyp seems to be largely abandoned as a project.

Original commit message:

Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.

Concretely, this makes the V8 inspector build currently fail when long pathnames are involved, notably when using ecryptfs which has a lower file name length limit.

Fixes: #7959
Ref: #7510

@addaleax
deps: float gyp patch for long filenames
30a0d62
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: nodejs#7959
Ref: nodejs#7510
@addaleaxaddaleax added build Issues and PRs related to Node.js builds or CI infrastructure. tools Issues and PRs related to the tools directory. labels Aug 3, 2016
@addaleax

addaleax commented Aug 3, 2016

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-commit/4392/

/cc @bnoordhuis@thefourtheye

@addaleaxaddaleax mentioned this pull request Aug 3, 2016
Closed
@thefourtheye

thefourtheye commented Aug 3, 2016

Copy link
Copy Markdown
Contributor

LGTM

bnoordhuis
bnoordhuis reviewed Aug 3, 2016
View reviewed changes
Comment threadtools/gyp/pylib/gyp/generator/make.py Outdated

# Hash the target name to avoid generating overlong filenames.
cmddigest = _new_sha1(command if command else self.target).hexdigest()
intermediate = "%s.intermediate" % (cmddigest)

@bnoordhuisbnoordhuisAug 3, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick but the parens aren't necessary.

@bnoordhuis

bnoordhuis commented Aug 3, 2016

Copy link
Copy Markdown
Member

LGTM. Just curious, why did you name the variable _new_sha1 instead of e.g. sha1?

@addaleax

addaleax commented Aug 3, 2016

Copy link
Copy Markdown
MemberAuthor

That was copied from xcodeproj_file.py, too; I’m changing it, just sha1 sounds good to me too.

@thefourtheye

thefourtheye commented Aug 3, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

Actually, leading _ is correct, according to PEP-8. Quoting it,

Even with __all__ set appropriately, internal interfaces (packages, modules, classes, functions, attributes or other names) should still be prefixed with a single leading underscore.

@addaleax

addaleax commented Aug 3, 2016

Copy link
Copy Markdown
MemberAuthor

Sounds fine to me, I’ve left it and just dropped the extra parentheses.

@jasnell

jasnell commented Aug 3, 2016

Copy link
Copy Markdown
Member

LGTM

saghul
saghul reviewed Aug 4, 2016
View reviewed changes
Comment threadtools/gyp/pylib/gyp/generator/make.py Outdated
# available, avoiding a deprecation warning under 2.6. Import sha otherwise,
# preserving 2.4 compatibility.
try:
import hashlib

@saghulsaghulAug 4, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since GYP is kinda abandoned and you're floating the patch, you can remove all that and just import hashlib. Python 2.4 predates YouTube, keeping compatibility with that is insane these days.

@addaleaxaddaleaxAug 4, 2016

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saghul Done! :)

@saghul

saghul commented Aug 4, 2016

Copy link
Copy Markdown
Member

LGTM! 👍

@jasnell

jasnell commented Aug 5, 2016

Copy link
Copy Markdown
Member

There was red in the previous CI run that looks like a build bot failure. Trying again just to be safe... CI: https://ci.nodejs.org/job/node-test-pull-request/3543/

@addaleax

addaleax commented Aug 8, 2016

Copy link
Copy Markdown
MemberAuthor

CI again: https://ci.nodejs.org/job/node-test-commit/4458/

@addaleax

addaleax commented Aug 8, 2016•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Landed in 00dc41d0a033f5ea38953c73cf2fe23f4a8ce5775111e78 … I can finally build master without flags again! 🎉 😄

@addaleaxaddaleax closed this Aug 8, 2016
@addaleax
addaleax deleted the gyp-filename-float branch August 8, 2016 20:48
addaleax added a commit that referenced this pull request Aug 8, 2016
@addaleax
deps: float gyp patch for long filenames
5111e78
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: #7959
Ref: #7510
PR-URL: #7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
@cjihrigcjihrig mentioned this pull request Aug 10, 2016
Closed
cjihrig pushed a commit that referenced this pull request Aug 10, 2016
@addaleax@cjihrig
deps: float gyp patch for long filenames
3f46b5c
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: #7959
Ref: #7510
PR-URL: #7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
@cjihrigcjihrig mentioned this pull request Aug 11, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
@addaleaxMyles Borins
deps: float gyp patch for long filenames
a2804ed
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: #7959
Ref: #7510
PR-URL: #7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
@MylesBorins

MylesBorins commented Sep 30, 2016

Copy link
Copy Markdown
Contributor

@addaleax I've backported this to v4.x

please let me know if it shouldn't have been

@bnoordhuis

bnoordhuis commented Oct 8, 2016

Copy link
Copy Markdown
Member

@addaleax I just noticed, you never assigned a reviewer in https://codereview.chromium.org/2019133002, that's probably why it's still open. I'd try one of bradnelson@, mark@ or thakis@.

bnoordhuis pushed a commit to bnoordhuis/io.js that referenced this pull request Oct 8, 2016
@addaleax@bnoordhuis
deps: float gyp patch for long filenames
369b9d5
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: nodejs#7959
Ref: nodejs#7510
PR-URL: nodejs#7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
@addaleax@rvagg
deps: float gyp patch for long filenames
5d526fd
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: #7959
Ref: #7510
PR-URL: #7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
@addaleax@MylesBorins
deps: float gyp patch for long filenames
36b3ff0
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: #7959
Ref: #7510
PR-URL: #7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Oct 26, 2016
Closed
rvagg pushed a commit to nodejs/node-gyp that referenced this pull request Aug 9, 2018
@addaleax@rvagg
gyp: float gyp patch for long filenames
a265040
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: nodejs/node#7959
Ref: nodejs/node#7510
PR-URL: nodejs/node#7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
rvagg pushed a commit to nodejs/node-gyp that referenced this pull request Aug 9, 2018
@addaleax@rvagg
gyp: float gyp patch for long filenames
fc3c4e2
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: nodejs/node#7959
Ref: nodejs/node#7510
PR-URL: nodejs/node#7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

buildIssues and PRs related to Node.js builds or CI infrastructure.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@addaleax@thefourtheye@bnoordhuis@jasnell@saghul@MylesBorins
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
deps: float gyp patch for long filenames - #7963
Closed
addaleax wants to merge 3 commits into
nodejs:masterfrom 
addaleax:gyp-filename-float
Closed
deps: float gyp patch for long filenames#7963
addaleax wants to merge 3 commits into
nodejs:masterfrom 
addaleax:gyp-filename-float
Conversation
@addaleax
@addaleaxaddaleax
commented
Aug 3, 2016

Copy link


Copy Markdown

Member
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  •  commit message follows commit guidelines
Affected core subsystem(s)
tools/gyp
Description of change
Pulling in https://codereview.chromium.org/2019133002/ in its current state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.

Concretely, this makes the V8 inspector build currently fail when long pathnames are involved, notably when using ecryptfs which has a lower file name length limit.
Fixes: #7959

Ref: #7510
@addaleax
deps: float gyp patch for long filenames
30a0d62
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: nodejs#7959
Ref: nodejs#7510
@addaleaxaddaleax
added

build
Issues and PRs related to Node.js builds or CI infrastructure.
tools
Issues and PRs related to the tools directory.
labels
Aug 3, 2016
@addaleax
addaleax
commented
Aug 3, 2016

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-commit/4392/
/cc @bnoordhuis@thefourtheye
@addaleaxaddaleax
mentioned this pull request
Aug 3, 2016

Closed

@thefourtheye
thefourtheye
commented
Aug 3, 2016

Copy link


Copy Markdown

Contributor
LGTM
bnoordhuis
bnoordhuis
reviewed
Aug 3, 2016
 View reviewed changes

Comment threadtools/gyp/pylib/gyp/generator/make.py
Outdated


 # Hash the target name to avoid generating overlong filenames.
 cmddigest = _new_sha1(command if command else self.target).hexdigest()
 intermediate = "%s.intermediate" % (cmddigest)
@bnoordhuisbnoordhuisAug 3, 2016

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick but the parens aren't necessary.
@bnoordhuis
bnoordhuis
commented
Aug 3, 2016

Copy link


Copy Markdown

Member
LGTM. Just curious, why did you name the variable _new_sha1 instead of e.g. sha1?
@addaleax
addaleax
commented
Aug 3, 2016

Copy link


Copy Markdown

MemberAuthor
That was copied from xcodeproj_file.py, too; I’m changing it, just sha1 sounds good to me too.
@thefourtheye
thefourtheye
commented
Aug 3, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
Actually, leading _ is correct, according to PEP-8. Quoting it,
Even with __all__ set appropriately, internal interfaces (packages, modules, classes, functions, attributes or other names) should still be prefixed with a single leading underscore.
@addaleax
addaleax
commented
Aug 3, 2016

Copy link


Copy Markdown

MemberAuthor
Sounds fine to me, I’ve left it and just dropped the extra parentheses.
@jasnell
jasnell
commented
Aug 3, 2016

Copy link


Copy Markdown

Member
LGTM
saghul
saghul
reviewed
Aug 4, 2016
 View reviewed changes

Comment threadtools/gyp/pylib/gyp/generator/make.py
Outdated

# available, avoiding a deprecation warning under 2.6. Import sha otherwise,
# preserving 2.4 compatibility.
try:
 import hashlib
@saghulsaghulAug 4, 2016

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since GYP is kinda abandoned and you're floating the patch, you can remove all that and just import hashlib. Python 2.4 predates YouTube, keeping compatibility with that is insane these days.
@addaleaxaddaleaxAug 4, 2016

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saghul Done! :)
@saghul
saghul
commented
Aug 4, 2016

Copy link


Copy Markdown

Member
LGTM! 👍
@jasnell
jasnell
commented
Aug 5, 2016

Copy link


Copy Markdown

Member
There was red in the previous CI run that looks like a build bot failure. Trying again just to be safe... CI: https://ci.nodejs.org/job/node-test-pull-request/3543/
@addaleax
addaleax
commented
Aug 8, 2016

Copy link


Copy Markdown

MemberAuthor
CI again: https://ci.nodejs.org/job/node-test-commit/4458/
@addaleax
addaleax
commented
Aug 8, 2016•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Landed in 00dc41d0a033f5ea38953c73cf2fe23f4a8ce5775111e78 … I can finally build master without flags again! 🎉 😄
@addaleaxaddaleax
closed this
Aug 8, 2016
@addaleax
addaleax
deleted the

gyp-filename-float

branch
August 8, 2016 20:48
addaleax added a commit
that referenced
this pull request
Aug 8, 2016
@addaleax
deps: float gyp patch for long filenames
5111e78
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: #7959
Ref: #7510
PR-URL: #7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
@cjihrigcjihrig
mentioned this pull request
Aug 10, 2016

Closed

cjihrig pushed a commit
that referenced
this pull request
Aug 10, 2016
@addaleax@cjihrig
deps: float gyp patch for long filenames
3f46b5c
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: #7959
Ref: #7510
PR-URL: #7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
@cjihrigcjihrig
mentioned this pull request
Aug 11, 2016
 Merged

MylesBorins pushed a commit
that referenced
this pull request
Sep 30, 2016
@addaleaxMyles Borins
deps: float gyp patch for long filenames
a2804ed
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: #7959
Ref: #7510
PR-URL: #7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
@MylesBorins
MylesBorins
commented
Sep 30, 2016

Copy link


Copy Markdown

Contributor
@addaleax I've backported this to v4.x
please let me know if it shouldn't have been
@bnoordhuis
bnoordhuis
commented
Oct 8, 2016

Copy link


Copy Markdown

Member
@addaleax I just noticed, you never assigned a reviewer in https://codereview.chromium.org/2019133002, that's probably why it's still open. I'd try one of bradnelson@, mark@ or thakis@.
bnoordhuis pushed a commit
to bnoordhuis/io.js
that referenced
this pull request
Oct 8, 2016
@addaleax@bnoordhuis
deps: float gyp patch for long filenames
369b9d5
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: nodejs#7959
Ref: nodejs#7510
PR-URL: nodejs#7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
rvagg pushed a commit
that referenced
this pull request
Oct 18, 2016
@addaleax@rvagg
deps: float gyp patch for long filenames
5d526fd
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: #7959
Ref: #7510
PR-URL: #7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Oct 26, 2016
@addaleax@MylesBorins
deps: float gyp patch for long filenames
36b3ff0
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: #7959
Ref: #7510
PR-URL: #7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
@MylesBorinsMylesBorins
mentioned this pull request
Oct 26, 2016
 Closed

rvagg pushed a commit
to nodejs/node-gyp
that referenced
this pull request
Aug 9, 2018
@addaleax@rvagg
gyp: float gyp patch for long filenames
a265040
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: nodejs/node#7959
Ref: nodejs/node#7510
PR-URL: nodejs/node#7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
rvagg pushed a commit
to nodejs/node-gyp
that referenced
this pull request
Aug 9, 2018
@addaleax@rvagg
gyp: float gyp patch for long filenames
fc3c4e2
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: nodejs/node#7959
Ref: nodejs/node#7510
PR-URL: nodejs/node#7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

buildIssues and PRs related to Node.js builds or CI infrastructure.toolsIssues and PRs related to the tools directory.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@addaleax@thefourtheye@bnoordhuis@jasnell@saghul@MylesBorins

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
deps: float gyp patch for long filenames - #7963
Closed
addaleax wants to merge 3 commits into
nodejs:masterfrom 
addaleax:gyp-filename-float
Closed
deps: float gyp patch for long filenames#7963
addaleax wants to merge 3 commits into
nodejs:masterfrom 
addaleax:gyp-filename-float
Conversation
@addaleax
@addaleaxaddaleax
commented
Aug 3, 2016

Copy link


Copy Markdown

Member
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  •  commit message follows commit guidelines
Affected core subsystem(s)
tools/gyp
Description of change
Pulling in https://codereview.chromium.org/2019133002/ in its current state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.

Concretely, this makes the V8 inspector build currently fail when long pathnames are involved, notably when using ecryptfs which has a lower file name length limit.
Fixes: #7959

Ref: #7510
@addaleax
deps: float gyp patch for long filenames
30a0d62
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: nodejs#7959
Ref: nodejs#7510
@addaleaxaddaleax
added

build
Issues and PRs related to Node.js builds or CI infrastructure.
tools
Issues and PRs related to the tools directory.
labels
Aug 3, 2016
@addaleax
addaleax
commented
Aug 3, 2016

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-commit/4392/
/cc @bnoordhuis@thefourtheye
@addaleaxaddaleax
mentioned this pull request
Aug 3, 2016

Closed

@thefourtheye
thefourtheye
commented
Aug 3, 2016

Copy link


Copy Markdown

Contributor
LGTM
bnoordhuis
bnoordhuis
reviewed
Aug 3, 2016
 View reviewed changes

Comment threadtools/gyp/pylib/gyp/generator/make.py
Outdated


 # Hash the target name to avoid generating overlong filenames.
 cmddigest = _new_sha1(command if command else self.target).hexdigest()
 intermediate = "%s.intermediate" % (cmddigest)
@bnoordhuisbnoordhuisAug 3, 2016

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick but the parens aren't necessary.
@bnoordhuis
bnoordhuis
commented
Aug 3, 2016

Copy link


Copy Markdown

Member
LGTM. Just curious, why did you name the variable _new_sha1 instead of e.g. sha1?
@addaleax
addaleax
commented
Aug 3, 2016

Copy link


Copy Markdown

MemberAuthor
That was copied from xcodeproj_file.py, too; I’m changing it, just sha1 sounds good to me too.
@thefourtheye
thefourtheye
commented
Aug 3, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
Actually, leading _ is correct, according to PEP-8. Quoting it,
Even with __all__ set appropriately, internal interfaces (packages, modules, classes, functions, attributes or other names) should still be prefixed with a single leading underscore.
@addaleax
addaleax
commented
Aug 3, 2016

Copy link


Copy Markdown

MemberAuthor
Sounds fine to me, I’ve left it and just dropped the extra parentheses.
@jasnell
jasnell
commented
Aug 3, 2016

Copy link


Copy Markdown

Member
LGTM
saghul
saghul
reviewed
Aug 4, 2016
 View reviewed changes

Comment threadtools/gyp/pylib/gyp/generator/make.py
Outdated

# available, avoiding a deprecation warning under 2.6. Import sha otherwise,
# preserving 2.4 compatibility.
try:
 import hashlib
@saghulsaghulAug 4, 2016

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since GYP is kinda abandoned and you're floating the patch, you can remove all that and just import hashlib. Python 2.4 predates YouTube, keeping compatibility with that is insane these days.
@addaleaxaddaleaxAug 4, 2016

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saghul Done! :)
@saghul
saghul
commented
Aug 4, 2016

Copy link


Copy Markdown

Member
LGTM! 👍
@jasnell
jasnell
commented
Aug 5, 2016

Copy link


Copy Markdown

Member
There was red in the previous CI run that looks like a build bot failure. Trying again just to be safe... CI: https://ci.nodejs.org/job/node-test-pull-request/3543/
@addaleax
addaleax
commented
Aug 8, 2016

Copy link


Copy Markdown

MemberAuthor
CI again: https://ci.nodejs.org/job/node-test-commit/4458/
@addaleax
addaleax
commented
Aug 8, 2016•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Landed in 00dc41d0a033f5ea38953c73cf2fe23f4a8ce5775111e78 … I can finally build master without flags again! 🎉 😄
@addaleaxaddaleax
closed this
Aug 8, 2016
@addaleax
addaleax
deleted the

gyp-filename-float

branch
August 8, 2016 20:48
addaleax added a commit
that referenced
this pull request
Aug 8, 2016
@addaleax
deps: float gyp patch for long filenames
5111e78
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: #7959
Ref: #7510
PR-URL: #7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
@cjihrigcjihrig
mentioned this pull request
Aug 10, 2016

Closed

cjihrig pushed a commit
that referenced
this pull request
Aug 10, 2016
@addaleax@cjihrig
deps: float gyp patch for long filenames
3f46b5c
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: #7959
Ref: #7510
PR-URL: #7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
@cjihrigcjihrig
mentioned this pull request
Aug 11, 2016
 Merged

MylesBorins pushed a commit
that referenced
this pull request
Sep 30, 2016
@addaleaxMyles Borins
deps: float gyp patch for long filenames
a2804ed
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: #7959
Ref: #7510
PR-URL: #7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
@MylesBorins
MylesBorins
commented
Sep 30, 2016

Copy link


Copy Markdown

Contributor
@addaleax I've backported this to v4.x
please let me know if it shouldn't have been
@bnoordhuis
bnoordhuis
commented
Oct 8, 2016

Copy link


Copy Markdown

Member
@addaleax I just noticed, you never assigned a reviewer in https://codereview.chromium.org/2019133002, that's probably why it's still open. I'd try one of bradnelson@, mark@ or thakis@.
bnoordhuis pushed a commit
to bnoordhuis/io.js
that referenced
this pull request
Oct 8, 2016
@addaleax@bnoordhuis
deps: float gyp patch for long filenames
369b9d5
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: nodejs#7959
Ref: nodejs#7510
PR-URL: nodejs#7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
rvagg pushed a commit
that referenced
this pull request
Oct 18, 2016
@addaleax@rvagg
deps: float gyp patch for long filenames
5d526fd
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: #7959
Ref: #7510
PR-URL: #7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Oct 26, 2016
@addaleax@MylesBorins
deps: float gyp patch for long filenames
36b3ff0
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: #7959
Ref: #7510
PR-URL: #7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
@MylesBorinsMylesBorins
mentioned this pull request
Oct 26, 2016
 Closed

rvagg pushed a commit
to nodejs/node-gyp
that referenced
this pull request
Aug 9, 2018
@addaleax@rvagg
gyp: float gyp patch for long filenames
a265040
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: nodejs/node#7959
Ref: nodejs/node#7510
PR-URL: nodejs/node#7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
rvagg pushed a commit
to nodejs/node-gyp
that referenced
this pull request
Aug 9, 2018
@addaleax@rvagg
gyp: float gyp patch for long filenames
fc3c4e2
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: nodejs/node#7959
Ref: nodejs/node#7510
PR-URL: nodejs/node#7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

buildIssues and PRs related to Node.js builds or CI infrastructure.toolsIssues and PRs related to the tools directory.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@addaleax@thefourtheye@bnoordhuis@jasnell@saghul@MylesBorins

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
deps: float gyp patch for long filenames - #7963
Closed
addaleax wants to merge 3 commits into
nodejs:masterfrom 
addaleax:gyp-filename-float
Closed
deps: float gyp patch for long filenames#7963
addaleax wants to merge 3 commits into
nodejs:masterfrom 
addaleax:gyp-filename-float
Conversation
@addaleax
@addaleaxaddaleax
commented
Aug 3, 2016

Copy link


Copy Markdown

Member
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  •  commit message follows commit guidelines
Affected core subsystem(s)
tools/gyp
Description of change
Pulling in https://codereview.chromium.org/2019133002/ in its current state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.

Concretely, this makes the V8 inspector build currently fail when long pathnames are involved, notably when using ecryptfs which has a lower file name length limit.
Fixes: #7959

Ref: #7510
@addaleax
deps: float gyp patch for long filenames
30a0d62
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: nodejs#7959
Ref: nodejs#7510
@addaleaxaddaleax
added

build
Issues and PRs related to Node.js builds or CI infrastructure.
tools
Issues and PRs related to the tools directory.
labels
Aug 3, 2016
@addaleax
addaleax
commented
Aug 3, 2016

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-commit/4392/
/cc @bnoordhuis@thefourtheye
@addaleaxaddaleax
mentioned this pull request
Aug 3, 2016

Closed

@thefourtheye
thefourtheye
commented
Aug 3, 2016

Copy link


Copy Markdown

Contributor
LGTM
bnoordhuis
bnoordhuis
reviewed
Aug 3, 2016
 View reviewed changes

Comment threadtools/gyp/pylib/gyp/generator/make.py
Outdated


 # Hash the target name to avoid generating overlong filenames.
 cmddigest = _new_sha1(command if command else self.target).hexdigest()
 intermediate = "%s.intermediate" % (cmddigest)
@bnoordhuisbnoordhuisAug 3, 2016

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick but the parens aren't necessary.
@bnoordhuis
bnoordhuis
commented
Aug 3, 2016

Copy link


Copy Markdown

Member
LGTM. Just curious, why did you name the variable _new_sha1 instead of e.g. sha1?
@addaleax
addaleax
commented
Aug 3, 2016

Copy link


Copy Markdown

MemberAuthor
That was copied from xcodeproj_file.py, too; I’m changing it, just sha1 sounds good to me too.
@thefourtheye
thefourtheye
commented
Aug 3, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
Actually, leading _ is correct, according to PEP-8. Quoting it,
Even with __all__ set appropriately, internal interfaces (packages, modules, classes, functions, attributes or other names) should still be prefixed with a single leading underscore.
@addaleax
addaleax
commented
Aug 3, 2016

Copy link


Copy Markdown

MemberAuthor
Sounds fine to me, I’ve left it and just dropped the extra parentheses.
@jasnell
jasnell
commented
Aug 3, 2016

Copy link


Copy Markdown

Member
LGTM
saghul
saghul
reviewed
Aug 4, 2016
 View reviewed changes

Comment threadtools/gyp/pylib/gyp/generator/make.py
Outdated

# available, avoiding a deprecation warning under 2.6. Import sha otherwise,
# preserving 2.4 compatibility.
try:
 import hashlib
@saghulsaghulAug 4, 2016

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since GYP is kinda abandoned and you're floating the patch, you can remove all that and just import hashlib. Python 2.4 predates YouTube, keeping compatibility with that is insane these days.
@addaleaxaddaleaxAug 4, 2016

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saghul Done! :)
@saghul
saghul
commented
Aug 4, 2016

Copy link


Copy Markdown

Member
LGTM! 👍
@jasnell
jasnell
commented
Aug 5, 2016

Copy link


Copy Markdown

Member
There was red in the previous CI run that looks like a build bot failure. Trying again just to be safe... CI: https://ci.nodejs.org/job/node-test-pull-request/3543/
@addaleax
addaleax
commented
Aug 8, 2016

Copy link


Copy Markdown

MemberAuthor
CI again: https://ci.nodejs.org/job/node-test-commit/4458/
@addaleax
addaleax
commented
Aug 8, 2016•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Landed in 00dc41d0a033f5ea38953c73cf2fe23f4a8ce5775111e78 … I can finally build master without flags again! 🎉 😄
@addaleaxaddaleax
closed this
Aug 8, 2016
@addaleax
addaleax
deleted the

gyp-filename-float

branch
August 8, 2016 20:48
addaleax added a commit
that referenced
this pull request
Aug 8, 2016
@addaleax
deps: float gyp patch for long filenames
5111e78
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: #7959
Ref: #7510
PR-URL: #7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
@cjihrigcjihrig
mentioned this pull request
Aug 10, 2016

Closed

cjihrig pushed a commit
that referenced
this pull request
Aug 10, 2016
@addaleax@cjihrig
deps: float gyp patch for long filenames
3f46b5c
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: #7959
Ref: #7510
PR-URL: #7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
@cjihrigcjihrig
mentioned this pull request
Aug 11, 2016
 Merged

MylesBorins pushed a commit
that referenced
this pull request
Sep 30, 2016
@addaleaxMyles Borins
deps: float gyp patch for long filenames
a2804ed
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: #7959
Ref: #7510
PR-URL: #7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
@MylesBorins
MylesBorins
commented
Sep 30, 2016

Copy link


Copy Markdown

Contributor
@addaleax I've backported this to v4.x
please let me know if it shouldn't have been
@bnoordhuis
bnoordhuis
commented
Oct 8, 2016

Copy link


Copy Markdown

Member
@addaleax I just noticed, you never assigned a reviewer in https://codereview.chromium.org/2019133002, that's probably why it's still open. I'd try one of bradnelson@, mark@ or thakis@.
bnoordhuis pushed a commit
to bnoordhuis/io.js
that referenced
this pull request
Oct 8, 2016
@addaleax@bnoordhuis
deps: float gyp patch for long filenames
369b9d5
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: nodejs#7959
Ref: nodejs#7510
PR-URL: nodejs#7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
rvagg pushed a commit
that referenced
this pull request
Oct 18, 2016
@addaleax@rvagg
deps: float gyp patch for long filenames
5d526fd
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: #7959
Ref: #7510
PR-URL: #7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Oct 26, 2016
@addaleax@MylesBorins
deps: float gyp patch for long filenames
36b3ff0
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: #7959
Ref: #7510
PR-URL: #7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
@MylesBorinsMylesBorins
mentioned this pull request
Oct 26, 2016
 Closed

rvagg pushed a commit
to nodejs/node-gyp
that referenced
this pull request
Aug 9, 2018
@addaleax@rvagg
gyp: float gyp patch for long filenames
a265040
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: nodejs/node#7959
Ref: nodejs/node#7510
PR-URL: nodejs/node#7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
rvagg pushed a commit
to nodejs/node-gyp
that referenced
this pull request
Aug 9, 2018
@addaleax@rvagg
gyp: float gyp patch for long filenames
fc3c4e2
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: nodejs/node#7959
Ref: nodejs/node#7510
PR-URL: nodejs/node#7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

buildIssues and PRs related to Node.js builds or CI infrastructure.toolsIssues and PRs related to the tools directory.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@addaleax@thefourtheye@bnoordhuis@jasnell@saghul@MylesBorins

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
deps: float gyp patch for long filenames - #7963
Closed
addaleax wants to merge 3 commits into
nodejs:masterfrom 
addaleax:gyp-filename-float
Closed
deps: float gyp patch for long filenames#7963
addaleax wants to merge 3 commits into
nodejs:masterfrom 
addaleax:gyp-filename-float
Conversation
@addaleax
@addaleaxaddaleax
commented
Aug 3, 2016

Copy link


Copy Markdown

Member
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  •  commit message follows commit guidelines
Affected core subsystem(s)
tools/gyp
Description of change
Pulling in https://codereview.chromium.org/2019133002/ in its current state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.

Concretely, this makes the V8 inspector build currently fail when long pathnames are involved, notably when using ecryptfs which has a lower file name length limit.
Fixes: #7959

Ref: #7510
@addaleax
deps: float gyp patch for long filenames
30a0d62
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: nodejs#7959
Ref: nodejs#7510
@addaleaxaddaleax
added

build
Issues and PRs related to Node.js builds or CI infrastructure.
tools
Issues and PRs related to the tools directory.
labels
Aug 3, 2016
@addaleax
addaleax
commented
Aug 3, 2016

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-commit/4392/
/cc @bnoordhuis@thefourtheye
@addaleaxaddaleax
mentioned this pull request
Aug 3, 2016

Closed

@thefourtheye
thefourtheye
commented
Aug 3, 2016

Copy link


Copy Markdown

Contributor
LGTM
bnoordhuis
bnoordhuis
reviewed
Aug 3, 2016
 View reviewed changes

Comment threadtools/gyp/pylib/gyp/generator/make.py
Outdated


 # Hash the target name to avoid generating overlong filenames.
 cmddigest = _new_sha1(command if command else self.target).hexdigest()
 intermediate = "%s.intermediate" % (cmddigest)
@bnoordhuisbnoordhuisAug 3, 2016

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick but the parens aren't necessary.
@bnoordhuis
bnoordhuis
commented
Aug 3, 2016

Copy link


Copy Markdown

Member
LGTM. Just curious, why did you name the variable _new_sha1 instead of e.g. sha1?
@addaleax
addaleax
commented
Aug 3, 2016

Copy link


Copy Markdown

MemberAuthor
That was copied from xcodeproj_file.py, too; I’m changing it, just sha1 sounds good to me too.
@thefourtheye
thefourtheye
commented
Aug 3, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
Actually, leading _ is correct, according to PEP-8. Quoting it,
Even with __all__ set appropriately, internal interfaces (packages, modules, classes, functions, attributes or other names) should still be prefixed with a single leading underscore.
@addaleax
addaleax
commented
Aug 3, 2016

Copy link


Copy Markdown

MemberAuthor
Sounds fine to me, I’ve left it and just dropped the extra parentheses.
@jasnell
jasnell
commented
Aug 3, 2016

Copy link


Copy Markdown

Member
LGTM
saghul
saghul
reviewed
Aug 4, 2016
 View reviewed changes

Comment threadtools/gyp/pylib/gyp/generator/make.py
Outdated

# available, avoiding a deprecation warning under 2.6. Import sha otherwise,
# preserving 2.4 compatibility.
try:
 import hashlib
@saghulsaghulAug 4, 2016

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since GYP is kinda abandoned and you're floating the patch, you can remove all that and just import hashlib. Python 2.4 predates YouTube, keeping compatibility with that is insane these days.
@addaleaxaddaleaxAug 4, 2016

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saghul Done! :)
@saghul
saghul
commented
Aug 4, 2016

Copy link


Copy Markdown

Member
LGTM! 👍
@jasnell
jasnell
commented
Aug 5, 2016

Copy link


Copy Markdown

Member
There was red in the previous CI run that looks like a build bot failure. Trying again just to be safe... CI: https://ci.nodejs.org/job/node-test-pull-request/3543/
@addaleax
addaleax
commented
Aug 8, 2016

Copy link


Copy Markdown

MemberAuthor
CI again: https://ci.nodejs.org/job/node-test-commit/4458/
@addaleax
addaleax
commented
Aug 8, 2016•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Landed in 00dc41d0a033f5ea38953c73cf2fe23f4a8ce5775111e78 … I can finally build master without flags again! 🎉 😄
@addaleaxaddaleax
closed this
Aug 8, 2016
@addaleax
addaleax
deleted the

gyp-filename-float

branch
August 8, 2016 20:48
addaleax added a commit
that referenced
this pull request
Aug 8, 2016
@addaleax
deps: float gyp patch for long filenames
5111e78
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: #7959
Ref: #7510
PR-URL: #7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
@cjihrigcjihrig
mentioned this pull request
Aug 10, 2016

Closed

cjihrig pushed a commit
that referenced
this pull request
Aug 10, 2016
@addaleax@cjihrig
deps: float gyp patch for long filenames
3f46b5c
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: #7959
Ref: #7510
PR-URL: #7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
@cjihrigcjihrig
mentioned this pull request
Aug 11, 2016
 Merged

MylesBorins pushed a commit
that referenced
this pull request
Sep 30, 2016
@addaleaxMyles Borins
deps: float gyp patch for long filenames
a2804ed
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: #7959
Ref: #7510
PR-URL: #7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
@MylesBorins
MylesBorins
commented
Sep 30, 2016

Copy link


Copy Markdown

Contributor
@addaleax I've backported this to v4.x
please let me know if it shouldn't have been
@bnoordhuis
bnoordhuis
commented
Oct 8, 2016

Copy link


Copy Markdown

Member
@addaleax I just noticed, you never assigned a reviewer in https://codereview.chromium.org/2019133002, that's probably why it's still open. I'd try one of bradnelson@, mark@ or thakis@.
bnoordhuis pushed a commit
to bnoordhuis/io.js
that referenced
this pull request
Oct 8, 2016
@addaleax@bnoordhuis
deps: float gyp patch for long filenames
369b9d5
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: nodejs#7959
Ref: nodejs#7510
PR-URL: nodejs#7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
rvagg pushed a commit
that referenced
this pull request
Oct 18, 2016
@addaleax@rvagg
deps: float gyp patch for long filenames
5d526fd
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: #7959
Ref: #7510
PR-URL: #7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Oct 26, 2016
@addaleax@MylesBorins
deps: float gyp patch for long filenames
36b3ff0
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: #7959
Ref: #7510
PR-URL: #7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
@MylesBorinsMylesBorins
mentioned this pull request
Oct 26, 2016
 Closed

rvagg pushed a commit
to nodejs/node-gyp
that referenced
this pull request
Aug 9, 2018
@addaleax@rvagg
gyp: float gyp patch for long filenames
a265040
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: nodejs/node#7959
Ref: nodejs/node#7510
PR-URL: nodejs/node#7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
rvagg pushed a commit
to nodejs/node-gyp
that referenced
this pull request
Aug 9, 2018
@addaleax@rvagg
gyp: float gyp patch for long filenames
fc3c4e2
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: nodejs/node#7959
Ref: nodejs/node#7510
PR-URL: nodejs/node#7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

buildIssues and PRs related to Node.js builds or CI infrastructure.toolsIssues and PRs related to the tools directory.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@addaleax@thefourtheye@bnoordhuis@jasnell@saghul@MylesBorins

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
deps: float gyp patch for long filenames - #7963
Closed
addaleax wants to merge 3 commits into
nodejs:masterfrom 
addaleax:gyp-filename-float
Closed
deps: float gyp patch for long filenames#7963
addaleax wants to merge 3 commits into
nodejs:masterfrom 
addaleax:gyp-filename-float
Conversation
@addaleax
@addaleaxaddaleax
commented
Aug 3, 2016

Copy link


Copy Markdown

Member
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  •  commit message follows commit guidelines
Affected core subsystem(s)
tools/gyp
Description of change
Pulling in https://codereview.chromium.org/2019133002/ in its current state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.

Concretely, this makes the V8 inspector build currently fail when long pathnames are involved, notably when using ecryptfs which has a lower file name length limit.
Fixes: #7959

Ref: #7510
@addaleax
deps: float gyp patch for long filenames
30a0d62
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: nodejs#7959
Ref: nodejs#7510
@addaleaxaddaleax
added

build
Issues and PRs related to Node.js builds or CI infrastructure.
tools
Issues and PRs related to the tools directory.
labels
Aug 3, 2016
@addaleax
addaleax
commented
Aug 3, 2016

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-commit/4392/
/cc @bnoordhuis@thefourtheye
@addaleaxaddaleax
mentioned this pull request
Aug 3, 2016

Closed

@thefourtheye
thefourtheye
commented
Aug 3, 2016

Copy link


Copy Markdown

Contributor
LGTM
bnoordhuis
bnoordhuis
reviewed
Aug 3, 2016
 View reviewed changes

Comment threadtools/gyp/pylib/gyp/generator/make.py
Outdated


 # Hash the target name to avoid generating overlong filenames.
 cmddigest = _new_sha1(command if command else self.target).hexdigest()
 intermediate = "%s.intermediate" % (cmddigest)
@bnoordhuisbnoordhuisAug 3, 2016

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick but the parens aren't necessary.
@bnoordhuis
bnoordhuis
commented
Aug 3, 2016

Copy link


Copy Markdown

Member
LGTM. Just curious, why did you name the variable _new_sha1 instead of e.g. sha1?
@addaleax
addaleax
commented
Aug 3, 2016

Copy link


Copy Markdown

MemberAuthor
That was copied from xcodeproj_file.py, too; I’m changing it, just sha1 sounds good to me too.
@thefourtheye
thefourtheye
commented
Aug 3, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
Actually, leading _ is correct, according to PEP-8. Quoting it,
Even with __all__ set appropriately, internal interfaces (packages, modules, classes, functions, attributes or other names) should still be prefixed with a single leading underscore.
@addaleax
addaleax
commented
Aug 3, 2016

Copy link


Copy Markdown

MemberAuthor
Sounds fine to me, I’ve left it and just dropped the extra parentheses.
@jasnell
jasnell
commented
Aug 3, 2016

Copy link


Copy Markdown

Member
LGTM
saghul
saghul
reviewed
Aug 4, 2016
 View reviewed changes

Comment threadtools/gyp/pylib/gyp/generator/make.py
Outdated

# available, avoiding a deprecation warning under 2.6. Import sha otherwise,
# preserving 2.4 compatibility.
try:
 import hashlib
@saghulsaghulAug 4, 2016

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since GYP is kinda abandoned and you're floating the patch, you can remove all that and just import hashlib. Python 2.4 predates YouTube, keeping compatibility with that is insane these days.
@addaleaxaddaleaxAug 4, 2016

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saghul Done! :)
@saghul
saghul
commented
Aug 4, 2016

Copy link


Copy Markdown

Member
LGTM! 👍
@jasnell
jasnell
commented
Aug 5, 2016

Copy link


Copy Markdown

Member
There was red in the previous CI run that looks like a build bot failure. Trying again just to be safe... CI: https://ci.nodejs.org/job/node-test-pull-request/3543/
@addaleax
addaleax
commented
Aug 8, 2016

Copy link


Copy Markdown

MemberAuthor
CI again: https://ci.nodejs.org/job/node-test-commit/4458/
@addaleax
addaleax
commented
Aug 8, 2016•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Landed in 00dc41d0a033f5ea38953c73cf2fe23f4a8ce5775111e78 … I can finally build master without flags again! 🎉 😄
@addaleaxaddaleax
closed this
Aug 8, 2016
@addaleax
addaleax
deleted the

gyp-filename-float

branch
August 8, 2016 20:48
addaleax added a commit
that referenced
this pull request
Aug 8, 2016
@addaleax
deps: float gyp patch for long filenames
5111e78
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: #7959
Ref: #7510
PR-URL: #7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
@cjihrigcjihrig
mentioned this pull request
Aug 10, 2016

Closed

cjihrig pushed a commit
that referenced
this pull request
Aug 10, 2016
@addaleax@cjihrig
deps: float gyp patch for long filenames
3f46b5c
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: #7959
Ref: #7510
PR-URL: #7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
@cjihrigcjihrig
mentioned this pull request
Aug 11, 2016
 Merged

MylesBorins pushed a commit
that referenced
this pull request
Sep 30, 2016
@addaleaxMyles Borins
deps: float gyp patch for long filenames
a2804ed
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: #7959
Ref: #7510
PR-URL: #7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
@MylesBorins
MylesBorins
commented
Sep 30, 2016

Copy link


Copy Markdown

Contributor
@addaleax I've backported this to v4.x
please let me know if it shouldn't have been
@bnoordhuis
bnoordhuis
commented
Oct 8, 2016

Copy link


Copy Markdown

Member
@addaleax I just noticed, you never assigned a reviewer in https://codereview.chromium.org/2019133002, that's probably why it's still open. I'd try one of bradnelson@, mark@ or thakis@.
bnoordhuis pushed a commit
to bnoordhuis/io.js
that referenced
this pull request
Oct 8, 2016
@addaleax@bnoordhuis
deps: float gyp patch for long filenames
369b9d5
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: nodejs#7959
Ref: nodejs#7510
PR-URL: nodejs#7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
rvagg pushed a commit
that referenced
this pull request
Oct 18, 2016
@addaleax@rvagg
deps: float gyp patch for long filenames
5d526fd
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: #7959
Ref: #7510
PR-URL: #7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Oct 26, 2016
@addaleax@MylesBorins
deps: float gyp patch for long filenames
36b3ff0
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: #7959
Ref: #7510
PR-URL: #7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
@MylesBorinsMylesBorins
mentioned this pull request
Oct 26, 2016
 Closed

rvagg pushed a commit
to nodejs/node-gyp
that referenced
this pull request
Aug 9, 2018
@addaleax@rvagg
gyp: float gyp patch for long filenames
a265040
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: nodejs/node#7959
Ref: nodejs/node#7510
PR-URL: nodejs/node#7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
rvagg pushed a commit
to nodejs/node-gyp
that referenced
this pull request
Aug 9, 2018
@addaleax@rvagg
gyp: float gyp patch for long filenames
fc3c4e2
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: nodejs/node#7959
Ref: nodejs/node#7510
PR-URL: nodejs/node#7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

buildIssues and PRs related to Node.js builds or CI infrastructure.toolsIssues and PRs related to the tools directory.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@addaleax@thefourtheye@bnoordhuis@jasnell@saghul@MylesBorins

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
deps: float gyp patch for long filenames - #7963
Closed
addaleax wants to merge 3 commits into
nodejs:masterfrom 
addaleax:gyp-filename-float
Closed
deps: float gyp patch for long filenames#7963
addaleax wants to merge 3 commits into
nodejs:masterfrom 
addaleax:gyp-filename-float
Conversation
@addaleax
@addaleaxaddaleax
commented
Aug 3, 2016

Copy link


Copy Markdown

Member
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  •  commit message follows commit guidelines
Affected core subsystem(s)
tools/gyp
Description of change
Pulling in https://codereview.chromium.org/2019133002/ in its current state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.

Concretely, this makes the V8 inspector build currently fail when long pathnames are involved, notably when using ecryptfs which has a lower file name length limit.
Fixes: #7959

Ref: #7510
@addaleax
deps: float gyp patch for long filenames
30a0d62
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: nodejs#7959
Ref: nodejs#7510
@addaleaxaddaleax
added

build
Issues and PRs related to Node.js builds or CI infrastructure.
tools
Issues and PRs related to the tools directory.
labels
Aug 3, 2016
@addaleax
addaleax
commented
Aug 3, 2016

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-commit/4392/
/cc @bnoordhuis@thefourtheye
@addaleaxaddaleax
mentioned this pull request
Aug 3, 2016

Closed

@thefourtheye
thefourtheye
commented
Aug 3, 2016

Copy link


Copy Markdown

Contributor
LGTM
bnoordhuis
bnoordhuis
reviewed
Aug 3, 2016
 View reviewed changes

Comment threadtools/gyp/pylib/gyp/generator/make.py
Outdated


 # Hash the target name to avoid generating overlong filenames.
 cmddigest = _new_sha1(command if command else self.target).hexdigest()
 intermediate = "%s.intermediate" % (cmddigest)
@bnoordhuisbnoordhuisAug 3, 2016

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick but the parens aren't necessary.
@bnoordhuis
bnoordhuis
commented
Aug 3, 2016

Copy link


Copy Markdown

Member
LGTM. Just curious, why did you name the variable _new_sha1 instead of e.g. sha1?
@addaleax
addaleax
commented
Aug 3, 2016

Copy link


Copy Markdown

MemberAuthor
That was copied from xcodeproj_file.py, too; I’m changing it, just sha1 sounds good to me too.
@thefourtheye
thefourtheye
commented
Aug 3, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
Actually, leading _ is correct, according to PEP-8. Quoting it,
Even with __all__ set appropriately, internal interfaces (packages, modules, classes, functions, attributes or other names) should still be prefixed with a single leading underscore.
@addaleax
addaleax
commented
Aug 3, 2016

Copy link


Copy Markdown

MemberAuthor
Sounds fine to me, I’ve left it and just dropped the extra parentheses.
@jasnell
jasnell
commented
Aug 3, 2016

Copy link


Copy Markdown

Member
LGTM
saghul
saghul
reviewed
Aug 4, 2016
 View reviewed changes

Comment threadtools/gyp/pylib/gyp/generator/make.py
Outdated

# available, avoiding a deprecation warning under 2.6. Import sha otherwise,
# preserving 2.4 compatibility.
try:
 import hashlib
@saghulsaghulAug 4, 2016

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since GYP is kinda abandoned and you're floating the patch, you can remove all that and just import hashlib. Python 2.4 predates YouTube, keeping compatibility with that is insane these days.
@addaleaxaddaleaxAug 4, 2016

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saghul Done! :)
@saghul
saghul
commented
Aug 4, 2016

Copy link


Copy Markdown

Member
LGTM! 👍
@jasnell
jasnell
commented
Aug 5, 2016

Copy link


Copy Markdown

Member
There was red in the previous CI run that looks like a build bot failure. Trying again just to be safe... CI: https://ci.nodejs.org/job/node-test-pull-request/3543/
@addaleax
addaleax
commented
Aug 8, 2016

Copy link


Copy Markdown

MemberAuthor
CI again: https://ci.nodejs.org/job/node-test-commit/4458/
@addaleax
addaleax
commented
Aug 8, 2016•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Landed in 00dc41d0a033f5ea38953c73cf2fe23f4a8ce5775111e78 … I can finally build master without flags again! 🎉 😄
@addaleaxaddaleax
closed this
Aug 8, 2016
@addaleax
addaleax
deleted the

gyp-filename-float

branch
August 8, 2016 20:48
addaleax added a commit
that referenced
this pull request
Aug 8, 2016
@addaleax
deps: float gyp patch for long filenames
5111e78
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: #7959
Ref: #7510
PR-URL: #7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
@cjihrigcjihrig
mentioned this pull request
Aug 10, 2016

Closed

cjihrig pushed a commit
that referenced
this pull request
Aug 10, 2016
@addaleax@cjihrig
deps: float gyp patch for long filenames
3f46b5c
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: #7959
Ref: #7510
PR-URL: #7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
@cjihrigcjihrig
mentioned this pull request
Aug 11, 2016
 Merged

MylesBorins pushed a commit
that referenced
this pull request
Sep 30, 2016
@addaleaxMyles Borins
deps: float gyp patch for long filenames
a2804ed
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: #7959
Ref: #7510
PR-URL: #7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
@MylesBorins
MylesBorins
commented
Sep 30, 2016

Copy link


Copy Markdown

Contributor
@addaleax I've backported this to v4.x
please let me know if it shouldn't have been
@bnoordhuis
bnoordhuis
commented
Oct 8, 2016

Copy link


Copy Markdown

Member
@addaleax I just noticed, you never assigned a reviewer in https://codereview.chromium.org/2019133002, that's probably why it's still open. I'd try one of bradnelson@, mark@ or thakis@.
bnoordhuis pushed a commit
to bnoordhuis/io.js
that referenced
this pull request
Oct 8, 2016
@addaleax@bnoordhuis
deps: float gyp patch for long filenames
369b9d5
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: nodejs#7959
Ref: nodejs#7510
PR-URL: nodejs#7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
rvagg pushed a commit
that referenced
this pull request
Oct 18, 2016
@addaleax@rvagg
deps: float gyp patch for long filenames
5d526fd
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: #7959
Ref: #7510
PR-URL: #7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Oct 26, 2016
@addaleax@MylesBorins
deps: float gyp patch for long filenames
36b3ff0
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: #7959
Ref: #7510
PR-URL: #7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
@MylesBorinsMylesBorins
mentioned this pull request
Oct 26, 2016
 Closed

rvagg pushed a commit
to nodejs/node-gyp
that referenced
this pull request
Aug 9, 2018
@addaleax@rvagg
gyp: float gyp patch for long filenames
a265040
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: nodejs/node#7959
Ref: nodejs/node#7510
PR-URL: nodejs/node#7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
rvagg pushed a commit
to nodejs/node-gyp
that referenced
this pull request
Aug 9, 2018
@addaleax@rvagg
gyp: float gyp patch for long filenames
fc3c4e2
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: nodejs/node#7959
Ref: nodejs/node#7510
PR-URL: nodejs/node#7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

buildIssues and PRs related to Node.js builds or CI infrastructure.toolsIssues and PRs related to the tools directory.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@addaleax@thefourtheye@bnoordhuis@jasnell@saghul@MylesBorins

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
deps: float gyp patch for long filenames - #7963
Closed
addaleax wants to merge 3 commits into
nodejs:masterfrom 
addaleax:gyp-filename-float
Closed
deps: float gyp patch for long filenames#7963
addaleax wants to merge 3 commits into
nodejs:masterfrom 
addaleax:gyp-filename-float
Conversation
@addaleax
@addaleaxaddaleax
commented
Aug 3, 2016

Copy link


Copy Markdown

Member
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  •  commit message follows commit guidelines
Affected core subsystem(s)
tools/gyp
Description of change
Pulling in https://codereview.chromium.org/2019133002/ in its current state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.

Concretely, this makes the V8 inspector build currently fail when long pathnames are involved, notably when using ecryptfs which has a lower file name length limit.
Fixes: #7959

Ref: #7510
@addaleax
deps: float gyp patch for long filenames
30a0d62
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: nodejs#7959
Ref: nodejs#7510
@addaleaxaddaleax
added

build
Issues and PRs related to Node.js builds or CI infrastructure.
tools
Issues and PRs related to the tools directory.
labels
Aug 3, 2016
@addaleax
addaleax
commented
Aug 3, 2016

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-commit/4392/
/cc @bnoordhuis@thefourtheye
@addaleaxaddaleax
mentioned this pull request
Aug 3, 2016

Closed

@thefourtheye
thefourtheye
commented
Aug 3, 2016

Copy link


Copy Markdown

Contributor
LGTM
bnoordhuis
bnoordhuis
reviewed
Aug 3, 2016
 View reviewed changes

Comment threadtools/gyp/pylib/gyp/generator/make.py
Outdated


 # Hash the target name to avoid generating overlong filenames.
 cmddigest = _new_sha1(command if command else self.target).hexdigest()
 intermediate = "%s.intermediate" % (cmddigest)
@bnoordhuisbnoordhuisAug 3, 2016

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick but the parens aren't necessary.
@bnoordhuis
bnoordhuis
commented
Aug 3, 2016

Copy link


Copy Markdown

Member
LGTM. Just curious, why did you name the variable _new_sha1 instead of e.g. sha1?
@addaleax
addaleax
commented
Aug 3, 2016

Copy link


Copy Markdown

MemberAuthor
That was copied from xcodeproj_file.py, too; I’m changing it, just sha1 sounds good to me too.
@thefourtheye
thefourtheye
commented
Aug 3, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
Actually, leading _ is correct, according to PEP-8. Quoting it,
Even with __all__ set appropriately, internal interfaces (packages, modules, classes, functions, attributes or other names) should still be prefixed with a single leading underscore.
@addaleax
addaleax
commented
Aug 3, 2016

Copy link


Copy Markdown

MemberAuthor
Sounds fine to me, I’ve left it and just dropped the extra parentheses.
@jasnell
jasnell
commented
Aug 3, 2016

Copy link


Copy Markdown

Member
LGTM
saghul
saghul
reviewed
Aug 4, 2016
 View reviewed changes

Comment threadtools/gyp/pylib/gyp/generator/make.py
Outdated

# available, avoiding a deprecation warning under 2.6. Import sha otherwise,
# preserving 2.4 compatibility.
try:
 import hashlib
@saghulsaghulAug 4, 2016

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since GYP is kinda abandoned and you're floating the patch, you can remove all that and just import hashlib. Python 2.4 predates YouTube, keeping compatibility with that is insane these days.
@addaleaxaddaleaxAug 4, 2016

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saghul Done! :)
@saghul
saghul
commented
Aug 4, 2016

Copy link


Copy Markdown

Member
LGTM! 👍
@jasnell
jasnell
commented
Aug 5, 2016

Copy link


Copy Markdown

Member
There was red in the previous CI run that looks like a build bot failure. Trying again just to be safe... CI: https://ci.nodejs.org/job/node-test-pull-request/3543/
@addaleax
addaleax
commented
Aug 8, 2016

Copy link


Copy Markdown

MemberAuthor
CI again: https://ci.nodejs.org/job/node-test-commit/4458/
@addaleax
addaleax
commented
Aug 8, 2016•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Landed in 00dc41d0a033f5ea38953c73cf2fe23f4a8ce5775111e78 … I can finally build master without flags again! 🎉 😄
@addaleaxaddaleax
closed this
Aug 8, 2016
@addaleax
addaleax
deleted the

gyp-filename-float

branch
August 8, 2016 20:48
addaleax added a commit
that referenced
this pull request
Aug 8, 2016
@addaleax
deps: float gyp patch for long filenames
5111e78
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: #7959
Ref: #7510
PR-URL: #7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
@cjihrigcjihrig
mentioned this pull request
Aug 10, 2016

Closed

cjihrig pushed a commit
that referenced
this pull request
Aug 10, 2016
@addaleax@cjihrig
deps: float gyp patch for long filenames
3f46b5c
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: #7959
Ref: #7510
PR-URL: #7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
@cjihrigcjihrig
mentioned this pull request
Aug 11, 2016
 Merged

MylesBorins pushed a commit
that referenced
this pull request
Sep 30, 2016
@addaleaxMyles Borins
deps: float gyp patch for long filenames
a2804ed
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: #7959
Ref: #7510
PR-URL: #7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
@MylesBorins
MylesBorins
commented
Sep 30, 2016

Copy link


Copy Markdown

Contributor
@addaleax I've backported this to v4.x
please let me know if it shouldn't have been
@bnoordhuis
bnoordhuis
commented
Oct 8, 2016

Copy link


Copy Markdown

Member
@addaleax I just noticed, you never assigned a reviewer in https://codereview.chromium.org/2019133002, that's probably why it's still open. I'd try one of bradnelson@, mark@ or thakis@.
bnoordhuis pushed a commit
to bnoordhuis/io.js
that referenced
this pull request
Oct 8, 2016
@addaleax@bnoordhuis
deps: float gyp patch for long filenames
369b9d5
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: nodejs#7959
Ref: nodejs#7510
PR-URL: nodejs#7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
rvagg pushed a commit
that referenced
this pull request
Oct 18, 2016
@addaleax@rvagg
deps: float gyp patch for long filenames
5d526fd
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: #7959
Ref: #7510
PR-URL: #7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Oct 26, 2016
@addaleax@MylesBorins
deps: float gyp patch for long filenames
36b3ff0
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: #7959
Ref: #7510
PR-URL: #7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
@MylesBorinsMylesBorins
mentioned this pull request
Oct 26, 2016
 Closed

rvagg pushed a commit
to nodejs/node-gyp
that referenced
this pull request
Aug 9, 2018
@addaleax@rvagg
gyp: float gyp patch for long filenames
a265040
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: nodejs/node#7959
Ref: nodejs/node#7510
PR-URL: nodejs/node#7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
rvagg pushed a commit
to nodejs/node-gyp
that referenced
this pull request
Aug 9, 2018
@addaleax@rvagg
gyp: float gyp patch for long filenames
fc3c4e2
Pulling in https://codereview.chromium.org/2019133002/ in its current
state, as gyp seems to be largely abandoned as a project.
Original commit message:
Hash intermediate file name to avoid ENAMETOOLONG
Hash the intermediate Makefile target used for multi-output rules
so that it still works when the involved file names are very long.
Since the intermediate file's name is effectively arbitrary, this
does not come with notable behavioural changes.
The `import hashlib` boilerplate is taken directly
from `xcodeproj_file.py`.
Concretely, this makes the V8 inspector build currently fail when long
pathnames are involved, notably when using ecryptfs which has a lower
file name length limit.
Fixes: nodejs/node#7959
Ref: nodejs/node#7510
PR-URL: nodejs/node#7963
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

buildIssues and PRs related to Node.js builds or CI infrastructure.toolsIssues and PRs related to the tools directory.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@addaleax@thefourtheye@bnoordhuis@jasnell@saghul@MylesBorins