Uh oh!
There was an error while loading. Please reload this page.
Backport doc: server.listen() random port - #8025
Closed
phillipj wants to merge 1 commit into
Closed
Conversation
Minor rewording related to making a server listen to a random port, and added how to retrieve which port was randomly chosen by the OS. Also changed documented `server.listen()` signature as it does in fact not require `port` to be provided. PR-URL: nodejs#7976 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
phillipjforce-pushed
the
backport-doc-server-port
branch
from
August 22, 2016 08:31
f3b887f to
e78fa6cComparephillipj
commented
Aug 22, 2016
MemberAuthor
jasnell
commented
Aug 22, 2016
Member
LGTM |
phillipj
commented
Aug 23, 2016
MemberAuthor
@nodejs/lts is one of you supposed to merge this or should I? |
jasnell
commented
Aug 23, 2016
Member
I'd like @cjihrig to sign off on it also, then I can land. |
cjihrig
commented
Aug 24, 2016
Contributor
LGTM |
jasnell pushed a commit
that referenced
this pull request
Aug 24, 2016
Minor rewording related to making a server listen to a random port, and added how to retrieve which port was randomly chosen by the OS. Also changed documented `server.listen()` signature as it does in fact not require `port` to be provided. PR-URL: #8025 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell
commented
Aug 24, 2016
Member
Landed in 3ecd06d |
MylesBorins pushed a commit
that referenced
this pull request
Sep 28, 2016
Minor rewording related to making a server listen to a random port, and added how to retrieve which port was randomly chosen by the OS. Also changed documented `server.listen()` signature as it does in fact not require `port` to be provided. PR-URL: #8025 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
rvagg pushed a commit
that referenced
this pull request
Oct 18, 2016
Minor rewording related to making a server listen to a random port, and added how to retrieve which port was randomly chosen by the OS. Also changed documented `server.listen()` signature as it does in fact not require `port` to be provided. PR-URL: #8025 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Oct 26, 2016
Minor rewording related to making a server listen to a random port, and added how to retrieve which port was randomly chosen by the OS. Also changed documented `server.listen()` signature as it does in fact not require `port` to be provided. PR-URL: #8025 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
doc
Description of change
Backported from 57e95d9 / #7976.
Minor rewording related to making a server listen to a random port, and added how to retrieve which port was randomly chosen by the OS.
Also changed documented
server.listen()signature as it does in fact not requireportto be provided (lib/net.js#L1339).