Skip to content

doc: Add fhinkel to collaborators - #8052

Closed
fhinkel wants to merge 1 commit into
nodejs:masterfrom
fhinkel:collaborator
Closed

doc: Add fhinkel to collaborators#8052
fhinkel wants to merge 1 commit into
nodejs:masterfrom
fhinkel:collaborator

Conversation

@fhinkel

Copy link
Copy Markdown
Member
Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Add https://github.com/fhinkel to collaborators.

@fhinkelfhinkel added the doc Issues and PRs related to the documentations. label Aug 10, 2016
Comment threadREADME.md Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a missing ** after your name.

@fhinkel

Copy link
Copy Markdown
MemberAuthor

@cjihrig

Copy link
Copy Markdown
Contributor

LGTM, pending nits.

@Trott

Copy link
Copy Markdown
Member

LGTM

@jasnell

Copy link
Copy Markdown
Member

LGTM!

fhinkel added a commit that referenced this pull request Aug 10, 2016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #8052
@fhinkel

Copy link
Copy Markdown
MemberAuthor

Landed in 4878e1c.

@fhinkelfhinkel closed this Aug 10, 2016
@MylesBorins

Copy link
Copy Markdown
Contributor

🎉🎉🎉🎉

On Wed, Aug 10, 2016, 1:18 PM Franziska Hinkelmann notifications@github.com
wrote:

Closed #8052#8052.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#8052 (comment), or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAecVx4TJqBsftpL4sbGUI7bhxymc5Vgks5qegffgaJpZM4JhXNJ
.

cjihrig pushed a commit that referenced this pull request Aug 10, 2016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #8052
@cjihrigcjihrig mentioned this pull request Aug 11, 2016
MylesBorins pushed a commit that referenced this pull request Sep 9, 2016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #8052
MylesBorins pushed a commit that referenced this pull request Sep 28, 2016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #8052
rvagg pushed a commit that referenced this pull request Oct 18, 2016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #8052
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #8052
@MylesBorinsMylesBorins mentioned this pull request Oct 26, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@fhinkel@cjihrig@Trott@jasnell@MylesBorins