Uh oh!
There was an error while loading. Please reload this page.
doc: minor updates to onboarding doc - #8060
Closed
Trott wants to merge 3 commits into
Closed
Conversation
addaleax
commented
Aug 10, 2016
Member
LGTM ;) |
fhinkel
commented
Aug 11, 2016
Member
LGTM. If you're changing this anyways, do you want to remove (or add, as long as it is consistent) the semicolons in the headers? |
Trott
commented
Aug 11, 2016
MemberAuthor
@fhinkel Sure thing! Done! |
Member
There was a problem hiding this comment.
aaahhhh! lower cased headings.... must ... resist ...
jasnell
commented
Aug 11, 2016
Member
LGTM |
Trott added a commit
to Trott/io.js
that referenced
this pull request
Aug 12, 2016
PR-URL: nodejs#8060 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Trott
commented
Aug 12, 2016
MemberAuthor
cjihrig pushed a commit
that referenced
this pull request
Aug 15, 2016
PR-URL: #8060 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Sep 9, 2016
PR-URL: #8060 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Sep 28, 2016
PR-URL: #8060 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit
that referenced
this pull request
Oct 18, 2016
PR-URL: #8060 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Oct 26, 2016
PR-URL: #8060 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change