Uh oh!
There was an error while loading. Please reload this page.
Backport support for building as DLL on Windows to V6 - #8084
Closed
sxa wants to merge 2 commits into
Closed
Conversation
jasnell
commented
Aug 12, 2016
Member
@nodejs/build @bnoordhuis |
bnoordhuis
commented
Aug 17, 2016
Member
Can you rebase? |
Added "dll" option to vcbuild.bat Insure that Unix SO name is not used on Windows (i.e. produce a .dll file) Insure that Node and its V8 dependency link against the Visual C++ Runtime dynamically. Requires backported V8 patch, see PR 7802. Ref: nodejs#7802 PR-URL: nodejs#7487 Reviewed-By: Alexis Campailla <alexis@janeasystems.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
sxa
commented
Aug 21, 2016
MemberAuthor
@bnoordhuis Done. |
bnoordhuis
commented
Aug 22, 2016
Member
LGTM |
1 similar comment
jasnell
commented
Aug 22, 2016
Member
LGTM |
jasnell
commented
Aug 22, 2016
Member
sxa
commented
Aug 23, 2016
MemberAuthor
Failing test in test/linux-ppc looks to have been a timeout in parallel/test-fs-utimes so I would imagine that's unrelated to anything I've done. |
jasnell
commented
Aug 23, 2016
Member
Appears unrelated. |
jasnell pushed a commit
that referenced
this pull request
Aug 24, 2016
Original Commit Message: Added "dll" option to vcbuild.bat Insure that Unix SO name is not used on Windows (i.e. produce a .dll file) Insure that Node and its V8 dependency link against the Visual C++ Runtime dynamically. Requires backported V8 patch, see PR 7802. Ref: #7802 PR-URL: #7487 Reviewed-By: Alexis Campailla <alexis@janeasystems.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: #8084 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit
that referenced
this pull request
Aug 24, 2016
PR-URL: #8084 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
commented
Aug 24, 2016
Member
MylesBorins
commented
Nov 15, 2016
Contributor
This landed without the correct meta deta. It also did not bump the v8 patch level |
sam-github
commented
Nov 15, 2016
Contributor
Should the contributing.md list the required metadata for v8 commits? These look like they have the normal github metadata, I assume its the chomium links that are missing? |
MylesBorins
commented
Nov 15, 2016
Contributor
@sam-github there is a document in draft form over at the LTS repo. We should likely lift some of it over to the contributing.md or potentially include a link once it lands |
sam-github
commented
Nov 15, 2016
Contributor
@thealphanerd Found it (nodejs/Release#137), thanks. Something similar for openssl would be useful, too. |
sxa pushed a commit
to sxa/node
that referenced
this pull request
Nov 16, 2016
PR-URL: nodejs#8084 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
sxa pushed a commit
to sxa/node
that referenced
this pull request
Nov 16, 2016
Add force_dynamic_crt option to build a static library with /MD on windows Adds option to build a V8 library statically, but with the options on windows that allows it to be subsequently included in another DLL. On Windows this is required for it to correclty link against the correct C++ runtime. Require for our Node.js shared library build. PR-URL: nodejs#8084 Reference: nodejs#7487 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
to MylesBorins/node
that referenced
this pull request
Nov 17, 2016
Original commit message: [build] Add force_dynamic_crt option to build a static library with /… …MD on windows Adds option to build a V8 library statically, but with the options on windows that allows it to be subsequently included in another DLL. On Windows this is required for it to correclty link against the correct C++ runtime. Require for our Node.js shared library build. Reference: nodejs#7487 BUG= R=machenbach@chromium.org, michael_dawson@ca.ibm.com Committed: https://crrev.com/9cf88c1c364cf76c1e745aa63196768435e8ef5d Review-Url: https://codereview.chromium.org/2149963002 Cr-Original-Commit-Position: refs/heads/master@{nodejs#37814} Cr-Commit-Position: refs/heads/master@{nodejs#37856} Ref: nodejs#7802 Ref: nodejs#8084 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit
that referenced
this pull request
Nov 17, 2016
Original commit message: [build] Add force_dynamic_crt option to build a static library with /… …MD on windows Adds option to build a V8 library statically, but with the options on windows that allows it to be subsequently included in another DLL. On Windows this is required for it to correclty link against the correct C++ runtime. Require for our Node.js shared library build. Reference: #7487 BUG= R=machenbach@chromium.org, michael_dawson@ca.ibm.com Committed: https://crrev.com/9cf88c1c364cf76c1e745aa63196768435e8ef5d Review-Url: https://codereview.chromium.org/2149963002 Cr-Original-Commit-Position: refs/heads/master@{#37814} Cr-Commit-Position: refs/heads/master@{#37856} Ref: #7802 Ref: #8084 PR-URL: #9610 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
sxa pushed a commit
to sxa/node
that referenced
this pull request
Nov 18, 2016
PR-URL: nodejs#8084 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
BethGriggs pushed a commit
to ibmruntimes/node
that referenced
this pull request
Dec 7, 2016
Ref: nodejs/node#9385 PR-URL: nodejs/node#8084 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build: windows sharedlib support
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
build
Description of change
Backport of #7487 to V6.x. Includes the V8 change mentioned in #7802