test: remove flaky test functionality

[rvagg]

Reverts nodejs/node-v0.x-archive#8689

I'm proposing that we remove this embarrassing functionality. If we need have special cases for tests then we should have that explicitly documented and implemented in the tests themselves.

[Fishrock123]

+1

Any idea what sort of tests will fail after this?

[rvagg]

I don't believe any will, we didn't merge in the list of flaky tests and went ahead and fixed those tests anyway

https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/171/

[Fishrock123]

Hmmm, some strange errors are cropping up on that CI run. Tested with & without the patch on OS X 10.10 and everything seems fine.

[jbergstroem]

@Fishrock123 The add ons probably aren't build before run. Possibly separate test-addons from make test similar to make build-addons?

[rvagg]

yes, I put test-ci back on instead of separate test-simple & test-message, so we can test #810

[bnoordhuis]

LGTM

[jbergstroem]

I'm all for removing the flaky stuff too.

[cjihrig]

+1 and LGTM

[Fishrock123]

Re-running the CI on this since some failures seemed unrelated: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/174/

[Fishrock123]

Not sure if relevant, but this cropped up on iojs-centos5-64.

[01:47|% 36|+ 284|- 0]: release test-http-curl-chunk-problem === release test-http-curl-chunk-problem ===
Path: parallel/test-http-curl-chunk-problem
dd command: dd if=/dev/zero of="/home/iojs/build/workspace/iojs+any-pr+multi/nodes/iojs-centos5-64/test/tmp.0/big" bs=1024 count=10240
Server running at http://localhost:8080
making curl request
events.js:141
throw er; // Unhandled 'error' event
^
Error: write after end
at ServerResponse.OutgoingMessage.write (_http_outgoing.js:392:15)
at Socket.<anonymous> (/home/iojs/build/workspace/iojs+any-pr+multi/nodes/iojs-centos5-64/test/parallel/test-http-curl-chunk-problem.js:48:9)
at emitOne (events.js:77:13)
at Socket.emit (events.js:166:7)
at readableAddChunk (_stream_readable.js:146:16)
at Socket.Readable.push (_stream_readable.js:109:10)
at Pipe.onread (net.js:510:20)
Command: out/Release/iojs /home/iojs/build/workspace/iojs+any-pr+multi/nodes/iojs-centos5-64/test/parallel/test-http-curl-chunk-problem.js

[rvagg]

@Fishrock123 already filed as #790 and dupe @ #809

[rvagg]

landed via 20f8e7f