Skip to content

test: favor === over == in crypto tests - #8176

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:test-crypto-eqeqeq
Closed

test: favor === over == in crypto tests#8176
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:test-crypto-eqeqeq

Conversation

@Trott

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test crypto

Description of change

@TrottTrott added crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests. labels Aug 18, 2016
@cjihrig

Copy link
Copy Markdown
Contributor

LGTM

2 similar comments
@jasnell

Copy link
Copy Markdown
Member

LGTM

@targos

Copy link
Copy Markdown
Member

LGTM

@Trott

Copy link
Copy Markdown
MemberAuthor

Trott added a commit to Trott/io.js that referenced this pull request Aug 22, 2016
PR-URL: nodejs#8176
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@Trott

Copy link
Copy Markdown
MemberAuthor

Landed in 3d21907

@TrottTrott closed this Aug 22, 2016
evanlucas pushed a commit that referenced this pull request Aug 24, 2016
PR-URL: #8176
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
PR-URL: #8176
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
PR-URL: #8176
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
PR-URL: #8176
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@MylesBorinsMylesBorins mentioned this pull request Oct 26, 2016
@Trott
Trott deleted the test-crypto-eqeqeq branch January 13, 2022 22:44
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cryptoIssues and PRs related to the crypto subsystem.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@Trott@cjihrig@jasnell@targos@MylesBorins