Uh oh!
There was an error while loading. Please reload this page.
doc: fix buf.readUIntBE, buf.readUIntLE examples - #8240
Closed
mozkeeler wants to merge 1 commit into
Closed
Conversation
The documentation describing the output from the examples for buf.readUIntBE and buf.readUIntLE were switched in terms of what the code would actually output. This patch addresses this by switching the two lines of example code to be in the same order as the functions are listed earlier in the documentation.
jasnell
commented
Aug 23, 2016
Member
LGTM |
2 similar comments
mscdex
commented
Aug 23, 2016
Contributor
LGTM |
cjihrig
commented
Aug 24, 2016
Contributor
LGTM |
addaleax
commented
Aug 24, 2016
Member
Thanks, looks good to me too! |
princejwesley
commented
Aug 24, 2016
Contributor
LGTM |
addaleax
commented
Aug 25, 2016
Member
Landed in 7f1bb80, thanks for the PR! |
addaleax pushed a commit
that referenced
this pull request
Aug 25, 2016
The documentation describing the output from the examples for buf.readUIntBE and buf.readUIntLE were switched in terms of what the code would actually output. This patch addresses this by switching the two lines of example code to be in the same order as the functions are listed earlier in the documentation. PR-URL: #8240 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
mozkeeler
commented
Aug 25, 2016
ContributorAuthor
Thanks! |
Closed
Fishrock123 pushed a commit
to Fishrock123/node
that referenced
this pull request
Sep 8, 2016
The documentation describing the output from the examples for buf.readUIntBE and buf.readUIntLE were switched in terms of what the code would actually output. This patch addresses this by switching the two lines of example code to be in the same order as the functions are listed earlier in the documentation. PR-URL: nodejs#8240 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Fishrock123 pushed a commit
that referenced
this pull request
Sep 9, 2016
The documentation describing the output from the examples for buf.readUIntBE and buf.readUIntLE were switched in terms of what the code would actually output. This patch addresses this by switching the two lines of example code to be in the same order as the functions are listed earlier in the documentation. PR-URL: #8240 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
The documentation describing the output from the examples for
buf.readUIntBE and buf.readUIntLE were switched in terms of what the
code would actually output. This patch addresses this by switching the
two lines of example code to be in the same order as the functions are
listed earlier in the documentation.