Uh oh!
There was an error while loading. Please reload this page.
test: add known issue test for path parse issue #6229 - #8293
Conversation
| const assert = require('assert'); | ||
| const path = require('path'); | ||
| // Issue: https://github.com/nodejs/node/issues/6229 |
There was a problem hiding this comment.
Could you move this to the top, just under 'use strict;', and change Issue to Refs for consistency with the other known issue tests.
cjihrig
commented
Aug 27, 2016
LGTM with a comment. |
jasnell
commented
Aug 27, 2016
Done. Also renamed the test file to be more specific. |
Trott
commented
Aug 27, 2016
Nit: Two tests in the file, one for Nit: Instead of asserting that the two results are not equal, maybe make the test a bit more strict by asserting that each one equals exactly what it is supposed to equal? assert.strictEqual(parsed1,{root: '/',dir: '/foo',base: 'bar',ext: '',name: 'bar'});assert.strictEqual(parsed2,{root: '/',dir: '/foo/bar',base: '',ext: '',name: ''});If you're concerned that maybe we'll add another key to the object, you could do assertions specifically for the |
jasnell
commented
Aug 27, 2016
Updated. |
Trott
commented
Aug 27, 2016
LGTM |
jasnell
commented
Aug 29, 2016
Landed in 407069a |
Refs: nodejs#6229 PR-URL: nodejs#8293 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
commented
Sep 30, 2016
@jasnell backport to v4x? |
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
known_issue
Description of change
Add known_issue test for #6229