Uh oh!
There was an error while loading. Please reload this page.
win,build: forward release_urlbase to configure - #8430
Closed
joaocgreis wants to merge 1 commit into
Closed
Conversation
The RELEASE_URLBASE environment variable is used in releases as a prefix for links in the process.release object. The Makefile picks it and forwards it to configure, but vcbuild.bat did not. Hence, in Windows, Node releases have a correct process.release because it uses the default URL, but nightlies, RCs and so on do not, breaking node-gyp. This enables native modules to be built with such versions of Node.
joaocgreis
commented
Sep 7, 2016
MemberAuthor
jbergstroem
commented
Sep 7, 2016
Member
LGTM |
orangemocha
commented
Sep 9, 2016
Contributor
Nothing in CI tests, but just to be extra safe: https://ci.nodejs.org/job/node-test-commit/4973/ The arm failure is certainly unrelated. |
orangemocha pushed a commit
that referenced
this pull request
Sep 9, 2016
The RELEASE_URLBASE environment variable is used in releases as a prefix for links in the process.release object. The Makefile picks it and forwards it to configure, but vcbuild.bat did not. Hence, in Windows, Node releases have a correct process.release because it uses the default URL, but nightlies, RCs and so on do not, breaking node-gyp. This enables native modules to be built with such versions of Node. PR-URL: #8430 Reviewed-By: jbergstroem - Johan Bergström <bugs@bergstroem.nu>
orangemocha
commented
Sep 9, 2016
Contributor
Landed in 137b7cb (@joaocgreis is off today, I am landing this on his behalf so that this can make the v7.x cut on Monday). |
Fishrock123 pushed a commit
that referenced
this pull request
Sep 14, 2016
The RELEASE_URLBASE environment variable is used in releases as a prefix for links in the process.release object. The Makefile picks it and forwards it to configure, but vcbuild.bat did not. Hence, in Windows, Node releases have a correct process.release because it uses the default URL, but nightlies, RCs and so on do not, breaking node-gyp. This enables native modules to be built with such versions of Node. PR-URL: #8430 Reviewed-By: jbergstroem - Johan Bergström <bugs@bergstroem.nu>
joaocgreis added a commit
to JaneaSystems/node
that referenced
this pull request
Sep 14, 2016
The RELEASE_URLBASE environment variable is used in releases as a prefix for links in the process.release object. The Makefile picks it and forwards it to configure, but vcbuild.bat did not. Hence, in Windows, Node releases have a correct process.release because it uses the default URL, but nightlies, RCs and so on do not, breaking node-gyp. This enables native modules to be built with such versions of Node. PR-URL: nodejs#8430 Reviewed-By: jbergstroem - Johan Bergström <bugs@bergstroem.nu>
MylesBorins
commented
Sep 30, 2016
Contributor
@joaocgreis should this be backported? |
joaocgreis
commented
Oct 3, 2016
MemberAuthor
@thealphanerd yes, thanks! |
MylesBorins pushed a commit
that referenced
this pull request
Oct 11, 2016
The RELEASE_URLBASE environment variable is used in releases as a prefix for links in the process.release object. The Makefile picks it and forwards it to configure, but vcbuild.bat did not. Hence, in Windows, Node releases have a correct process.release because it uses the default URL, but nightlies, RCs and so on do not, breaking node-gyp. This enables native modules to be built with such versions of Node. PR-URL: #8430 Reviewed-By: jbergstroem - Johan Bergström <bugs@bergstroem.nu>
rvagg pushed a commit
that referenced
this pull request
Oct 18, 2016
The RELEASE_URLBASE environment variable is used in releases as a prefix for links in the process.release object. The Makefile picks it and forwards it to configure, but vcbuild.bat did not. Hence, in Windows, Node releases have a correct process.release because it uses the default URL, but nightlies, RCs and so on do not, breaking node-gyp. This enables native modules to be built with such versions of Node. PR-URL: #8430 Reviewed-By: jbergstroem - Johan Bergström <bugs@bergstroem.nu>
MylesBorins pushed a commit
that referenced
this pull request
Oct 26, 2016
The RELEASE_URLBASE environment variable is used in releases as a prefix for links in the process.release object. The Makefile picks it and forwards it to configure, but vcbuild.bat did not. Hence, in Windows, Node releases have a correct process.release because it uses the default URL, but nightlies, RCs and so on do not, breaking node-gyp. This enables native modules to be built with such versions of Node. PR-URL: #8430 Reviewed-By: jbergstroem - Johan Bergström <bugs@bergstroem.nu>
Closed
joaocgreis added a commit
to joaocgreis/node-chakracore
that referenced
this pull request
Nov 16, 2016
The RELEASE_URLBASE environment variable is used in releases as a prefix for links in the process.release object. The Makefile picks it and forwards it to configure, but vcbuild.bat did not. Hence, in Windows, Node releases have a correct process.release because it uses the default URL, but nightlies, RCs and so on do not, breaking node-gyp. This enables native modules to be built with such versions of Node. PR-URL: nodejs/node#8430 Reviewed-By: jbergstroem - Johan Bergström <bugs@bergstroem.nu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Windows, Build.
Description of change
The
RELEASE_URLBASEenvironment variable is used in releases as a prefix for links in theprocess.releaseobject (#2154). TheMakefilepicks it and forwards it toconfigure, butvcbuild.batdid not. Hence, in Windows, Node releases have a correctprocess.releasebecause it uses the default URL, but nightlies, RCs and so on do not, breaking node-gyp. This enables native modules to be built with such versions of Node.cc @nodejs/platform-windows