querystring: optimize parse and stringify by mscdex · Pull Request #847 · nodejs/node

mscdex · 2015-02-14T18:08:46Z

parse optimizations:

Move try-catch to separate function to keep entire function from
being deoptimized.
Use key array lookup instead of using hasOwnProperty.
Avoid decoding known empty strings.
Avoid possibly unnecessary switch to slower decoder for values if
key decoding throws.

stringify optimizations:

Use manual loop for default encoder instead of encodeURIComponent.
Use string concatenation instead of joining an array of strings.
Avoid caching result of typeof.

Results with benchmarks from #846:

querystring/querystring-parse.js type=noencode n=1000000: ./iojs-after: 296290 ./iojs-before: 224220 ........ 32.14%
querystring/querystring-parse.js type=encodemany n=1000000: ./iojs-after: 263410 ./iojs-before: 213780 ...... 23.22%
querystring/querystring-parse.js type=encodelast n=1000000: ./iojs-after: 284420 ./iojs-before: 194230 ...... 46.44%
querystring/querystring-stringify.js type=noencode n=1000000: ./iojs-after: 983630 ./iojs-before: 610680 .... 61.07%
querystring/querystring-stringify.js type=encodemany n=1000000: ./iojs-after: 857700 ./iojs-before: 187150 . 358.30%
querystring/querystring-stringify.js type=encodelast n=1000000: ./iojs-after: 987650 ./iojs-before: 290730 . 239.72%

vkurchatkin · 2015-02-14T18:21:07Z

Avoid caching result of typeof.

Do you have a link to something that explains this one?

mscdex · 2015-02-14T18:50:58Z

@vkurchatkin No particular link. I saw someone mention it in one of the other PRs and thought I'd try it out. It's not a huge performance boost, but there was a difference.

Fishrock123 · 2015-02-14T18:54:41Z

My general rule is make a var where there are are 3-4+ references to like a typeof, or a thing.thing.value_you_want. Then it makes sense for clarity.

vkurchatkin · 2015-02-14T19:04:32Z

Ok, after looking through v8 I found some hints that typeof x === "y" is compiled as a whole

Double negation considered slower than a straight null check.

PR-URL: #847 Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>

mscdex · 2015-02-16T15:26:30Z

Don't merge just yet, I think I may have some further improvements at least for parse...

mscdex · 2015-02-17T18:15:04Z

Ok, scratch that. For some reason I see a larger increase with my uncommitted changes to parse() than the current committed changes with benchmark.js-based benchmarks but not so with the io.js querystring benchmarks (same inputs). I'm ok with this current implementation for now though.

Thoughts?

/cc @bnoordhuis @trevnorris

brendanashworth · 2015-02-19T08:19:46Z

would it be worth it to bump this line up before the str.length === 0 check?

parse optimizations: * Move try-catch to separate function to keep entire function from being deoptimized. * Use key array lookup instead of using hasOwnProperty. * Avoid decoding known empty strings. * Avoid possibly unnecessary switch to slower decoder for values if key decoding throws. stringify optimizations: * Use manual loop for default encoder instead of encodeURIComponent. * Use string concatenation instead of joining an array of strings. * Avoid caching result of typeof.

trevnorris · 2015-02-20T00:05:08Z

I'm cool with this.

mscdex · 2015-03-04T06:02:27Z

Everything look alright for merging this?

/cc @iojs/collaborators

cjihrig · 2015-03-05T16:25:09Z

We should see what the CI says before merging.

https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/245/

parse optimizations: * Move try-catch to separate function to keep entire function from being deoptimized. * Use key array lookup instead of using hasOwnProperty. * Avoid decoding known empty strings. * Avoid possibly unnecessary switch to slower decoder for values if key decoding throws. stringify optimizations: * Use manual loop for default encoder instead of encodeURIComponent. * Use string concatenation instead of joining an array of strings. * Avoid caching result of typeof. PR-URL: nodejs#847 Reviewed-By: Trevor Norris <trev.norris@gmail.com>

mscdex · 2015-03-16T03:16:40Z

Landed in 85a92a3.

Notable Changes: * path: New type-checking on path.resolve() <#1153> uncovered some edge-cases being relied upon in the wild, most notably path.dirname(undefined). Type-checking has been loosened for path.dirname(), path.basename(), and path.extname(), (Colin Ihrig) <#1216>. * querystring: Internal optimizations in querystring.parse() and querystring.stringify() <#847> prevented Number literals from being properly converted via querystring.escape() <#1208>, exposing a blind-spot in the test suite. The bug and the tests have now been fixed (Jeremiah Senkpiel) <#1213>.

narqo · 2015-03-29T20:09:35Z

Ok, after looking through v8 I found some hints that typeof x === "y" is compiled as a whole

@vkurchatkin I'd be grateful if you could point me on such hints. It sound really interesting to me, but I couldn't find any confirmations.

mscdex · 2015-03-29T20:28:04Z

@narqo If you're looking for the v8 commit that added that optimization, it is r9688.

Fishrock123 referenced this pull request in ceejbot/io.js Feb 14, 2015
Perf tweak as suggested by@cjihrig
aac9a5e
Double negation considered slower than a straight null check.

brendanashworth pushed a commit that referenced this pull request Feb 15, 2015
benchmark: add a few querystring benchmarks
35ed799
PR-URL: #847 Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>

rvagg mentioned this pull request Feb 18, 2015
Release proposal: v1.3.0 #872
Closed

mscdex force-pushed the perf-querystring branch from 3a34127 to 88e00f8Compare February 18, 2015 21:01

brendanashworth reviewed Feb 19, 2015
View reviewed changes

mscdex force-pushed the perf-querystring branch from 88e00f8 to 6610767Compare February 19, 2015 14:53

Fishrock123 added the querystring Issues and PRs related to the built-in querystring module. label Feb 23, 2015

mscdex mentioned this pull request Feb 24, 2015
Release proposal: v1.4.0 #932
Closed

mscdex closed this Mar 16, 2015

mscdex deleted the perf-querystring branch March 16, 2015 03:16

rvagg mentioned this pull request Mar 17, 2015
Release proposal: v1.6.0 #1157
Closed

AdriVanHoudt mentioned this pull request Mar 19, 2015
Perf boost ljharb/qs#77
Closed

rvagg mentioned this pull request Mar 20, 2015
Release proposal: v1.6.1 #1212
Closed

julianduque mentioned this pull request Mar 20, 2015
Evangelism: Weekly Update March 20th nodejs/evangelism#46
Closed

yosuke-furukawa mentioned this pull request Mar 21, 2015
ウィークリー 2015/03/20 nodejs/nodejs-ja#63
Merged

a0viedo mentioned this pull request Apr 30, 2015
weekly-update.2015-03-20.md nodejs/nodejs-es#120
Merged

hakatashi mentioned this pull request Nov 7, 2015
Is it valid not to throw error in querystring.encode? #3702
Closed

snyk-bot mentioned this pull request Jan 31, 2022
[Snyk] Security upgrade shelljs from 0.7.8 to 0.8.5 enterstudio/node#26
Open

aliscco mentioned this pull request Apr 27, 2023
[Snyk] Fix for 30 vulnerabilities aliscco/alisco-node#279
Open

Uh oh!

Uh oh!

Conversation

mscdex commented Feb 14, 2015

Uh oh!

vkurchatkin commented Feb 14, 2015

Uh oh!

mscdex commented Feb 14, 2015

Uh oh!

Fishrock123 commented Feb 14, 2015

Uh oh!

vkurchatkin commented Feb 14, 2015

Uh oh!

mscdex commented Feb 16, 2015

Uh oh!

mscdex commented Feb 17, 2015

Uh oh!

brendanashworthFeb 19, 2015

Choose a reason for hiding this comment

Uh oh!

trevnorris commented Feb 20, 2015

Uh oh!

mscdex commented Mar 4, 2015

Uh oh!

cjihrig commented Mar 5, 2015

Uh oh!

mscdex commented Mar 16, 2015

Uh oh!

narqo commented Mar 29, 2015

Uh oh!

mscdex commented Mar 29, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants