Skip to content

test: skip pseudo-tty/no_dropped_stdio test - #8470

Closed
mhdawson wants to merge 1 commit into
nodejs:masterfrom
mhdawson:pseudo
Closed

test: skip pseudo-tty/no_dropped_stdio test#8470
mhdawson wants to merge 1 commit into
nodejs:masterfrom
mhdawson:pseudo

Conversation

@mhdawson

@mhdawsonmhdawson commented Sep 9, 2016

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

We had marked pseudo-tty/no_dropped_stdio as flaky but
in some failures it hangs and does not seem to timeout,
and or is reported as an error.

Also add prefix to status file as it was missing.

Also fix name of status file in testcfg.py. It
was pointing to message.status instead of
pseudo-tty.status.

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Sep 9, 2016
@mhdawsonmhdawson removed the test Issues and PRs related to the tests. label Sep 9, 2016
@mhdawson
test: skip pseudo-tty/no_dropped_stdio test
f44c13f
We had marked it as flaky but in some failures it hangs
and does not seem to timeout, and or is reported as
an error.
Also add prefix to status file as it was missing.
Also fix name of status file in testcfg.py. It
was pointing to message.status instead of
pseudo-tty.status.
@mhdawsonmhdawson self-assigned this Sep 9, 2016
@mhdawson

mhdawson commented Sep 9, 2016

Copy link
Copy Markdown
MemberAuthor

CI run: https://ci.nodejs.org/job/node-test-pull-request/3990/

@mhdawsonmhdawson added the test Issues and PRs related to the tests. label Sep 9, 2016
@mhdawson

mhdawson commented Sep 9, 2016

Copy link
Copy Markdown
MemberAuthor

CI run was all green.

@santigimeno

santigimeno commented Sep 9, 2016

Copy link
Copy Markdown
Member

LGTM

1 similar comment
@jasnell

jasnell commented Sep 10, 2016

Copy link
Copy Markdown
Member

LGTM

mhdawson added a commit that referenced this pull request Sep 12, 2016
@mhdawson
test: skip pseudo-tty/no_dropped_stdio test
1ffdbb6
We had marked it as flaky but in some failures it hangs
and does not seem to timeout, and or is reported as
an error.
Also add prefix to status file as it was missing.
Also fix name of status file in testcfg.py. It
was pointing to message.status instead of
pseudo-tty.status.
PR-URL: #8470
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@mhdawson

mhdawson commented Sep 12, 2016

Copy link
Copy Markdown
MemberAuthor

Landed as 1ffdbb6

Fishrock123 pushed a commit that referenced this pull request Sep 14, 2016
@mhdawson@Fishrock123
test: skip pseudo-tty/no_dropped_stdio test
3294c2c
We had marked it as flaky but in some failures it hangs
and does not seem to timeout, and or is reported as
an error.
Also add prefix to status file as it was missing.
Also fix name of status file in testcfg.py. It
was pointing to message.status instead of
pseudo-tty.status.
PR-URL: #8470
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
@mhdawsonMyles Borins
test: skip pseudo-tty/no_dropped_stdio test
fc9f46b
We had marked it as flaky but in some failures it hangs
and does not seem to timeout, and or is reported as
an error.
Also add prefix to status file as it was missing.
Also fix name of status file in testcfg.py. It
was pointing to message.status instead of
pseudo-tty.status.
PR-URL: #8470
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@mhdawsonmhdawson mentioned this pull request Oct 3, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
@mhdawsonMyles Borins
test: skip pseudo-tty/no_dropped_stdio test
2c31e5b
We had marked it as flaky but in some failures it hangs
and does not seem to timeout, and or is reported as
an error.
Also add prefix to status file as it was missing.
Also fix name of status file in testcfg.py. It
was pointing to message.status instead of
pseudo-tty.status.
PR-URL: #8470
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
@mhdawson@rvagg
test: skip pseudo-tty/no_dropped_stdio test
a3eb9b8
We had marked it as flaky but in some failures it hangs
and does not seem to timeout, and or is reported as
an error.
Also add prefix to status file as it was missing.
Also fix name of status file in testcfg.py. It
was pointing to message.status instead of
pseudo-tty.status.
PR-URL: #8470
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
@mhdawson@MylesBorins
test: skip pseudo-tty/no_dropped_stdio test
ad1230e
We had marked it as flaky but in some failures it hangs
and does not seem to timeout, and or is reported as
an error.
Also add prefix to status file as it was missing.
Also fix name of status file in testcfg.py. It
was pointing to message.status instead of
pseudo-tty.status.
PR-URL: #8470
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Oct 26, 2016
Closed
@mhdawson
mhdawson deleted the pseudo branch March 15, 2017 21:57
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mhdawsonmhdawson

Labels

testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mhdawson@santigimeno@jasnell@MylesBorins@nodejs-github-bot