Uh oh!
There was an error while loading. Please reload this page.
test: refactor test-net-pipe-connect-errors - #8473
Closed
Trott wants to merge 1 commit into
Closed
Conversation
* var -> const * try/catch -> assert.throws() * assert.ok(fail) -> common.fail() * assert.equal() -> assert.strictEqual() * replace `exit` handler with `common.mustCall()`
cjihrig
commented
Sep 9, 2016
Contributor
LGTM |
1 similar comment
lpinca
commented
Sep 10, 2016
Member
LGTM |
thefourtheye
commented
Sep 10, 2016
Contributor
LGTM, if CI is happy. |
lpinca
commented
Sep 10, 2016
Member
Trott
commented
Sep 10, 2016
MemberAuthor
Only CI failure is unrelated, will open a new issue. |
jasnell
commented
Sep 12, 2016
Member
LGTM |
Trott added a commit
to Trott/io.js
that referenced
this pull request
Sep 13, 2016
* var -> const * try/catch -> assert.throws() * assert.ok(fail) -> common.fail() * assert.equal() -> assert.strictEqual() * replace `exit` handler with `common.mustCall()` PR-URL: nodejs#8473 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Trott
commented
Sep 13, 2016
MemberAuthor
Landed in bf0a274 |
Fishrock123 pushed a commit
that referenced
this pull request
Sep 14, 2016
* var -> const * try/catch -> assert.throws() * assert.ok(fail) -> common.fail() * assert.equal() -> assert.strictEqual() * replace `exit` handler with `common.mustCall()` PR-URL: #8473 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test net
Description of change
exithandler withcommon.mustCall()