Uh oh!
There was an error while loading. Please reload this page.
Update ESLint, replace custom rule with built-in - #8478
Closed
Trott wants to merge 3 commits into
Closed
Conversation
ESLint 3.5.0 introduces a `no-restricted-properties` rule. Replace our custom `no-deepEqual` rule with this rule.
jasnell
commented
Sep 12, 2016
Member
LGTM if CI is green. |
Trott
commented
Sep 12, 2016
MemberAuthor
Trott added a commit
to Trott/io.js
that referenced
this pull request
Sep 13, 2016
PR-URL: nodejs#8478 Reviewed-By: James M Snell <jasnell@gmail.com>
Trott added a commit
to Trott/io.js
that referenced
this pull request
Sep 13, 2016
PR-URL: nodejs#8478 Reviewed-By: James M Snell <jasnell@gmail.com>
Trott added a commit
to Trott/io.js
that referenced
this pull request
Sep 13, 2016
ESLint 3.5.0 introduces a `no-restricted-properties` rule. Replace our custom `no-deepEqual` rule with this rule. PR-URL: nodejs#8478 Reviewed-By: James M Snell <jasnell@gmail.com>
Trott
commented
Sep 13, 2016
MemberAuthor
Fishrock123 pushed a commit
that referenced
this pull request
Sep 14, 2016
PR-URL: #8478 Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123 pushed a commit
that referenced
this pull request
Sep 14, 2016
PR-URL: #8478 Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123 pushed a commit
that referenced
this pull request
Sep 14, 2016
ESLint 3.5.0 introduces a `no-restricted-properties` rule. Replace our custom `no-deepEqual` rule with this rule. PR-URL: #8478 Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
commented
Sep 30, 2016
Contributor
@Trott do you want to backport this to lts? |
Trott
commented
Oct 1, 2016
MemberAuthor
@thealphanerd I'm inclined to skip it if it doesn't cause you any problems. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
tools
Description of change
Three commits:
newkeyword is used without parentheses. These are some edge cases that were missed by the previous version of ESLint. Basically, the rule got a bug fix, and now it's finding a tiny bit more stuff in our code.assert.deepEqual()with a built-in rule that does the same (and seems to find a few uses that our custom rule did not, so that's a plus).