Uh oh!
There was an error while loading. Please reload this page.
test: add coverage for client._addHandle() - #8518
Closed
Trott wants to merge 2 commits into
Closed
Conversation
bnoordhuis
commented
Sep 13, 2016
Member
LGTM. s/covereage/coverage/ in the commit log. |
thefourtheye
commented
Sep 13, 2016
Contributor
Can you include some bad cases as well? Like |
Trott
commented
Sep 13, 2016
MemberAuthor
Except for the last two, these are all bad cases. I can add more, I suppose. |
`Client.prototype._addHandle()` in the `_debugger` module has conditions around invalid properties that are not currently tested. This change adds some minimal unit tests.
Trott
commented
Sep 13, 2016
MemberAuthor
@thefourtheye Of course, I go and add |
Trott
commented
Sep 13, 2016
MemberAuthor
@thefourtheye I'm inclined to not include those at this time because:
So, I'd rather get these tests in as is. If we want to handle (for example) At least, that's what I'm thinking at the moment. Does that work for you? Good eye for the edge cases, gotta say. |
thefourtheye
commented
Sep 14, 2016
Contributor
Okay. We can discuss that in a separate PR. This LGTM. |
cjihrig
commented
Sep 14, 2016
Contributor
LGTM |
Trott
commented
Sep 14, 2016
MemberAuthor
Trott added a commit
to Trott/io.js
that referenced
this pull request
Sep 16, 2016
`Client.prototype._addHandle()` in the `_debugger` module has conditions around invalid properties that are not currently tested. This change adds some minimal unit tests. PR-URL: nodejs#8518 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Trott
commented
Sep 16, 2016
MemberAuthor
Landed in a01c365 |
MylesBorins pushed a commit
that referenced
this pull request
Oct 6, 2016
`Client.prototype._addHandle()` in the `_debugger` module has conditions around invalid properties that are not currently tested. This change adds some minimal unit tests. PR-URL: #8518 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Oct 10, 2016
`Client.prototype._addHandle()` in the `_debugger` module has conditions around invalid properties that are not currently tested. This change adds some minimal unit tests. PR-URL: #8518 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123 pushed a commit
that referenced
this pull request
Oct 11, 2016
`Client.prototype._addHandle()` in the `_debugger` module has conditions around invalid properties that are not currently tested. This change adds some minimal unit tests. PR-URL: #8518 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit
that referenced
this pull request
Oct 18, 2016
`Client.prototype._addHandle()` in the `_debugger` module has conditions around invalid properties that are not currently tested. This change adds some minimal unit tests. PR-URL: #8518 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Oct 26, 2016
`Client.prototype._addHandle()` in the `_debugger` module has conditions around invalid properties that are not currently tested. This change adds some minimal unit tests. PR-URL: #8518 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test debugger
Description of change
Client.prototype._addHandle()in the_debuggermodule has conditionsaround invalid properties that are not currently tested. This change
adds some minimal unit tests.