Skip to content

test: cleanup test-child-process-buffering - #8578

Closed
AdriVanHoudt wants to merge 1 commit into
nodejs:masterfrom
AdriVanHoudt:cleanup-test-child-process-buffering
Closed

test: cleanup test-child-process-buffering#8578
AdriVanHoudt wants to merge 1 commit into
nodejs:masterfrom
AdriVanHoudt:cleanup-test-child-process-buffering

Conversation

@AdriVanHoudt

@AdriVanHoudtAdriVanHoudt commented Sep 17, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

Cleanup according to nodejs/code-and-learn#56

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Sep 17, 2016
targos
targos approved these changes Sep 17, 2016
View reviewed changes

@targostargos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mscdexmscdex added the child_process Issues and PRs related to the child_process subsystem. label Sep 17, 2016
addaleax
addaleax approved these changes Sep 17, 2016
View reviewed changes

@addaleaxaddaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, CI: https://ci.nodejs.org/job/node-test-commit/5107/

lpinca
lpinca approved these changes Sep 19, 2016
View reviewed changes

@lpincalpinca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@addaleax

addaleax commented Sep 20, 2016

Copy link
Copy Markdown
Member

That arm failure was weird, so CI again: https://ci.nodejs.org/job/node-test-commit/5176/

jasnell
jasnell approved these changes Sep 20, 2016
View reviewed changes

@jasnelljasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

imyller
imyller approved these changes Sep 20, 2016
View reviewed changes

@imyllerimyller left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imyllerimyller self-assigned this Sep 20, 2016
@imyller

imyller commented Sep 20, 2016

Copy link
Copy Markdown
Member

I'll start landing this.

  • Five LGTMs
  • No objections
  • CI tests passed (only the usual CI failures)

imyller pushed a commit to imyller/node that referenced this pull request Sep 20, 2016
@AdriVanHoudt@imyller
test: cleanup test-child-process-buffering.js
1c81dd8
PR-URL: nodejs#8578
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
@imyller

imyller commented Sep 20, 2016

Copy link
Copy Markdown
Member

landed in 1c81dd8

Thank you for your contribution, @AdriVanHoudt

@imyllerimyller closed this Sep 20, 2016
@imyllerimyller removed their assignment Sep 20, 2016
@AdriVanHoudt
AdriVanHoudt deleted the cleanup-test-child-process-buffering branch September 20, 2016 20:44
@AdriVanHoudt

AdriVanHoudt commented Sep 20, 2016

Copy link
Copy Markdown
ContributorAuthor

@imyller thanks, np!

Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
@AdriVanHoudt@Fishrock123
test: cleanup test-child-process-buffering.js
5e5a1c0
PR-URL: #8578
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@lpincalpincalpinca approved these changes
@targostargostargos approved these changes
+1 more reviewer
@imyllerimyllerimyller approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

child_processIssues and PRs related to the child_process subsystem.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@AdriVanHoudt@addaleax@imyller@jasnell@lpinca@targos@mscdex@MylesBorins@nodejs-github-bot