Uh oh!
There was an error while loading. Please reload this page.
test: refactor test to use latest standards - #8582
Closed
burakgazi wants to merge 1 commit into
Closed
Conversation
eljefedelrodeodeljefe
commented
Sep 17, 2016
Contributor
LGTM. Can you please include the description of changes into the commit message? |
eljefedelrodeodeljefe
approved these changes
Sep 17, 2016
eljefedelrodeodeljefe
suggested changes
Sep 17, 2016
eljefedelrodeodeljefe
left a comment
Contributor
There was a problem hiding this comment.
LGTM with a nit. Can you please include the description of changes into the commit message?
burakgazi
commented
Sep 17, 2016
Author
mcollina
commented
Sep 17, 2016
Member
@burakgazi there is a typo in the commit message (standarts -> standards), and also the commas do not have a space before them. |
Refactored the code to latest standards, where all var is changed to const, functions are changed to arrow functions and assert.equal chaned to assert.strictEqual
cjihrig
reviewed
Sep 17, 2016
| }, function() { | ||
| socket2.bind({port: common.PORT + 1, exclusive: true}, function() { | ||
| }, () => { | ||
| socket2.bind({port: common.PORT + 1, exclusive: true}, () => { |
Contributor
There was a problem hiding this comment.
I thought the preferred style in core was to not have spaces inside of the curly braces. I could be wrong though.
cjihrig
approved these changes
Sep 17, 2016
cjihrig
left a comment
Contributor
There was a problem hiding this comment.
LGTM, although I don't really see a reason for moving to arrow functions in this case.
imyller
commented
Sep 20, 2016
Member
@eljefedelrodeodeljefe Could you update your review? I believe the changes you've requested have been made. Thank you. |
imyller
commented
Sep 20, 2016
Member
imyller
commented
Sep 20, 2016
Member
I'll start landing this:
|
imyller
commented
Sep 20, 2016
Member
landed in 0bfd103 Thank you for your contribution, @burakgazi |
imyller pushed a commit
that referenced
this pull request
Sep 20, 2016
Refactored the code to latest standards, where all var is changed to const, functions are changed to arrow functions and assert.equal chaned to assert.strictEqual PR-URL: #8582 Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Fishrock123 pushed a commit
that referenced
this pull request
Oct 11, 2016
Refactored the code to latest standards, where all var is changed to const, functions are changed to arrow functions and assert.equal chaned to assert.strictEqual PR-URL: #8582 Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
refactor test to use latest standards
- change var to const
- function to =>
- equal to strictEqual