test: refactor test-crypto test files

[griffithtp]

Checklist

• make lint
• make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
• commit message follows commit guidelines

Description of change

Updated ./test/parallel/test-crypto*

• var to const
• assert.equal to assert.StrictEqual, same with notEqual
• wrap callback with common.mustCall()

[cjihrig]

LGTM pending CI

[jasnell]

LGTM. when landing the commits will need to be squashed and the commit messages should be fixed up.

[jasnell]

@griffithtp ... thank you for this. Just to point out, the contributing.md file in the node.js project root directly includes the guidelines for commit message formatting. The person who lands this can clean these commits up but if you'd like to give it a go yourself that would be great!

[griffithtp]

@jasnell apologies for this. Rookie mistake.
If I run git rebase -i HEAD~3 now and push again would this fix it and squash?

[jasnell]

Yep. Specifically, the steps are git rebase -i HEAD~3, squash, redo the commit message, then force push to your branch. This PR will automatically pick up the changes.

[griffithtp]

Cool, thanks James @jasnell !
Is there a list of TODOs for newbie contributors we can follow to just crunch the tasks to do.
Otherwise I can carry on with the same principles from the conference last week?

[addaleax]

Is there a list of TODOs for newbie contributors we can follow to just crunch the tasks to do.

Well, there’s https://github.com/nodejs/node/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+contribution%22 if you’re feeling up for one of those?

Otherwise I can carry on with the same principles from the conference last week?

I don’t want to steal your thunder or anything, but… keep in mind that the kind of tasks we were doing was chosen specifically to have some good contributions to get used to the process. You can definitely look through the test files and watch for anything that you would consider a significant improvement!

Also, things that we just always need are more benchmarks + more tests (code coverage on Linux).

[jasnell]

... and doc fixes! we always need doc fixes!

[jasnell]

CI: https://ci.nodejs.org/job/node-test-pull-request/4219/

[addaleax]

make lint output:

/home/sqrt/src/node/test/parallel/test-crypto-hash.js
50:14 error Function argument in column 14, expected in 20 align-function-arguments
87:16 error Function argument in column 16, expected in 22 align-function-arguments
/home/sqrt/src/node/test/parallel/test-crypto-hmac.js
71:18 error Function argument in column 18, expected in 24 align-function-arguments
237:18 error Function argument in column 18, expected in 24 align-function-arguments
✖ 4 problems (4 errors, 0 warnings)

[lpinca]

@griffithtp can you take a look at the lint issues?

[griffithtp]

Apologies for late reply.
Have updated indent and ran make lint as suggested by @addaleax
then make -j2 test after rebase from latest upstream master

[fhinkel]

ping @griffithtp Sorry that this PR didn't get more attention. Do you want to rebase (again, sorry!) and ping me? Then I'll start the CI and we can land this. Thanks, sorry for the extra work.

[Trott]

I took the liberty of rebasing, resolving conflicts, and pushing to your branch. Hope that's OK! Given the staleness of the PR, I figured it probably wasn't a problem. I also edited the commit message a bit to reflect commit message guidelines and the narrower scope of the PR now that it's been rebased (because some of the changes in this PR were already done elsewhere).

CI: https://ci.nodejs.org/job/node-test-pull-request/9642/

[Trott]

Landed in 1df9340.

Thanks for the contribution! 🎉