Uh oh!
There was an error while loading. Please reload this page.
test: update var to const - #8599
Closed
matt-in-a-hat wants to merge 1 commit into
Closed
Conversation
imyller
commented
Sep 17, 2016
Member
@matt-in-a-hat Could you include reference to specific test in commit message? Thank you. |
Changed const to var
matt-in-a-hatforce-pushed
the
test-cluster-disconnect-unshared-udp
branch
from
September 20, 2016 07:40
81cb07b to
d3a3ba1Compareimyller
commented
Sep 20, 2016
Member
imyller
commented
Sep 20, 2016
Member
I'll start landing this.
|
imyller pushed a commit
to imyller/node
that referenced
this pull request
Sep 20, 2016
Changed var to const PR-URL: nodejs#8599 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
imyller
commented
Sep 20, 2016
Member
landed in 57b7e85 Thank you for your contribution, @matt-in-a-hat |
Fishrock123 pushed a commit
that referenced
this pull request
Oct 11, 2016
Changed var to const PR-URL: #8599 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
Updated var to const