Uh oh!
There was an error while loading. Please reload this page.
test: clean tls-connect-given-socket - #8616
Closed
thomasvanlankveld wants to merge 4 commits into
Closed
Conversation
Changed vars to consts and lets, assert.equals to assert.strictEquals and added common.mustCall around a connect callback
| var connected = net.connect(server.address().port, function() { | ||
| const connected = net.connect(server.address().port, function() { | ||
| establish(connected); | ||
| }); |
Member
There was a problem hiding this comment.
Could/should this function get a common.mustCall, too?
| client.on('data', function(chunk) { | ||
| data += chunk.toString(); | ||
| }); | ||
| client.on('end', function() { |
added 3 commits
September 18, 2016 12:42
Changed vars to consts and lets, assert.equals to assert.strictEquals and added common.mustCall around a connect callback
Added more common.mustCalls, switched to arrow functions
Merge branch 'clean-test-tls-connect-given-socket' of github.com:thomasvanlankveld/node into clean-test-tls-connect-given-socket
jasnell
commented
Sep 20, 2016
Member
imyller
commented
Sep 20, 2016
Member
@addaleax are you satisfied with the changes? Looks like your review suggestions have been addressed. |
addaleax
approved these changes
Sep 20, 2016
addaleax
left a comment
Member
There was a problem hiding this comment.
Yes, LGTM!
Also, I generally trust collaborators here to be able to tell whether my requested changes have been made – I appreciate the ping, but you don’t need to wait for me or anything.
| return client; | ||
| } | ||
| const { port } = server.address(); |
Member
There was a problem hiding this comment.
Nice trick, I should think of that the next time I do this.
imyller
commented
Sep 20, 2016
Member
I'll start landing this:
|
imyller pushed a commit
to imyller/node
that referenced
this pull request
Sep 20, 2016
Changed vars to consts and lets, assert.equals to assert.strictEquals and added common.mustCall around callbacks. Switched to arrow functions. PR-URL: nodejs#8616 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
imyller
commented
Sep 20, 2016
Member
landed in 80620d8 Thank you for your contribution, @thomasvanlankveld |
Fishrock123 pushed a commit
that referenced
this pull request
Oct 11, 2016
Changed vars to consts and lets, assert.equals to assert.strictEquals and added common.mustCall around callbacks. Switched to arrow functions. PR-URL: #8616 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesDescription of change
Changed vars to consts and lets, assert.equals to assert.strictEquals and added
common.mustCall around a connect callback