Add Eslint rule prefer-assert-methods by danyshaanan · Pull Request #8622 · nodejs/node

danyshaanan · 2016-09-17T11:10:43Z

Checklist

make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
commit message follows commit guidelines

(Commits will be squashed and properly named after some more review)

Description of change

Add ESLint rule for catching uses of assert() with binary operators (===, !===, ==, !=) which could be replaces with assert's methods - strictEqual/notStrictEqual/equal/notEqual.

Here is some of the output for:

./node tools/eslint/bin/eslint.js --cache --rulesdir=tools/eslint-rules test/

for a total of 86 errors.

~~If the rule will be deemed good, I'd be happy to fix these violations.~~ (fixed).

WDTY?

yorkie

LGTM except an ESLint error...

yorkie · 2016-09-17T11:32:53Z

+ '!==': 'notStrictEqual',
+ '==': 'equal',
+ '!=': 'notEqual'
+}


Semi-colon is missing i guess :)

Oops!! :O
Fixed.

danyshaanan · 2016-09-17T13:20:48Z

Fixed all violations in dada443, so now make -j8 test passes.

not-an-aardvark

LGTM

Trott

LGTM if CI is good

Trott · 2016-09-17T18:21:27Z

CI: https://ci.nodejs.org/job/node-test-pull-request/4090/

danyshaanan · 2016-09-18T09:11:59Z

This failed in CI on the 'test/arm-fanned' check, on which most builds failed lately, after a lengthy period of time. This also applies to this PR I've opened. Am I correct in guessing that this is an issue with the 'test/arm-fanned' execution and not the PRs? How can it be determined with better certainty?

Trott · 2016-09-18T20:32:39Z

Am I correct in guessing that this is an issue with the 'test/arm-fanned' execution and not the PRs?

Yes.

How can it be determined with better certainty?

Unfortunately, I think in this case it requires familiarity with the issue affecting those devices. But generally, it's a matter of looking at the console results in the Jenkins interface.

I suspect the issue will be resolved-ish soon. The resolution will turn the builds yellow, not green, but close enough for jazz. It's a case of those devices running the tests with --flaky-tests=run' when it should be running them with--flaky-tests=dontcare`. I suspect someone on @nodejs/build will get to the bottom of it soon.

jbergstroem · 2016-09-19T01:08:04Z

LGTM

jbergstroem · 2016-09-19T01:18:09Z

The python install was for some reason broken on that machine; had to manually fix it (reinstall didn't work)

JacksonTian · 2016-09-19T01:27:05Z

LGTM

yorkie · 2016-09-19T03:20:28Z

LGTM

jasnell

LGTM

PR-URL: #8622 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com> Reviewed-By: Jackson Tian <shvyo1987@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Teddy Katz <teddy.katz@gmail.com>

jasnell · 2016-09-20T23:36:58Z

Landed in d469321! Thank you!

MylesBorins · 2016-10-06T22:38:05Z

@danyshaanan glad to see you put this together!

PR-URL: #8622 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com> Reviewed-By: Jackson Tian <shvyo1987@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Teddy Katz <teddy.katz@gmail.com>

danyshaanan added 2 commits September 17, 2016 12:32

temp: add eslint rule prefer-assert-strictequal
7ff5dfd

temp: expand and rename prefer-assert-strictequal
da192c6

nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Sep 17, 2016

danyshaanan changed the title ~~Eslint~~Add Eslint rule prefer-assert-methodsSep 17, 2016

yorkie suggested changes Sep 17, 2016
View reviewed changes

temp: missing ;
da1565d

yorkie approved these changes Sep 17, 2016
View reviewed changes

danyshaanan added 2 commits September 17, 2016 14:48

temp: fix max-len eslint error
da23703

temp: fix prefer-assert-methods violations
dada443

not-an-aardvark approved these changes Sep 17, 2016
View reviewed changes

Trott approved these changes Sep 17, 2016
View reviewed changes

jasnell approved these changes Sep 20, 2016
View reviewed changes

jasnell closed this Sep 20, 2016

MylesBorins added the dont-land-on-v4.x label Oct 6, 2016

Uh oh!

Uh oh!

Conversation

danyshaanan commented Sep 17, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Description of change

Uh oh!

yorkie left a comment

Choose a reason for hiding this comment

Uh oh!

yorkieSep 17, 2016

Choose a reason for hiding this comment

Uh oh!

danyshaananSep 17, 2016

Choose a reason for hiding this comment

Uh oh!

danyshaanan commented Sep 17, 2016

Uh oh!

not-an-aardvark left a comment

Choose a reason for hiding this comment

Uh oh!

Trott left a comment

Choose a reason for hiding this comment

Uh oh!

Trott commented Sep 17, 2016

Uh oh!

danyshaanan commented Sep 18, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Trott commented Sep 18, 2016

Uh oh!

jbergstroem commented Sep 19, 2016

Uh oh!

jbergstroem commented Sep 19, 2016

Uh oh!

JacksonTian commented Sep 19, 2016

Uh oh!

yorkie commented Sep 19, 2016

Uh oh!

jasnell left a comment

Choose a reason for hiding this comment

Uh oh!

jasnell commented Sep 20, 2016

Uh oh!

MylesBorins commented Oct 6, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

danyshaanan commented Sep 17, 2016•
edited
Loading

danyshaanan commented Sep 18, 2016•
edited
Loading