Skip to content

tools: clean up icu/README.md formatting - #8660

Merged
ChALkeR merged 1 commit into
nodejs:masterfrom
ChALkeR:icu-readme
Sep 20, 2016
Merged

tools: clean up icu/README.md formatting#8660
ChALkeR merged 1 commit into
nodejs:masterfrom
ChALkeR:icu-readme

Conversation

@ChALkeR

@ChALkeRChALkeR commented Sep 20, 2016

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

tools

Description of change

Clean up icu/README.md formatting:

  1. Normalize headings.
  2. Specify language in all code blocks.

Extracted from #8551 to make that one easier to review.

/cc @Trott, @srl295.

@ChALkeRChALkeR added tools Issues and PRs related to the tools directory. i18n-api Issues and PRs related to the i18n implementation. labels Sep 20, 2016
@nodejs-github-botnodejs-github-bot added the tools Issues and PRs related to the tools directory. label Sep 20, 2016
@Trott

Copy link
Copy Markdown
Member

LGTM

@addaleaxaddaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

 1. Normalize headings.
2. Specify language in all code blocks.
PR-URL: nodejs#8660
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@ChALkeR
ChALkeR merged commit fe69d0d into nodejs:masterSep 20, 2016
@ChALkeR

Copy link
Copy Markdown
MemberAuthor

Landed in fe69d0d.

Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
 1. Normalize headings.
2. Specify language in all code blocks.
PR-URL: #8660
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n-apiIssues and PRs related to the i18n implementation.toolsIssues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@ChALkeR@Trott@addaleax@MylesBorins@nodejs-github-bot