Removes FIXME

[ALJCepeda]

Checklist

• make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
• commit message follows commit guidelines

Affected core subsystem(s)

Description of change

It's necessary to close the socket otherwise the test will hang
REF #4640

[lpinca]

Please don't change file permissions.

[Fishrock123]

I feel like the comment is pointing to an underlying bug in the dgram impl if it should not be necessary.

Looks like it's been there since the test was introduced in ALJCepeda@defa637

[ALJCepeda]

My apologies! The mode change was not intentional, I've reverted back to 644 and ran git config core.fileMode false to prevent this from happening again in the future.

@Fishrock123 Yes that makes sense. I will investigate dgram further and see if I can come up with a more definitive answer. If it is a bug, should I create an issue before attempting to resolve it?

[ALJCepeda]

@Fishrock123@Trott

When the first send call is made dgram will bind to port 0: https://github.com/nodejs/node/blob/master/lib/dgram.js#L349-L350

And start listening for messages by calling recvStart on its handle: https://github.com/nodejs/node/blob/master/lib/dgram.js#L110-L119

I think this is why you have to close the socket, otherwise the underlining handler stays bound. close calls recvStop on the handle: https://github.com/nodejs/node/blob/master/lib/dgram.js#L535

test-dgram-oob-buffer.js is not the only test that binds in this way:
https://github.com/nodejs/node/blob/master/test/parallel/test-dgram-close.js#L14-L15
https://github.com/nodejs/node/blob/master/test/sequential/test-dgram-pingpong.js#L36

However this seems unusual to me. test-dgram-oob-buffer.js will work without binding and that makes sense... it's only sending messages, not receiving any. I feel that rather than implicitly binding to the port on send it should be required that there's an explicit call to bind.

The other tests will work when I call bind

Thoughts?

[Trott]

/cc @bnoordhuis I suppose...

[cjihrig]

I think this is fine. Once you start sending data, the socket becomes bound and needs to be closed.

[bnoordhuis]

LGTM and sorry for the delay, I must've missed the notification.

Can you reword the commit log to something like 'test: remove obsolete comment from dgram test'? Thanks.

[cjihrig]

Should be completely unnecessary, but CI: https://ci.nodejs.org/job/node-test-pull-request/6314/

[cjihrig]

Landed in 89f8ef2. Thanks!