Skip to content

doc: add eugeneo to collaborators - #8696

Closed
eugeneo wants to merge 1 commit into
nodejs:masterfrom
eugeneo:readme
Closed

doc: add eugeneo to collaborators#8696
eugeneo wants to merge 1 commit into
nodejs:masterfrom
eugeneo:readme

Conversation

@eugeneo

Copy link
Copy Markdown
Contributor
Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

Docs change

Description of change

CC: @Trott

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 21, 2016
@Trott

Trott commented Sep 21, 2016

Copy link
Copy Markdown
Member

LGTM

EDIT: LGTM with @addaleax's comment

@eugeneo

Copy link
Copy Markdown
ContributorAuthor

@addaleax

addaleax commented Sep 21, 2016

Copy link
Copy Markdown
Member

Could you sort yourself in alphabetically by username, i.e. after estliberitas?

LGTM with that, and Welcome! 🎉

eugeneo pushed a commit that referenced this pull request Sep 21, 2016
PR-URL: #8696
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@eugeneo

Copy link
Copy Markdown
ContributorAuthor

Landed in b35f22b

@eugeneoeugeneo closed this Sep 21, 2016
@eugeneo
eugeneo deleted the readme branch September 21, 2016 17:41
MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
PR-URL: #8696
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
PR-URL: #8696
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
PR-URL: #8696
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
PR-URL: #8696
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
PR-URL: #8696
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorinsMylesBorins mentioned this pull request Oct 26, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@eugeneo@Trott@addaleax@MylesBorins@nodejs-github-bot