stream: improving error msg for stream by italoacasas · Pull Request #8801 · nodejs/node

italoacasas · 2016-09-27T03:56:28Z

Checklist

make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

stream

Description of change

Improving error msg when Transform._transform() is not implement
Improving error msg when Readable._read() is not implement
Removing extra word for error msg when Writable._write() is not implemented

Trott · 2016-09-27T04:25:32Z

I think we're still in a condition where (unfortunately) changing an error message means the change is semver major. (/cc @jasnell in case I'm wrong) Labeling semver-major.

Change looks good to me, although I would probably be inclined to omit the word method since the () makes it clear that it's a function in the first place. But that's totally a nit you can ignore.

ronkorving · 2016-09-27T09:38:37Z

I don't care too much about "method" being there or not, but I'm happy with this change 👍 (and agree it's semver-major)

italoacasas · 2016-09-27T12:15:59Z

@Trott my first through was _transform() is not implemented but then I see this on _writable https://github.com/nodejs/node/blob/master/lib/_stream_writable.js#L435, I just trying to maintain consistency. Maybe the correct solution is to fix _writable instead of adding method here.

lpinca · 2016-09-27T12:46:29Z

+1 for using consistent error messages. It's semver major so changing _write error message could also be an option.

…ented

…t implemented

italoacasas · 2016-09-27T13:19:21Z

I just remove method from Writable._write() and add the same error msg in Readable._read()

Fishrock123 · 2016-09-27T13:34:10Z

could you please add a newline at the end here?

Do we actually want to add that data to .gitignore? If I'm not wrong there is an ongoing discussion in another PR for .idea and another open PR to whitelist stuff instead of blacklisting.
I think .idea, .vscode and the others should be in the user global gitignore not here.

I found the PR: #6963
... I think is just better to add this kind of common files to .gitignore that asking people to add this to the global ignore. Just because this way we don't need to mention again something about this topic and really this don't hurt anyone

@italoacasas #8016 is a much better option imho.

jasnell · 2016-09-27T14:57:53Z

LGTM with nits addressed and green CI.

cjihrig

LGTM without the .gitignore changes.

cjihrig · 2016-09-27T15:48:57Z

These should be done elsewhere.

…en not implemented

italoacasas · 2016-09-27T20:59:09Z

Done

lpinca · 2016-09-27T21:03:10Z

LGTM

imyller

LGTM

imyller · 2016-09-29T20:13:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/4321/

imyller · 2016-09-29T22:34:19Z

I'll start landing this:

Five LGTMs
No objections
Requested modifications have been made
CI tests passed

Improve message when tranform._transform() method is not implemented Improve error message when Readable._read() is not implemented Remove extra word in err msg when Writable._write() when not implemented Remove extra word in err msg when Transform._transform() when not implemented PR-URL: #8801 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>

imyller · 2016-09-29T22:35:56Z

Landed in 560a589

Thank you for your effort and contribution, @italoacasas

jasnell · 2016-10-10T15:20:48Z

@nodejs/ctc ... any objections to this landing in v7.x?

Improve message when tranform._transform() method is not implemented Improve error message when Readable._read() is not implemented Remove extra word in err msg when Writable._write() when not implemented Remove extra word in err msg when Transform._transform() when not implemented PR-URL: #8801 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>

nodejs-github-bot added the stream Issues and PRs related to the stream subsystem. label Sep 27, 2016

Trott added the semver-major PRs that contain breaking changes and should be released in the next major version. label Sep 27, 2016

Italo A. Casas added 3 commits September 27, 2016 09:12

stream: improving msg when tranform._transform() method is not implem…
695871b
…ented

stream: improving err msg when Readable._read() is not implemented
2031aa2

stream: removing extra word in err msg when Writable._write() when no…
3b61f65
…t implemented

italoacasas changed the title ~~stream: improving msg when transform._transform() method is not implemented~~stream: improving error msg for streamSep 27, 2016

Fishrock123 reviewed Sep 27, 2016
View reviewed changes

jasnell approved these changes Sep 27, 2016
View reviewed changes

cjihrig requested changes Sep 27, 2016
View reviewed changes

Comment thread.gitignore Outdated
cjihrigSep 27, 2016
Copy link
Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should be done elsewhere.

stream: removing extra word in err msg when Transform._transform() wh…
e6c77b2
…en not implemented

lpinca approved these changes Sep 27, 2016
View reviewed changes

cjihrig approved these changes Sep 27, 2016
View reviewed changes

imyller approved these changes Sep 29, 2016
View reviewed changes

imyller self-assigned this Sep 29, 2016

imyller closed this Sep 29, 2016

imyller removed their assignment Sep 29, 2016

gibfahn mentioned this pull request Jun 15, 2017
Auditing for 6.11.1 nodejs/Release#230
Closed
3 tasks

Uh oh!

Uh oh!

Conversation

italoacasas commented Sep 27, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Affected core subsystem(s)

Description of change

Uh oh!

Trott commented Sep 27, 2016

Uh oh!

ronkorving commented Sep 27, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

italoacasas commented Sep 27, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lpinca commented Sep 27, 2016

Uh oh!

italoacasas commented Sep 27, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Fishrock123Sep 27, 2016

Choose a reason for hiding this comment

Uh oh!

lpincaSep 27, 2016

Choose a reason for hiding this comment

Uh oh!

italoacasasSep 27, 2016

Choose a reason for hiding this comment

Uh oh!

lpincaSep 27, 2016

Choose a reason for hiding this comment

Uh oh!

jasnell commented Sep 27, 2016

Uh oh!

cjihrig left a comment

Choose a reason for hiding this comment

Uh oh!

cjihrigSep 27, 2016

Choose a reason for hiding this comment

Uh oh!

italoacasas commented Sep 27, 2016

Uh oh!

lpinca commented Sep 27, 2016

Uh oh!

imyller left a comment

Choose a reason for hiding this comment

Uh oh!

imyller commented Sep 29, 2016

Uh oh!

imyller commented Sep 29, 2016

Uh oh!

imyller commented Sep 29, 2016

Uh oh!

jasnell commented Oct 10, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

italoacasas commented Sep 27, 2016•
edited
Loading

ronkorving commented Sep 27, 2016•
edited
Loading

italoacasas commented Sep 27, 2016•
edited
Loading

italoacasas commented Sep 27, 2016•
edited
Loading