Uh oh!
There was an error while loading. Please reload this page.
test: mark test-inspector flaky on windows - #8835
Closed
Trott wants to merge 1 commit into
Closed
Conversation
Trott
commented
Sep 28, 2016
MemberAuthor
eugeneo
commented
Sep 28, 2016
Contributor
LGTM, I'm planning to investigate the flakiness soon. |
cjihrig
approved these changes
Sep 28, 2016
Contributor
LGTM |
MylesBorins
approved these changes
Sep 28, 2016
Trott
commented
Sep 28, 2016
MemberAuthor
SmartOS build failure, but otherwise, CI is green. Windows TAP output has it marked as flaky. |
MylesBorins
commented
Sep 29, 2016
Contributor
SmartOS failure is infra related. I'm going to land this so we can move forward with the inspector backport |
MylesBorins
commented
Sep 29, 2016
Contributor
landed in 33dd4ec |
MylesBorins pushed a commit
that referenced
this pull request
Sep 29, 2016
PR-URL: #8835 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit
to MylesBorins/node
that referenced
this pull request
Sep 29, 2016
PR-URL: nodejs#8835 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell pushed a commit
that referenced
this pull request
Sep 29, 2016
PR-URL: #8835 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Sep 30, 2016
PR-URL: #8835 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change