Uh oh!
There was an error while loading. Please reload this page.
internal: fix TypeError in v8-polyfill - #8863
Closed
geek wants to merge 1 commit into
Closed
Conversation
targos
approved these changes
Sep 30, 2016
jasnell
commented
Sep 30, 2016
Member
cjihrig
approved these changes
Sep 30, 2016
bnoordhuis
requested changes
Oct 3, 2016
bnoordhuis
left a comment
Member
There was a problem hiding this comment.
I'd change the return false in readline() to return '', that way future call sites won't run into the same issue.
If other collaborators think this is fine though, I'm fine with it too.
geek
commented
Oct 4, 2016
MemberAuthor
@bnoordhuis fixed |
targos
approved these changes
Oct 4, 2016
bnoordhuis
approved these changes
Oct 5, 2016
bnoordhuis
commented
Oct 5, 2016
Member
geek
commented
Oct 5, 2016
MemberAuthor
This was the failure on AIX https://ci.nodejs.org/job/node-test-commit-aix/1300/ I reran the job and it succeeded: |
jasnell pushed a commit
that referenced
this pull request
Oct 6, 2016
PR-URL: #8863 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell
commented
Oct 6, 2016
Member
Landed in 47d1588 |
jasnell pushed a commit
that referenced
this pull request
Oct 6, 2016
PR-URL: #8863 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
commented
Oct 6, 2016
Contributor
added lts watch as this lands on v4.x let me know if it should not land |
jasnell
commented
Oct 7, 2016
Member
there's likely no harm in landing it. |
Fishrock123 pushed a commit
that referenced
this pull request
Oct 11, 2016
PR-URL: #8863 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Nov 18, 2016
PR-URL: #8863 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
v8 profile processor
Description of change
readline()can return a boolean, in which case, line 90 will throw an exception. This change addresses the issue by defaulting to a string inreadline()instead of returning false.