Uh oh!
There was an error while loading. Please reload this page.
tls: introduce secureContext for tls.connect - #8959
Closed
indutny wants to merge 1 commit into
Closed
Conversation
indutny
commented
Oct 6, 2016
MemberAuthor
indutny
commented
Oct 6, 2016
MemberAuthor
MylesBorinsforce-pushed
the
v4.x-staging
branch
2 times, most recently
from
October 10, 2016 22:18
6a126fb to
004d665Compareindutny
commented
Oct 23, 2016
MemberAuthor
@thealphanerd should it be landed? |
jasnell
commented
Oct 23, 2016
Member
Looks like this needs to be rebased. |
Add `secureContext` option to `tls.connect`. It is useful for caching client certificates, key, and CA certificates. PR-URL: nodejs#4246 Reviewed-By: James M Snell <jasnell@gmail.com>
indutnyforce-pushed
the
backport/c5b4f6bc996e25f9e24db8ed31df86010d2dfcec
branch
from
October 24, 2016 18:38
22d7fc6 to
125977bCompareindutny
commented
Oct 24, 2016
MemberAuthor
@jasnell Voila! Though, there were no conflict 😉 This PR will become stale again unless we'll land it. cc @thealphanerd |
jasnell
commented
Oct 26, 2016
Member
I'm good for this to land. |
indutny
commented
Oct 27, 2016
MemberAuthor
@thealphanerd should I just land it? How does it work? |
MylesBorins
commented
Oct 27, 2016
Contributor
you can land it on staging 😊 |
indutny
commented
Oct 27, 2016
MemberAuthor
Landed in d9b5437, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
tls
Description of change
Add
secureContextoption totls.connect. It is useful for cachingclient certificates, key, and CA certificates.
PR-URL: #4246
Reviewed-By: James M Snell jasnell@gmail.com
Backport of: #4246 (comment)