Skip to content

src: fix typo in #endif comment - #8989

Closed
juanandresnyc wants to merge 1 commit into
nodejs:masterfrom
juanandresnyc:srctypo001
Closed

src: fix typo in #endif comment#8989
juanandresnyc wants to merge 1 commit into
nodejs:masterfrom
juanandresnyc:srctypo001

Conversation

@juanandresnyc

@juanandresnycjuanandresnyc commented Oct 9, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@nodejs-github-botnodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Oct 9, 2016
@addaleaxaddaleax added the lib / src Issues and PRs related to general changes in the lib or src directory. label Oct 9, 2016
addaleax
addaleax approved these changes Oct 9, 2016
View reviewed changes

@addaleaxaddaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

thefourtheye
thefourtheye approved these changes Oct 9, 2016
View reviewed changes

@thefourtheyethefourtheye left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mscdex

mscdex commented Oct 9, 2016

Copy link
Copy Markdown
Contributor

LGTM

lpinca
lpinca approved these changes Oct 9, 2016
View reviewed changes

@lpincalpinca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasnelljasnell self-assigned this Oct 10, 2016
@jasnell

jasnell commented Oct 10, 2016

Copy link
Copy Markdown
Member

this is trivial enough that it shouldn't have to wait the full 48 hours to land. Will get it landed now

jasnell pushed a commit that referenced this pull request Oct 10, 2016
@juanandresnyc@jasnell
src: fix typo in #endif comment
13a204e
PR-URL: #8989
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Brian White <mscdex@mscdex.net>
@jasnell

jasnell commented Oct 10, 2016

Copy link
Copy Markdown
Member

Landed in 13a204e

@jasnelljasnell closed this Oct 10, 2016
jasnell pushed a commit that referenced this pull request Oct 10, 2016
@juanandresnyc@jasnell
src: fix typo in #endif comment
ee856d5
PR-URL: #8989
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Brian White <mscdex@mscdex.net>
Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
@juanandresnyc@Fishrock123
src: fix typo in #endif comment
59aa103
PR-URL: #8989
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins pushed a commit that referenced this pull request Nov 22, 2016
@juanandresnycMyles Borins
src: fix typo in #endif comment
b4353e9
PR-URL: #8989
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Brian White <mscdex@mscdex.net>
@MylesBorinsMylesBorins mentioned this pull request Nov 22, 2016
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
+1 more reviewer
@thefourtheyethefourtheyethefourtheye approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@jasnelljasnell

Labels

c++Issues and PRs that require attention from people who are familiar with C++.lib / srcIssues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@juanandresnyc@mscdex@jasnell@thefourtheye@addaleax@lpinca@cjihrig@MylesBorins@nodejs-github-bot