crypto: naming anonymouse functions

[solebox]

Checklist

• make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
• commit message follows commit guidelines

Affected core subsystem(s)

crypto

Description of change

rename anonymouse functions
Ref: #8913

[solebox]

fixes some of it , not the whole thing. as requested in the thread, pull request per module.

[addaleax]

Generally, this looks fine! Some of the lines need to be wrapped, and there’s a anonymouse typo in the commit message.

[addaleax]

Could you check that your lines are no longer than 80 characters?

[solebox]

done

[addaleax]

Oh, and if your commit only partially solves a Github issue, it’s better to use use Ref: than to use Fixes:, so that landing the PR doesn’t automatically close the issue.

[solebox]

submitted changes

[AndreasMadsen]

Are methods on the prototype object actually a problem? In a normal stack trace they will have a full name e.g. Hash.update, even if the function is technically anonymous.

functionC(){}C.prototype.method=function(){thrownewError('');}newC().method()

Error
at C.method (repl:1:42)
...

[solebox]

@AndreasMadsen when requesting .name i got an empty string.
that was the means of testing offered in the original issue posted.

i assume that mattered to some people when debugging

(check out the repl feedback , its pretty nice to have name set when you're using repl, really helps)

[mscdex]

Typically we like to keep the parameters all lined up if on multiple lines. However in the case that a lined up parameter on a new line would exceed the 80 character mark, it would probably be better to just move everything after the = to the next line and indent the entire function definition by 2 spaces.

Ditto for the changes below.

[solebox]

ok ill do that

[solebox]

done

[jasnell]

LGTM if CI is green.

[targos]

LGTM

[thefourtheye]

Change looks okay, but commit message could use the following changes

1. typo should be fixed and
2. if possible, an imperative verb could be used as the first word. For example, crypto: name anonymous functions

[jasnell]

CI: https://ci.nodejs.org/job/node-test-pull-request/4459/

[solebox]

@jasnell hello james , my commit only changes javascript i dont see a reason why it wont work on all platforms just the same.

looks like test-npm-install.js is the culprit (at least in the free-bsd box, arm has no report yet)
doesnt look like it has something to do with my changes
am i missing something here?

[gibfahn]

@soleboxy Those failures look like infrastructure issues.

[gibfahn]

New CI (we'll run it until it works ) https://ci.nodejs.org/job/node-test-pull-request/4490/

[lpinca]

LGTM

[addaleax]

LGTM

[addaleax]

CI: https://ci.nodejs.org/job/node-test-commit/5626/

[addaleax]

I’ll start landing this:

• Approvals (LGTM): 5
• No objections
• The PR has been open for the minimum time of 48 or 72 hours
• All of the requested changes have been made
• CI has only unrelated failures

[addaleax]

You author name in this commit is given as “solebox”. Is that intended or do you prefer to be listed (changelog, git log, AUTHORS file) with some other name? People typically prefer their full name, but ultimately it’s up to you.

[addaleax]

Landed in 6f05de4! 🎉

[MylesBorins]

I'm going to hold off on backporting this at the moment, but I'm very curious where we landed on this and thoughts on backporting to v6

[sam-github]

I think we should land it, it looks very safe, its baked for a while, and not having landed caused #11705 to not cherry-pick clean, triggering a backport, #14376.

[solebox]

thanks :)

[sam-github]

@MylesBorins I pushed this onto v6.x-staging, it cherry picks clean, and will help @tniessen with #14376 which we asked for.

Landed in e9235e8e2efb0443d0d770a7bdce4aff983fdbc9 for v6.x-staging.