Skip to content

console: name anonymous functions - #9047

Closed
tylerbrazier wants to merge 1 commit into
nodejs:masterfrom
tylerbrazier:console-fn-names
Closed

console: name anonymous functions#9047
tylerbrazier wants to merge 1 commit into
nodejs:masterfrom
tylerbrazier:console-fn-names

Conversation

@tylerbrazier

@tylerbraziertylerbrazier commented Oct 12, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

console

Description of change

Ref: #8913

@nodejs-github-botnodejs-github-bot added the console Issues and PRs related to the console subsystem. label Oct 12, 2016
@tylerbraziertylerbrazier changed the title console: naming anonymouse functionsconsole: naming anonymous functionsOct 12, 2016
imyller
imyller approved these changes Oct 12, 2016
View reviewed changes

@imyllerimyller left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

targos
targos approved these changes Oct 12, 2016
View reviewed changes

@targostargos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jasnell
jasnell approved these changes Oct 12, 2016
View reviewed changes

@jasnelljasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

lpinca
lpinca approved these changes Oct 12, 2016
View reviewed changes

@lpincalpinca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lpinca

lpinca commented Oct 12, 2016

Copy link
Copy Markdown
Member

Nit: replace "naming" with "name" in commit message title.

@tylerbraziertylerbrazier changed the title console: naming anonymous functionsconsole: name anonymous functionsOct 12, 2016
@lpinca

lpinca commented Oct 16, 2016

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/4532/

lpinca pushed a commit that referenced this pull request Oct 16, 2016
@tylerbrazier@lpinca
console: name anonymous functions
2ebd445
Ref: #8913
PR-URL: #9047
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@lpinca

lpinca commented Oct 16, 2016

Copy link
Copy Markdown
Member
  • Approvals (LGTM): 4
  • No objections
  • The PR has been open for the minimum time of 48 or 72 hours
  • All of the requested changes have been made
  • CI has only unrelated failures

Landed in 2ebd445.
Thank you!

@lpincalpinca closed this Oct 16, 2016
@tylerbrazier
tylerbrazier deleted the console-fn-names branch October 17, 2016 00:10
jasnell pushed a commit that referenced this pull request Oct 17, 2016
@tylerbrazier@jasnell
console: name anonymous functions
bd7d7a7
Ref: #8913
PR-URL: #9047
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorinsMylesBorins added the baking-for-lts PRs that need to wait before landing in a LTS release. label May 9, 2017
@gibfahngibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
@MylesBorinsMylesBorins added dont-land-on-v6.x and removed baking-for-lts PRs that need to wait before landing in a LTS release. lts-watch-v6.x labels Nov 14, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@targostargostargos approved these changes
+1 more reviewer
@imyllerimyllerimyller approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

consoleIssues and PRs related to the console subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@tylerbrazier@lpinca@jasnell@imyller@targos@MylesBorins@nodejs-github-bot