Skip to content

doc: fix typo in http doc - #9144

Closed
anu0012 wants to merge 1 commit into
nodejs:masterfrom
anu0012:master
Closed

doc: fix typo in http doc#9144
anu0012 wants to merge 1 commit into
nodejs:masterfrom
anu0012:master

Conversation

@anu0012

@anu0012anu0012 commented Oct 18, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Fix typo in http.md #9134

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels Oct 18, 2016
@mscdex

Copy link
Copy Markdown
Contributor

LGTM

@addaleaxaddaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fhinkel

Copy link
Copy Markdown
Member

Sorry to be nit-picking. But can you please add a space after doc: in the commit message and also include the issue that you're fixing in the message.

@rvagg
rvaggforce-pushed the master branch 2 times, most recently from c133999 to 83c7a88CompareOctober 18, 2016 17:02

@lpincalpinca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anu0012anu0012 changed the title doc:fix typo in http docdoc: fix typo in http docOct 18, 2016
@anu0012

Copy link
Copy Markdown
ContributorAuthor

@fhinkel I've made the changes.

jasnell pushed a commit that referenced this pull request Oct 26, 2016
PR-URL: #9144
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
@jasnell

Copy link
Copy Markdown
Member

Landed in d0d4ca5

@jasnelljasnell closed this Oct 26, 2016
evanlucas pushed a commit that referenced this pull request Nov 3, 2016
PR-URL: #9144
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
@evanlucasevanlucas mentioned this pull request Nov 3, 2016
@princejwesleyprincejwesley mentioned this pull request Nov 6, 2016
MylesBorins pushed a commit that referenced this pull request Nov 11, 2016
PR-URL: #9144
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins pushed a commit that referenced this pull request Nov 11, 2016
PR-URL: #9144
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
This was referenced Nov 22, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.httpIssues or PRs related to the http subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@anu0012@mscdex@fhinkel@jasnell@addaleax@lpinca@MylesBorins@nodejs-github-bot