Skip to content

tools: enable ES2016 support in ESLint - #9218

Merged
targos merged 1 commit into
nodejs:masterfrom
targos:eslint-es2016
Oct 24, 2016
Merged

tools: enable ES2016 support in ESLint#9218
targos merged 1 commit into
nodejs:masterfrom
targos:eslint-es2016

Conversation

@targos

@targostargos commented Oct 21, 2016

Copy link
Copy Markdown
Member
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

tools

Description of change

This allows to use the exponentiation operator.

Ref: #9208 (comment)

@targostargos added the tools Issues and PRs related to the tools directory. label Oct 21, 2016
@targostargos mentioned this pull request Oct 21, 2016
Merged
3 tasks
not-an-aardvark
not-an-aardvark approved these changes Oct 21, 2016
View reviewed changes

@not-an-aardvarknot-an-aardvark left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thefourtheye
thefourtheye reviewed Oct 21, 2016
View reviewed changes

@thefourtheyethefourtheye left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we consider performance implications of the new features before allowing us to use this?

@targos

targos commented Oct 21, 2016

Copy link
Copy Markdown
MemberAuthor

@thefourtheye you're right. Though I would be surprised if V8 didn't just convert this operator to a Math.pow call.
/cc @nodejs/v8

@thefourtheye

thefourtheye commented Oct 21, 2016

Copy link
Copy Markdown
Contributor

@targos Looks like, in ** case, it is internally translated to Math.pow call only, if I am not wrong. https://codereview.chromium.org/1678303002/diff/320001/src/parsing/parser.cc?context=10&column_width=80&tab_spaces=8

@targos

targos commented Oct 24, 2016

Copy link
Copy Markdown
MemberAuthor

Linter CI run: https://ci.nodejs.org/job/node-test-linter/4942/

@targos

targos commented Oct 24, 2016

Copy link
Copy Markdown
MemberAuthor

@thefourtheye LGTY ?

@thefourtheye

thefourtheye commented Oct 24, 2016

Copy link
Copy Markdown
Contributor

@targos What about the other features in es2016? Do we have any rough idea if they will also be performing at par with their es2015 equivalents? Because once we allow them in the linter it means that we officially allow es2016 in our codebase.

@targos

targos commented Oct 24, 2016

Copy link
Copy Markdown
MemberAuthor

The exponentiation operator is the only new syntax of ES2016. This change doesn't add support for other features.

lpinca
lpinca reviewed Oct 24, 2016
View reviewed changes
Comment thread.eslintrc Outdated

@lpincalpincaOct 24, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: what about adding a blank line before this one?

@targostargosOct 24, 2016

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack. I'll do it on merge

@targos

targos commented Oct 24, 2016

Copy link
Copy Markdown
MemberAuthor

Maybe I can change the commit message to tools: enable ES2016 syntax support in ESLint to make it clearer.

@targos
tools: enable ES2016 syntax support in ESLint
6031d8e
This allows us to use the exponentiation operator.
PR-URL: nodejs#9218
Ref: nodejs#9208 (comment)
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@targos

targos commented Oct 24, 2016

Copy link
Copy Markdown
MemberAuthor

Landed in 6031d8e

@targostargos closed this Oct 24, 2016
@targos
targos deleted the eslint-es2016 branch October 24, 2016 12:06
@targos
targos merged commit 6031d8e into nodejs:masterOct 24, 2016
jasnell pushed a commit that referenced this pull request Oct 24, 2016
@targos@jasnell
tools: enable ES2016 syntax support in ESLint
827660e
This allows us to use the exponentiation operator.
PR-URL: #9218
Ref: #9208 (comment)
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 17, 2016
@targosMyles Borins
tools: enable ES2016 syntax support in ESLint
5f0a0fa
This allows us to use the exponentiation operator.
PR-URL: #9218
Ref: #9208 (comment)
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 19, 2016
@targos@MylesBorins
tools: enable ES2016 syntax support in ESLint
a120199
This allows us to use the exponentiation operator.
PR-URL: #9218
Ref: #9208 (comment)
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Nov 22, 2016
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@jasnelljasnelljasnell approved these changes
@cjihrigcjihrigcjihrig approved these changes
+2 more reviewers
@thefourtheyethefourtheyethefourtheye approved these changes
@not-an-aardvarknot-an-aardvarknot-an-aardvark approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@targos@thefourtheye@jasnell@lpinca@cjihrig@not-an-aardvark@MylesBorins