Skip to content

buffer: use correct name for custom inspect symbol - #9289

Closed
charmander wants to merge 1 commit into
nodejs:masterfrom
charmander:buffer-inspect-symbol-reference
Closed

buffer: use correct name for custom inspect symbol#9289
charmander wants to merge 1 commit into
nodejs:masterfrom
charmander:buffer-inspect-symbol-reference

Conversation

@charmander

@charmandercharmander commented Oct 26, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • make -j8 test passes (in only 3 hours!)
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

buffer

Description of change

59714cb introduced the util.inspect.custom symbol, but it was exported as customInspectSymbol by internal/util.js and referenced as inspectSymbol by buffer.js.

@charmander
buffer: use correct name for custom inspect symbol
8d3a654
59714cb introduced the
`util.inspect.custom` symbol, but it was exported as
`customInspectSymbol` by `internal/util.js` and referenced as
`inspectSymbol` by `buffer.js`.
@nodejs-github-botnodejs-github-bot added the buffer Issues and PRs related to the buffer subsystem. label Oct 26, 2016
addaleax
addaleax approved these changes Oct 26, 2016
View reviewed changes

@addaleaxaddaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for catching this!

@addaleax

addaleax commented Oct 26, 2016

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-commit/5792/

jasnell pushed a commit that referenced this pull request Oct 28, 2016
@charmander@jasnell
buffer: use correct name for custom inspect symbol
66d5446
59714cb introduced the
`util.inspect.custom` symbol, but it was exported as
`customInspectSymbol` by `internal/util.js` and referenced as
`inspectSymbol` by `buffer.js`.
PR-URL: #9289
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

jasnell commented Oct 28, 2016

Copy link
Copy Markdown
Member

Landed in 66d5446

@jasnelljasnell closed this Oct 28, 2016
@charmander
charmander deleted the buffer-inspect-symbol-reference branch October 28, 2016 17:22
evanlucas pushed a commit that referenced this pull request Nov 3, 2016
@charmander@evanlucas
buffer: use correct name for custom inspect symbol
212da12
59714cb introduced the
`util.inspect.custom` symbol, but it was exported as
`customInspectSymbol` by `internal/util.js` and referenced as
`inspectSymbol` by `buffer.js`.
PR-URL: #9289
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@evanlucasevanlucas mentioned this pull request Nov 3, 2016
Merged
@MylesBorinsMylesBorins mentioned this pull request Nov 18, 2016
Closed
4 tasks
MylesBorins pushed a commit that referenced this pull request Nov 18, 2016
@charmanderMyles Borins
buffer: use correct name for custom inspect symbol
d93b69e
59714cb introduced the
`util.inspect.custom` symbol, but it was exported as
`customInspectSymbol` by `internal/util.js` and referenced as
`inspectSymbol` by `buffer.js`.
PR-URL: #9289
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit to addaleax/node that referenced this pull request Nov 18, 2016
@charmander@addaleax
buffer: use correct name for custom inspect symbol
974f984
59714cb introduced the
`util.inspect.custom` symbol, but it was exported as
`customInspectSymbol` by `internal/util.js` and referenced as
`inspectSymbol` by `buffer.js`.
PR-URL: nodejs#9289
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleaxaddaleax mentioned this pull request Nov 18, 2016
Closed
4 tasks
MylesBorins pushed a commit that referenced this pull request Nov 19, 2016
@charmander@MylesBorins
buffer: use correct name for custom inspect symbol
e108f20
59714cb introduced the
`util.inspect.custom` symbol, but it was exported as
`customInspectSymbol` by `internal/util.js` and referenced as
`inspectSymbol` by `buffer.js`.
PR-URL: #9289
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Nov 22, 2016
Merged
@alsoalso mentioned this pull request Aug 30, 2017
Closed
@snyk-botsnyk-bot mentioned this pull request Jan 11, 2023
Open
@alisccoaliscco mentioned this pull request Jun 21, 2023
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@cjihrigcjihrigcjihrig approved these changes

Assignees

No one assigned

Labels

bufferIssues and PRs related to the buffer subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@charmander@addaleax@jasnell@cjihrig@mscdex@MylesBorins@nodejs-github-bot