Uh oh!
There was an error while loading. Please reload this page.
test: fix lint error regarding unused commons const - #9334
Closed
danbev wants to merge 1 commit into
Closed
Conversation
Currently, make lint is failing with the following error: 3:7 error 'common' is assigned a value but never used no-unused-vars ✖ 1 problem (1 error, 0 warnings)
danbev
commented
Oct 28, 2016
ContributorAuthor
lpinca
approved these changes
Oct 28, 2016
2 tasks
gibfahn
approved these changes
Oct 28, 2016
Member
I don't think this needs to wait the full 48 hours. Linter passed, so it looks like CI was successful. |
lpinca
commented
Oct 28, 2016
Member
I agree. |
mcollina
commented
Oct 28, 2016
Member
Sorry about this. Just to understand, isn't the linter run within the CI test? |
lpinca
commented
Oct 28, 2016
Member
@mcollina yes. I think linter failed here https://ci.nodejs.org/job/node-test-commit/5798/ |
danbev
commented
Oct 28, 2016
ContributorAuthor
I'll merge this. Thanks for the reviews! |
danbev added a commit
to danbev/node
that referenced
this pull request
Oct 28, 2016
Currently, make lint is failing with the following error: 3:7 error 'common' is assigned a value but never used no-unused-vars ✖ 1 problem (1 error, 0 warnings) PR-URL: nodejs#9334 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
danbev
commented
Oct 28, 2016
ContributorAuthor
Landed in 690bded |
gibfahn
commented
Oct 28, 2016
Member
@mcollina I try to always run |
evanlucas pushed a commit
that referenced
this pull request
Nov 3, 2016
Currently, make lint is failing with the following error: 3:7 error 'common' is assigned a value but never used no-unused-vars ✖ 1 problem (1 error, 0 warnings) PR-URL: #9334 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins
commented
Nov 18, 2016
Contributor
Does anyone know which commit broke the linter? |
lpinca
commented
Nov 18, 2016
Member
@thealphanerd AFAIK the linter worked fine, it was just overlooked, see #9334 (comment). |
danbev
deleted the
fix-lint-issue-in-test-stream-writableState-ending.js
branch
January 17, 2017 07:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
Currently, make lint is failing with the following error: