Skip to content

lib: change == to === in linkedlist - #9362

Closed
jedireza wants to merge 1 commit into
nodejs:masterfrom
jedireza:linkedlist-triple-equals
Closed

lib: change == to === in linkedlist#9362
jedireza wants to merge 1 commit into
nodejs:masterfrom
jedireza:linkedlist-triple-equals

Conversation

@jedireza

@jedirezajedireza commented Oct 29, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

lib, timers

Description of change

change == to === in linkedlist

Also removed an old TODO comment that likely won't happen anymore.

@nodejs-github-botnodejs-github-bot added the timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. label Oct 29, 2016
@Trott

Trott commented Oct 29, 2016

Copy link
Copy Markdown
Member

LGTM if CI is ✅

@Trott

Trott commented Oct 29, 2016

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/4738/

@mscdex

mscdex commented Oct 29, 2016

Copy link
Copy Markdown
Contributor

LGTM

1 similar comment
@bengl

bengl commented Oct 29, 2016

Copy link
Copy Markdown
Member

LGTM

@Trott

Trott commented Oct 29, 2016

Copy link
Copy Markdown
Member

GREEN! CI IS GREEN! SECOND ONE IN A ROW!

@Fishrock123

Fishrock123 commented Oct 29, 2016

Copy link
Copy Markdown
Contributor

I think we should change the // TODO to a more helpful comment but of the same general nature

jasnell
jasnell approved these changes Oct 30, 2016
View reviewed changes

@jasnelljasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cjihrig
cjihrig approved these changes Oct 31, 2016
View reviewed changes

@cjihrigcjihrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change on line 19 LGTM. I don't know why the comment changed.

@jedireza

jedireza commented Oct 31, 2016

Copy link
Copy Markdown
ContributorAuthor

Apologies if the comment removal is a noisy change. I was working with @Trott and he mentioned we could remove the comment as the todo was not likely to happen.

Admittedly I'm not very familiar with this part of the code base. I'm happy to resolve by;

  • putting the comment back
  • rewording it like @Fishrock123 mentioned (I would need help with that)
  • fixing the todo (I would need help understanding the intuitive older items at "prev")

@Fishrock123

Fishrock123 commented Oct 31, 2016

Copy link
Copy Markdown
Contributor

I don't think fixing the TODO is viable because it is effectively public API. A comment should remain that the property names are opposite of what would be typically logical.

@Trott

Trott commented Oct 31, 2016

Copy link
Copy Markdown
Member

Agree 100% with @Fishrock123: The TODO should be removed because it isn't feasible. But a comment should remain highlighting that the names of the properties are the opposite of what you would intuitively expect.

@jedireza
lib: change == to === in linkedlist
92ebcef
Also removed a TODO comment that is no longer viable and left a note
about the potentially confusing property naming convention for future
readers.
@jedireza

jedireza commented Oct 31, 2016

Copy link
Copy Markdown
ContributorAuthor

I pushed edits updating the comment and commit message.

@silverwind

silverwind commented Nov 1, 2016

Copy link
Copy Markdown
Contributor

Thanks! Landed in 62d8134.

silverwind pushed a commit that referenced this pull request Nov 1, 2016
@jedireza@silverwind
lib: change == to === in linkedlist
62d8134
Also removed a TODO comment that is no longer viable and left a note
about the potentially confusing property naming convention for future
readers.
PR-URL: #9362
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@jedireza
jedireza deleted the linkedlist-triple-equals branch November 2, 2016 03:43
evanlucas pushed a commit that referenced this pull request Nov 3, 2016
@jedireza@evanlucas
lib: change == to === in linkedlist
5bfefa6
Also removed a TODO comment that is no longer viable and left a note
about the potentially confusing property naming convention for future
readers.
PR-URL: #9362
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@evanlucasevanlucas mentioned this pull request Nov 3, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Nov 22, 2016
@jedirezaMyles Borins
lib: change == to === in linkedlist
a178abf
Also removed a TODO comment that is no longer viable and left a note
about the potentially confusing property naming convention for future
readers.
PR-URL: #9362
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@MylesBorinsMylesBorins mentioned this pull request Nov 22, 2016
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@TrottTrottTrott approved these changes
@targostargostargos approved these changes
@cjihrigcjihrigcjihrig approved these changes
+1 more reviewer
@silverwindsilverwindsilverwind approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

timersIssues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@jedireza@Trott@mscdex@bengl@Fishrock123@silverwind@jasnell@targos@cjihrig@MylesBorins@nodejs-github-bot