Uh oh!
There was an error while loading. Please reload this page.
build: make test-ci output TAP to stdout and log - #938
Conversation
bnoordhuis
commented
Feb 24, 2015
LGTM |
rvagg
commented
Feb 24, 2015
FYI TAP output now in Jenkins: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/190/nodes=iojs-armv7-ubuntu1401/tapTestReport/ |
rvagg
commented
Feb 25, 2015
@bnoordhuis@indutny can you have a look at some of the runs after this merge, e.g. https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/193/ Is the |
Closes: nodejs#810 PR-URL: nodejs#938 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
indutny
commented
Feb 25, 2015
@rvagg could be related to a stray process that I see locally after |
indutny
commented
Feb 25, 2015
@rvagg this is what I see after |
indutny
commented
Feb 25, 2015
@bnoordhuis this seems to be your thing b5f25a9 |
bnoordhuis
commented
Feb 25, 2015
@indutny It is and I'm seeing that too, FWIW. I'll take a look. |
Fix parallel/test-stdio-closed introduced in commit b5f25a9 ("src: ensure that file descriptors 0-2 are valid") to not keep spawning child processes ad infinitum. The test spawns itself as a child process but a missing return statement made the child process spawn itself again, and again, and again. It went unnoticed for some time because the child process exits almost immediately afterwards, i.e. it didn't fill up the process table. The observable effect was an iojs process that was quietly consuming CPU cyles in the background with a PID that was constantly changing. Refs: nodejs#938 PR-URL: nodejs#948 Reviewed-By: Fedor Indutny <fedor@indutny.com>
Roughly the same as #810 but removes
messagefromtest-ciso we can actually use it. Produce TAP output and write a test.tap file so Jenkins can pick it up.R= @bnoordhuis
R= @jbergstroem