Distrust certs issued after 00:00:00 Oct. 21, 2016 by StartCom and WoSign

[shigeki]

Checklist

• make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

Affected core subsystem(s)

crypto, tls and test.

Description of change

Per discussion of #9434, this PR checks the certs issued by StartCom and WoSign and if notBefore is after 00:00:00 Oct. 21 2016, the tls client connection is failed with CERT_REVOKED error.

This also includes CNNIC whitelist update since #1895 that expired certs were removed and a minor bug fix of test/parallel/test-tls-cnnic-whitelist.js which came from 2bc7841.

R: @bnoordhuis

[shigeki]

CI is running on https://ci.nodejs.org/job/node-test-pull-request/4785/.

[bnoordhuis]

Mostly LGTM. There is a typo in the second commit log: s/udpate/update/

[bnoordhuis]

You could write this as for (auto it : StartComAndWoSignDNs) {

[seishun]

for (auto& startcom_wosign : StartComAndWoSignDNs) { to avoid a needless copy.

[shigeki]

Done. I used const auto& since it is just a reference.

[bnoordhuis]

Can you wrap this at 80 columns?

[shigeki]

Done. I missed Makefile is out of lint checks.

[not-an-aardvark]

Just as a precaution: How did you create these arrays? We might want to double-check that they are accurate. (I'm hoping to avoid an issue like this.)

[shigeki]

The data is ASN.1 encoded with Name type. Here is a list of subject names included in StartComAndWoSignData.inc and they all matches the names listed in https://bugzilla.mozilla.org/show_bug.cgi?id=1309707#c16 and certdata.txt in Node.

$ cat printStartComWoSign.cc
#include<cstdint>
#include<cstdio>
#include<x509.h>
#include<bio.h>
#include"StartComAndWoSignData.inc"intmain() {
char buf[1024];
constunsignedchar* startcom_wosign_data;
X509_NAME* startcom_wosign_name;
BIO *bio = BIO_new_fp(stdout, BIO_NOCLOSE);
for(constauto& it : StartComAndWoSignDNs) {
startcom_wosign_data = it.data;
startcom_wosign_name = d2i_X509_NAME(NULL, &startcom_wosign_data, it.len);
X509_NAME_oneline(startcom_wosign_name, buf, sizeof buf);
BIO_printf(bio, "%s\n", buf);
}
}
$ ./printStartComWoSign
/C=CN/O=WoSign CA Limited/CN=CA \xE6\xB2\x83\xE9\x80\x9A\xE6\xA0\xB9\xE8\xAF\x81\xE4\xB9\xA6
/C=CN/O=WoSign CA Limited/CN=CA WoSign ECC Root
/C=CN/O=WoSign CA Limited/CN=Certification Authority of WoSign
/C=CN/O=WoSign CA Limited/CN=Certification Authority of WoSign G2
/C=IL/O=StartCom Ltd./OU=Secure Digital Certificate Signing/CN=StartCom Certification Authority
/C=IL/O=StartCom Ltd./CN=StartCom Certification Authority G2

[jasnell]

Hmm... would there possibly be a more generic way of doing this? Adding functions that are specific to StartCom and WoSign seems... troubling.

[shigeki]

I don't think it leads troubling because this function checks the cert subject name with a specific type of structure provided by Mozilla only for StartCom and WoSign distrusting.
This function (and this features) will be removed after deprecating their root cert when all issued certs are expired. So I don't think it need to be more generic.

[jasnell]

const?

[shigeki]

Done.

[shigeki]

Fixed this according to the comments except the one from @jasnell .

@indutny Sorry for missing you to mention. Please look at this if you have time.

[indutny]

LGTM, if CI is green.

[indutny]

could it be const?

[shigeki]

It's not. I'm not sure why.

intX509_cmp_time(constASN1_TIME*s, time_t*t);

[shigeki]

CI is again running on https://ci.nodejs.org/job/node-test-pull-request/4795/ .

[seishun]

Minor, but calling it it is confusing, as it's not an iterator.

[shigeki]

@seishun Yes, I rename it to dn after 'distinguished name`. Thanks.

[ChALkeR]

@bnoordhuis, does that look good to you now?

[shigeki]

I've just resolved the conflict of test/parallel/test-tls-cnnic-whitelist.js and rebased against the latest master.

Firefox51 is to be stable on Jan 24th and Chrome56 is on Jan 31st, 2017. They will begin to have WoSing/StartCom checks in their stable release.

I think it is better to land this in the end of Jan, 2017 to align the browser release.

[shigeki]

Chrome 56 is released today. It is ready to land this. The approval from @bnoordhuis is needed. How is it?

[bnoordhuis]

LGTM. s/certifiate/certificate/ in the first commit log and I'd say "Remove expired certificates from CNNIC whitelist." in the second one.

[shigeki]

@bnoordhuis Oh, typo. Thanks. Fixed.

I also added an announcement link from apple https://support.apple.com/en-us/HT204132 in the commit log. I will land this tomorrow after rebasing and running CI.

After that, it should be discussed if it should be backported to LTS.

[jasnell]

I'm +1 on backporting this to 6 and 4. @nodejs/lts