Uh oh!
There was an error while loading. Please reload this page.
src: fix intermittent SIGSEGV in resolveTxt - #960
Closed
evanlucas wants to merge 1 commit into
Closed
Conversation
rvagg
commented
Feb 25, 2015
Member
Are we upstreaming these or are we giving up on working with c-ares? |
rvagg
commented
Feb 25, 2015
Member
Oh, sorry, this is the wrap. Ignore that comment then! LGTM and we can get this in 1.4.0. |
cjihrig
commented
Feb 26, 2015
Contributor
The following code reproduces the error with a well known site. Do you think it's worth adding this to the internet test suite? vardns=require('dns');dns.resolveTxt('www.microsoft.com',function(err,res){console.log(err);console.log(res);}); |
rvagg
commented
Feb 26, 2015
Member
@cjihrig probably .. it's simple enough and should probably go in test/internet |
evanlucas
commented
Feb 26, 2015
ContributorAuthor
k, ill add that |
Fixes a SIGSEGV by making sure `txt_chunk` is not empty before setting it on `txt_records`
evanlucas
commented
Feb 26, 2015
ContributorAuthor
Test has been added |
rvagg
commented
Feb 26, 2015
Member
lgtm, land it |
evanlucas added a commit
that referenced
this pull request
Feb 26, 2015
Fixes a SIGSEGV by making sure `txt_chunk` is not empty before setting it on `txt_records` PR-URL: #960 Reviewed-By: Rod Vagg <rod@vagg.org>
evanlucas
commented
Feb 26, 2015
ContributorAuthor
Landed in e435a01 |
evanlucas added a commit
to evanlucas/node-v0.x-archive
that referenced
this pull request
Feb 26, 2015
Fixes a SIGSEGV by making sure `txt_chunk` is not empty before setting it on `txt_records` PR-URL: nodejs/node#960 Reviewed-By: Rod Vagg <rod@vagg.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a SIGSEGV by making sure
txt_chunkis not empty before settingit on
txt_recordsRef: nodejs/node-v0.x-archive#9285