Skip to content

src: fix memory leak introduced in 34febfbf4 - #9604

Merged
bnoordhuis merged 1 commit into
nodejs:masterfrom
bnoordhuis:fix-bio-leak
Nov 18, 2016
Merged

src: fix memory leak introduced in 34febfbf4#9604
bnoordhuis merged 1 commit into
nodejs:masterfrom
bnoordhuis:fix-bio-leak

Conversation

@bnoordhuis

@bnoordhuisbnoordhuis commented Nov 14, 2016•
edited
Loading

Copy link
Copy Markdown
Member

@nodejs-github-botnodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Nov 14, 2016
@bnoordhuisbnoordhuis mentioned this pull request Nov 14, 2016
Closed
4 tasks
Fishrock123
Fishrock123 approved these changes Nov 14, 2016
View reviewed changes

@Fishrock123Fishrock123 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure I can trust my rusty C++ knowledge on this one.

@mscdexmscdex added the tls Issues and PRs related to the tls subsystem. label Nov 14, 2016
indutny
indutny approved these changes Nov 14, 2016
View reviewed changes

@indutnyindutny left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, OMG.

@rvagg

rvagg commented Nov 15, 2016

Copy link
Copy Markdown
Member

lgtm

mhdawson
mhdawson approved these changes Nov 15, 2016
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jasnell
jasnell approved these changes Nov 18, 2016
View reviewed changes

@jasnelljasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heh.. nice

addaleax
addaleax approved these changes Nov 18, 2016
View reviewed changes

@addaleaxaddaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bnoordhuis
src: fix memory leak introduced in34febfb
9f779d3
Fix leaking the BIO in the error path. Introduced in commit 34febfb
("crypto: fix handling of root_cert_store").
PR-URL: nodejs#9604
Refs: nodejs#9409
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
@bnoordhuis
bnoordhuis deleted the fix-bio-leak branch November 18, 2016 20:49
@bnoordhuis
bnoordhuis merged commit 9f779d3 into nodejs:masterNov 18, 2016
Fishrock123 pushed a commit that referenced this pull request Nov 22, 2016
@bnoordhuis@Fishrock123
src: fix memory leak introduced in34febfb
15af912
Fix leaking the BIO in the error path. Introduced in commit 34febfb
("crypto: fix handling of root_cert_store").
PR-URL: #9604
Refs: #9409
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
@shigeki

shigeki commented Dec 3, 2016

Copy link
Copy Markdown
Contributor

I missed to know this PR. I'm sorry for missing to find this leak in the review and thank for fixing.

@MylesBorins

MylesBorins commented Jan 23, 2017

Copy link
Copy Markdown
Contributor

I've backported this to v6.x. It will need to be included in the manual backport to v4.x with #9409

MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
@bnoordhuis@MylesBorins
src: fix memory leak introduced in34febfb
cb61b85
Fix leaking the BIO in the error path. Introduced in commit 34febfb
("crypto: fix handling of root_cert_store").
PR-URL: #9604
Refs: #9409
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
@sam-githubsam-github mentioned this pull request Jan 23, 2017
Closed
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
@bnoordhuis@MylesBorins
src: fix memory leak introduced in34febfb
570de44
Fix leaking the BIO in the error path. Introduced in commit 34febfb
("crypto: fix handling of root_cert_store").
PR-URL: #9604
Refs: #9409
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
@MylesBorinsMylesBorins mentioned this pull request Jan 24, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Jan 31, 2017
@bnoordhuis@MylesBorins
src: fix memory leak introduced in34febfb
cfa1b5a
Fix leaking the BIO in the error path. Introduced in commit 34febfb
("crypto: fix handling of root_cert_store").
PR-URL: #9604
Refs: #9409
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
sam-github pushed a commit to sam-github/node that referenced this pull request Feb 14, 2017
@bnoordhuis@sam-github
src: fix memory leak introduced in34febfb
6d0ce65
Fix leaking the BIO in the error path. Introduced in commit 34febfb
("crypto: fix handling of root_cert_store").
PR-URL: nodejs#9604
Refs: nodejs#9409
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2017
@bnoordhuis@MylesBorins
src: fix memory leak introduced in34febfb
8b4cc2f
Fix leaking the BIO in the error path. Introduced in commit 34febfb
("crypto: fix handling of root_cert_store").
PR-URL: #9604
Refs: #9409
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
MylesBorins pushed a commit that referenced this pull request Feb 22, 2017
@bnoordhuis@MylesBorins
src: fix memory leak introduced in34febfb
01280a0
Fix leaking the BIO in the error path. Introduced in commit 34febfb
("crypto: fix handling of root_cert_store").
PR-URL: #9604
Refs: #9409
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@bnoordhuis@MylesBorins
src: fix memory leak introduced in34febfb
a9eb093
Fix leaking the BIO in the error path. Introduced in commit 34febfb
("crypto: fix handling of root_cert_store").
PR-URL: #9604
Refs: #9409
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
@MylesBorinsMylesBorins mentioned this pull request Mar 9, 2017
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@cjihrigcjihrigcjihrig approved these changes
+3 more reviewers
@indutnyindutnyindutny approved these changes
@Fishrock123Fishrock123Fishrock123 approved these changes
@mhdawsonmhdawsonmhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.tlsIssues and PRs related to the tls subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

12 participants

@bnoordhuis@rvagg@shigeki@MylesBorins@indutny@jasnell@addaleax@Fishrock123@cjihrig@mhdawson@mscdex@nodejs-github-bot