Skip to content

doc: small improvements in readline code examples#9628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vsemozhetbyt wants to merge 2 commits into from
Closed

doc: small improvements in readline code examples #9628

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c19b0e
doc: small improvements in readline code examples
vsemozhetbyt Nov 15, 2016
28d9bde
doc: more improvements in readline code examples
vsemozhetbyt Nov 16, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions doc/api/readline.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,7 @@ const rl = readline.createInterface({

rl.question('What do you think of Node.js? ', (answer) => {
// TODO: Log the answer in a database
console.log('Thank you for your valuable feedback:', answer);
console.log(`Thank you for your valuable feedback: ${answer}`);

rl.close();
});
Expand DownExpand Up@@ -403,8 +403,8 @@ For instance: `[[substr1, substr2, ...], originalsubstring]`.

```js
function completer(line) {
var completions = '.help .error .exit .quit .q'.split(' ');
var hits = completions.filter((c) => { return c.indexOf(line) == 0 });
const completions = '.help .error .exit .quit .q'.split(' ');
const hits = completions.filter((c) => { return c.indexOf(line) === 0 });
// show all completions if none found
return [hits.length ? hits : completions, line];
}
Expand DownExpand Up@@ -512,7 +512,7 @@ const rl = readline.createInterface({
});

rl.on('line', (line) => {
console.log('Line from file:', line);
console.log(`Line from file: ${line}`);
});
```

Expand Down